Uploaded image for project: 'jBPM'
  1. jBPM
  2. JBPM-6330

Stunner - SessionDiagramPreview instances are not discarded

    XMLWordPrintable

Details

    • Bug
    • Resolution: Duplicate
    • Critical
    • None
    • 7.2.0.Final
    • Designer
    • 2018 Week 13-14, 2018 Week 15-16, 2018 Week 17-18

    Description

      SessionPresenterFactoryImpl creates instances of SessionDiagramPreview. Implementations of SessionDiagramPreview are @Dependent and their life-cycle managed by SessionPresenterFactoryImpl using a ManagedInstance. Great.

      However instances continue to @Observe events and since the instances will not be destroyed until SessionPresenterFactoryImpl is destroyed (by virtue of the ManagedInstance contract we end up with lots of unnecessary events.

      You can see this behaviour by running a (any will do) Stunner webapp and putting a break-point in SessionPreviewImpl.commandExecutedFired(). Following a fresh launch of the application and creating a new diagram the method will be hit X times. Close the diagram and create another. The method will be hit X*2. Close. Create. X*3 etc.

      Acceptance test

      1. Scenario from PR comment is fixed.

      Attachments

        Issue Links

          Activity

            People

              romartin@redhat.com Roger Martinez
              manstis@redhat.com Michael Anstis
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: