Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-9947

New Openshift project - runtime validation

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 3.3.0.M4
    • Fix Version/s: 3.3.0.M5
    • Component/s: server
    • Labels:
      None

      Gliffy Diagrams

      1. validate-runtime.patch
        9 kB
        Andre Dietisheim
      1. server-adapter.png
        43 kB
      2. validate-runtime.png
        109 kB

        Activity

        Hide
        rob.stryker Rob Stryker added a comment -

        validation status has been added =]

        Show
        rob.stryker Rob Stryker added a comment - validation status has been added =]
        Hide
        adietish Andre Dietisheim added a comment -

        reopened since I went back to the version that does not validate. I did not manage to handle all cases in time

        Show
        adietish Andre Dietisheim added a comment - reopened since I went back to the version that does not validate. I did not manage to handle all cases in time
        Hide
        adietish Andre Dietisheim added a comment -

        postponed since this is not vital.

        Show
        adietish Andre Dietisheim added a comment - postponed since this is not vital.
        Hide
        adietish Andre Dietisheim added a comment - - edited

        attached a patch, need intense checking.

        Basically the problem here is that we validate on behalf of several properties:

        • "create adapter" checkbox
        • "available runtimes" items in the combo
        • "selected runtime" selected combo item

        To solve this with databinding we do not add validators to bindings. Validators in bindings are only able to validate single values (not composite properties). In databinding we add a MultiValidator to the DataBindingContext. The only tricky part is that you have to access all values, that take part in the the validation result, on behalf of observable values (and not in widgets/beans). The MultiValidator tracks behind the scene what observables are accessed and elaborates when he has to revalidate instead of returning a cached value. If your validator impl accesses the validation values in widgets (not observables), then the validator wont be called when the values, that participate in the validation, change.

        Show
        adietish Andre Dietisheim added a comment - - edited attached a patch, need intense checking. Basically the problem here is that we validate on behalf of several properties: "create adapter" checkbox "available runtimes" items in the combo "selected runtime" selected combo item To solve this with databinding we do not add validators to bindings. Validators in bindings are only able to validate single values (not composite properties). In databinding we add a MultiValidator to the DataBindingContext. The only tricky part is that you have to access all values, that take part in the the validation result, on behalf of observable values (and not in widgets/beans). The MultiValidator tracks behind the scene what observables are accessed and elaborates when he has to revalidate instead of returning a cached value. If your validator impl accesses the validation values in widgets (not observables), then the validator wont be called when the values, that participate in the validation, change.
        Hide
        adietish Andre Dietisheim added a comment -

        committed patch to TRUNK (Beta1)

        Show
        adietish Andre Dietisheim added a comment - committed patch to TRUNK (Beta1)
        Hide
        adietish Andre Dietisheim added a comment - - edited

        I also cleaned the layout a bit so that all actual widgets get left aligned below each other (and centered vertically if displayed in 1 row).

        committed to TRUNK (Beta1)

        Show
        adietish Andre Dietisheim added a comment - - edited I also cleaned the layout a bit so that all actual widgets get left aligned below each other (and centered vertically if displayed in 1 row). committed to TRUNK (Beta1)
        Hide
        mmalina Martin Malina added a comment -

        This is how it looks now:

        Show
        mmalina Martin Malina added a comment - This is how it looks now:
        Hide
        mmalina Martin Malina added a comment -

        I'm closing this JIRA as it is out of date. The behavior is different now.

        Show
        mmalina Martin Malina added a comment - I'm closing this JIRA as it is out of date. The behavior is different now.

          People

          • Assignee:
            rob.stryker Rob Stryker
            Reporter:
            rob.stryker Rob Stryker
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development