Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-9605

Runtimes are not configurable (JBIDE-1354)

    Details

      Description

      JBIDE-1354 should provide the possibility to save runtime configurations. These configurations are stored in the paths .plugins/org.jboss.ide.eclipse.as.core/.global/filesets/runtimeClasspaths/org.jboss.ide.eclipse.as.runtime.32 etc.

      However, there is only the path .plugins/org.jboss.ide.eclipse.as.core/.global/filesets/default and additions to a runtime like "JBoss 7.x Runtime" are not possible. If I manually create the path .plugins/org.jboss.ide.eclipse.as.core/.global/filesets/runtimeClasspaths, then a new entry can be added and there is e.g. org.jboss.ide.eclipse.as.runtime.70.

        Gliffy Diagrams

          Activity

          Hide
          maxandersen Max Rydahl Andersen added a comment -

          wrong component/assignee. now fixed.

          Show
          maxandersen Max Rydahl Andersen added a comment - wrong component/assignee. now fixed.
          Hide
          rob.stryker Rob Stryker added a comment -

          Requesting permission for following patch:

              1. Eclipse Workspace Patch 1.0
                #P org.jboss.ide.eclipse.as.classpath.core
                Index: src/org/jboss/ide/eclipse/as/classpath/core/runtime/CustomRuntimeClasspathModel.java
                ===================================================================
              • src/org/jboss/ide/eclipse/as/classpath/core/runtime/CustomRuntimeClasspathModel.java (revision 34514)
                +++ src/org/jboss/ide/eclipse/as/classpath/core/runtime/CustomRuntimeClasspathModel.java (working copy)
                @@ -219,6 +219,9 @@
                }

          public static void saveFilesets(IRuntimeType runtime, IDefaultPathProvider[] sets) {
          + if( !DEFAULT_CLASSPATH_FS_ROOT.toFile().exists())

          { + DEFAULT_CLASSPATH_FS_ROOT.toFile().mkdirs(); + }

          IPath fileToWrite = DEFAULT_CLASSPATH_FS_ROOT.append(runtime.getId());
          XMLMemento memento = XMLMemento.createWriteRoot("classpathProviders"); //$NON-NLS-1$
          for( int i = 0; i < sets.length; i++ ) {

          Show
          rob.stryker Rob Stryker added a comment - Requesting permission for following patch: Eclipse Workspace Patch 1.0 #P org.jboss.ide.eclipse.as.classpath.core Index: src/org/jboss/ide/eclipse/as/classpath/core/runtime/CustomRuntimeClasspathModel.java =================================================================== src/org/jboss/ide/eclipse/as/classpath/core/runtime/CustomRuntimeClasspathModel.java (revision 34514) +++ src/org/jboss/ide/eclipse/as/classpath/core/runtime/CustomRuntimeClasspathModel.java (working copy) @@ -219,6 +219,9 @@ } public static void saveFilesets(IRuntimeType runtime, IDefaultPathProvider[] sets) { + if( !DEFAULT_CLASSPATH_FS_ROOT.toFile().exists()) { + DEFAULT_CLASSPATH_FS_ROOT.toFile().mkdirs(); + } IPath fileToWrite = DEFAULT_CLASSPATH_FS_ROOT.append(runtime.getId()); XMLMemento memento = XMLMemento.createWriteRoot("classpathProviders"); //$NON-NLS-1$ for( int i = 0; i < sets.length; i++ ) {
          Hide
          maxandersen Max Rydahl Andersen added a comment -

          rob - okey to put in since there are other respins.

          One thing though for future reference - the location shouldn't be a constant since that location is dynamic in an eclipse installation.

          Show
          maxandersen Max Rydahl Andersen added a comment - rob - okey to put in since there are other respins. One thing though for future reference - the location shouldn't be a constant since that location is dynamic in an eclipse installation.
          Hide
          rob.stryker Rob Stryker added a comment -

          committed to branch and trunk

          Show
          rob.stryker Rob Stryker added a comment - committed to branch and trunk
          Hide
          lzoubek Libor Zoubek added a comment -

          verified on 3.3.0.M3-H18

          Show
          lzoubek Libor Zoubek added a comment - verified on 3.3.0.M3-H18

            People

            • Assignee:
              rob.stryker Rob Stryker
              Reporter:
              juergen.zimmermann Juergen Zimmermann
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development