Details

    • Type: Enhancement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 3.3.0.M3
    • Fix Version/s: 3.3.0.M3
    • Component/s: server
    • Labels:
      None

      Description

      the build on hudson currently fails. it misses the egit/jgit bundles:

      Bundle org.jboss.ide.eclipse.as.egit.core - Missing Constraint: Require-Bundle: org.eclipse.jgit; bundle-version="[1.1.0,2.0.0)"
      Bundle org.jboss.ide.eclipse.as.egit.core - Missing Constraint: Require-Bundle: org.eclipse.egit; bundle-version="[1.1.0,2.0.0)"
      Bundle org.jboss.ide.eclipse.as.egit.core - Missing Constraint: Require-Bundle: org.eclipse.egit.core; bundle-version="[1.1.0,2.0.0)"
      Bundle org.jboss.ide.eclipse.as.egit.core - Missing Constraint: Require-Bundle: org.eclipse.egit.ui; bundle-version="[1.1.0,2.0.0)"

      see http://hudson.qa.jboss.com/hudson/job/jbosstools-3.3_trunk.continuous/2542/console

        Gliffy Diagrams

        1. features-plugins-site.xml.patch
          2 kB
          Nick Boldt
        2. manifest.patch
          2 kB
          Nick Boldt

          Issue Links

            Activity

            adietish Andre Dietisheim created issue -
            Hide
            nickboldt Nick Boldt added a comment -

            I can do this for JBT, but for JBDS the eGit stuff is on the Extras site – not part of the base install.

            Therefore either eGit must move to Core, along with the implied support, and be part of the base JBDS 5 install - or this new org.jboss.ide.eclipse.as.server.egit.integration.feature feature has to be omitted from the Core and only included on the Extras site as part of the JBDS Git Integration feature (or a second feature).

            Does that make sense?

            Should the org.jboss.ide.eclipse.as.server.egit.integration.feature be INCLUDED in the http://svn.jboss.org/repos/devstudio/trunk/extras/features/com.jboss.jbds.git.feature/ feature? Or should it exist in parallel on the Extras site?

            Show
            nickboldt Nick Boldt added a comment - I can do this for JBT, but for JBDS the eGit stuff is on the Extras site – not part of the base install. Therefore either eGit must move to Core, along with the implied support , and be part of the base JBDS 5 install - or this new org.jboss.ide.eclipse.as.server.egit.integration.feature feature has to be omitted from the Core and only included on the Extras site as part of the JBDS Git Integration feature (or a second feature). Does that make sense? Should the org.jboss.ide.eclipse.as.server.egit.integration.feature be INCLUDED in the http://svn.jboss.org/repos/devstudio/trunk/extras/features/com.jboss.jbds.git.feature/ feature? Or should it exist in parallel on the Extras site?
            adietish Andre Dietisheim made changes -
            Field Original Value New Value
            Link This issue relates to JBIDE-9510 [ JBIDE-9510 ]
            Hide
            nickboldt Nick Boldt added a comment - - edited

            1. git mirror moved to Core [1] from Extras [2], and rebuilt (corrupt metadata?)

            [1] http://download.jboss.org/jbosstools/updates/indigo/SR0/
            [2] http://download.jboss.org/jbosstools/updates/indigo/extras/SR0/

            2. jgit/egit features and dependent 3rd party stuff added to JBT TP, spun locally, and committed. Spinning in Hudson now and will trigger downstream too. https://hudson.qa.jboss.com/hudson/job/jbosstools-3.3_trunk.target-platform/

            3. Disabled feature/plugins in AS will be re-enabled and the AS site and the aggregate site for JBT; however, cannot get them to compile. See next comment.

            Show
            nickboldt Nick Boldt added a comment - - edited 1. git mirror moved to Core [1] from Extras [2] , and rebuilt (corrupt metadata?) [1] http://download.jboss.org/jbosstools/updates/indigo/SR0/ [2] http://download.jboss.org/jbosstools/updates/indigo/extras/SR0/ 2. jgit/egit features and dependent 3rd party stuff added to JBT TP, spun locally, and committed. Spinning in Hudson now and will trigger downstream too. https://hudson.qa.jboss.com/hudson/job/jbosstools-3.3_trunk.target-platform/ 3. Disabled feature/plugins in AS will be re-enabled and the AS site and the aggregate site for JBT; however, cannot get them to compile. See next comment.
            Hide
            nickboldt Nick Boldt added a comment -

            Cannot compile your two new plugins against eGit 1.0, and am not sure where to get eGit 1.1 as the latest available on http://download.eclipse.org/egit/updates/ is 1.0.0.

            Will attach patches which I'd apply locally to add the plugins and feature to the maven reactor then to the update site... but which don't work due to this compilation error:

            [ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:0.12.0:compile (default-compile) on project org.jboss.ide.eclipse.as.egit.core: Compilation failure: Compilation failure:
            [ERROR] /home/nboldt/eclipse/workspace-jboss/jbosstools_trunk/as/plugins/org.jboss.ide.eclipse.as.egit.core/src/org/jboss/ide/eclipse/as/egit/core/EGitUtils.java (at line 112):[-1,-1]
            [ERROR] return new PushOperation(repository, remoteName, false, PUSH_TIMEOUT);
            [ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
            [ERROR] The constructor PushOperation(Repository, String, boolean, int) is undefined

            Show
            nickboldt Nick Boldt added a comment - Cannot compile your two new plugins against eGit 1.0, and am not sure where to get eGit 1.1 as the latest available on http://download.eclipse.org/egit/updates/ is 1.0.0. Will attach patches which I'd apply locally to add the plugins and feature to the maven reactor then to the update site... but which don't work due to this compilation error: [ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:0.12.0:compile (default-compile) on project org.jboss.ide.eclipse.as.egit.core: Compilation failure: Compilation failure: [ERROR] /home/nboldt/eclipse/workspace-jboss/jbosstools_trunk/as/plugins/org.jboss.ide.eclipse.as.egit.core/src/org/jboss/ide/eclipse/as/egit/core/EGitUtils.java (at line 112):[-1,-1] [ERROR] return new PushOperation(repository, remoteName, false, PUSH_TIMEOUT); [ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [ERROR] The constructor PushOperation(Repository, String, boolean, int) is undefined
            nickboldt Nick Boldt made changes -
            Assignee Nick Boldt [ nickboldt ] Andre Dietisheim [ adietish ]
            Hide
            nickboldt Nick Boldt added a comment - - edited

            manifest.patch - expands the requirement ranges to allow egit/jgit 1.0.

            features-plugins-site.xml.patch - adds plugins & feature to maven reactor, then new feature to site.xml for inclusion in AS update site.

            NOTE: will still need to add this new feature to the Aggregate site in http://anonsvn.jboss.org/repos/jbosstools/trunk/build/aggregate/site/site.xml

            Show
            nickboldt Nick Boldt added a comment - - edited manifest.patch - expands the requirement ranges to allow egit/jgit 1.0. features-plugins-site.xml.patch - adds plugins & feature to maven reactor, then new feature to site.xml for inclusion in AS update site. NOTE : will still need to add this new feature to the Aggregate site in http://anonsvn.jboss.org/repos/jbosstools/trunk/build/aggregate/site/site.xml
            nickboldt Nick Boldt made changes -
            Attachment manifest.patch [ 12346571 ]
            Attachment features-plugins-site.xml.patch [ 12346572 ]
            Hide
            nickboldt Nick Boldt added a comment - - edited

            OK, found a better solution, which I'm committing. Added the latest nightly build of eGit 1.1 here:

            http://download.jboss.org/jbosstools/updates/requirements/egit/1.1.0.201108230343/

            And now I can compile everything – committed change to features/pom.xml, plugins/pom.xml, site/site.xml and aggregate site (http://anonsvn.jboss.org/repos/jbosstools/trunk/build/aggregate/site/site.xml).

            Still need convincing that it's time to move up from eGit 1.0R to eGit 1.1N in the target platform, however.

            Show
            nickboldt Nick Boldt added a comment - - edited OK, found a better solution, which I'm committing. Added the latest nightly build of eGit 1.1 here: http://download.jboss.org/jbosstools/updates/requirements/egit/1.1.0.201108230343/ And now I can compile everything – committed change to features/pom.xml, plugins/pom.xml, site/site.xml and aggregate site ( http://anonsvn.jboss.org/repos/jbosstools/trunk/build/aggregate/site/site.xml ). Still need convincing that it's time to move up from eGit 1.0R to eGit 1.1N in the target platform, however.
            Hide
            adietish Andre Dietisheim added a comment -

            oh, it was not intentional to rely on 1.1. I need some time to check why we actually depend on 1.1

            Show
            adietish Andre Dietisheim added a comment - oh, it was not intentional to rely on 1.1. I need some time to check why we actually depend on 1.1
            adietish Andre Dietisheim made changes -
            Link This issue depends JBIDE-9585 [ JBIDE-9585 ]
            Hide
            adietish Andre Dietisheim added a comment -

            I corrected the egit plugins we have (org.jboss.ide.eclipse.as.egit.*) to depend on EGit 1.0 in JBIDE-9585.

            Show
            adietish Andre Dietisheim added a comment - I corrected the egit plugins we have (org.jboss.ide.eclipse.as.egit.*) to depend on EGit 1.0 in JBIDE-9585 .
            Hide
            nickboldt Nick Boldt added a comment -

            https://hudson.qa.jboss.com/hudson/view/DevStudio_Trunk/job/jbosstools-3.3_trunk.component--as/changes shows your changes and build is blue.

            Have removed refs to 1.1N site in pom.xml files.

            Show
            nickboldt Nick Boldt added a comment - https://hudson.qa.jboss.com/hudson/view/DevStudio_Trunk/job/jbosstools-3.3_trunk.component--as/changes shows your changes and build is blue. Have removed refs to 1.1N site in pom.xml files.
            nickboldt Nick Boldt made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Done [ 1 ]
            adietish Andre Dietisheim made changes -
            Fix Version/s 3.3.0.M3 [ 12316349 ]
            mmalina Martin Malina made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            velias Vlastimil Eliáš made changes -
            Workflow jira [ 12468782 ] GIT Pull Request workflow [ 12515076 ]

              People

              • Assignee:
                adietish Andre Dietisheim
                Reporter:
                adietish Andre Dietisheim
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development