Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-9445

Duplicate "Source" menu in Eclipse menubar when the open editor is VPE and focus is in "Package Explorer"

        Details

          Description

          The "Source" menu is duplicated when VPE is opened and the "Package Explorer" view is in focus. See attached screenshots.

            Gliffy Diagrams

            1. screenshot-1.jpg
              21 kB
            2. screenshot-2.jpg
              61 kB
            3. screenshot-3.jpg
              16 kB

              Issue Links

              cloned to

              Bug - A problem which impairs or prevents the functions of the product. JBIDE-9751 Duplicate "Source" menu in Eclipse menubar when the open editor is VPE and focus is in "Package Explorer"

              • Minor - Minor loss of function, or other problem where easy workaround is present.
              • Closed
              is related to

              Bug - A problem which impairs or prevents the functions of the product. JBIDE-4008 Two "Source" menu items in the menubar if some package in "Package Explorer" selected

              • Minor - Minor loss of function, or other problem where easy workaround is present.
              • Closed
              relates to

              Bug - A problem which impairs or prevents the functions of the product. JBIDE-6287 Externilize string wizard for web page

              • Critical - An upcoming version that is affected by this issue cannot be released until it's addressed. A critical bug is one that crashes the application, causes loss of data or severe memory leak.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                dmaliarevich Denis Maliarevich added a comment -

                Currently menu is inserted intoto the "menu:sourceMenuId?after=OccurencesFile" menu which is the standard WTP's Structured Text Editor Menu Id for "Source" menu.
                In "Package Explorer" another "Source" menu is created which is the standsrd Eclipse's menu.
                According to the <visible when> constructions TWO menus are visible.

                Show
                dmaliarevich Denis Maliarevich added a comment - Currently menu is inserted intoto the "menu:sourceMenuId?after=OccurencesFile" menu which is the standard WTP's Structured Text Editor Menu Id for "Source" menu. In "Package Explorer" another "Source" menu is created which is the standsrd Eclipse's menu. According to the <visible when> constructions TWO menus are visible.
                Hide
                Permalink
                dmaliarevich Denis Maliarevich added a comment -

                Now the command is enabled only from the Structured Text Editor's context.

                Show
                dmaliarevich Denis Maliarevich added a comment - Now the command is enabled only from the Structured Text Editor's context.
                Hide
                Permalink
                dmaliarevich Denis Maliarevich added a comment -

                SWTBot test was added.

                Show
                dmaliarevich Denis Maliarevich added a comment - SWTBot test was added.
                Hide
                Permalink
                dmaliarevich Denis Maliarevich added a comment -

                resolved

                Show
                dmaliarevich Denis Maliarevich added a comment - resolved
                Hide
                Permalink
                rawagner Rastislav Wagner added a comment -

                verified in JBDS 5.0.0.v201109021637R-H24-M3

                Show
                rawagner Rastislav Wagner added a comment - verified in JBDS 5.0.0.v201109021637R-H24-M3
                Hide
                Permalink
                dmaliarevich Denis Maliarevich added a comment -

                Summary: There are two source menus in Eclipse – the 1st from WTP when user edits the page, the 2nd from comes from "Package Explorer" when it has focus. These menus have different ids. Only one of them should be visible at a time. The probem was in logic for our source menu items visibility: items were shown in WTP's source menu while focus was in Package Explorer and thus another one source menu appeared.

                Show
                dmaliarevich Denis Maliarevich added a comment - Summary: There are two source menus in Eclipse – the 1st from WTP when user edits the page, the 2nd from comes from "Package Explorer" when it has focus. These menus have different ids. Only one of them should be visible at a time. The probem was in logic for our source menu items visibility: items were shown in WTP's source menu while focus was in Package Explorer and thus another one source menu appeared.
                Hide
                Permalink
                dmaliarevich Denis Maliarevich added a comment -

                Linking to previous similar issue

                Show
                dmaliarevich Denis Maliarevich added a comment - Linking to previous similar issue

                  People

                  • Assignee:
                    dmaliarevich Denis Maliarevich
                    Reporter:
                    vyemialyanchyk Vitali Yemialyanchyk
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Development