Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-9397

Split RichFaces feature into separate Common, JSF, VPE, ... features

        Details

        • Type: Bug
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: 3.3.0.M2
        • Fix Version/s: 3.3.0.M4
        • Component/s: jsf
        • Labels:
          None
        • Steps to Reproduce:
          Hide

          Components available as part of the RichFaces Tools feature are now available individually. Common, JST, JSF and VPE are all now available as individual components or as a RichFaces Tools bundle. For a user, if you only wish to use JSF Tools, you no longer need to also have Common, JST and VPE tooling components installed.

          Show
          Components available as part of the RichFaces Tools feature are now available individually. Common, JST, JSF and VPE are all now available as individual components or as a RichFaces Tools bundle. For a user, if you only wish to use JSF Tools, you no longer need to also have Common, JST and VPE tooling components installed.
        • Release Notes Docs Status:
          Not Required

          Description

          Right now, if you need JSF tools you have to install RichFaces feature that bundles a set of components: JST, JSF, VPE, ...
          It can confuse users.
          Here is the story that illustrates the possible problem:
          Jose Freitas (Seam 3 team) complained that code completion is not working for seam faces tags. It turned out that he installed CDI, Maven, AS, Hibernate tools but didn't install RichFaces feature. He just didn't realize that the RichFaces feature is much more than just RichFaces support. He didn't install it and as a result he didn't get JSF Tools. So JSF code completion didn't work for his project.

          It would be good to have a separate JSF Tools feature that requires only reasonable dependencies (such as Common, JST) and doesn't require VPE.

            Gliffy Diagrams

              Activity

              Ascending order - Click to sort in descending order
              9 older comments
              Hide
              Permalink
              nickboldt Nick Boldt added a comment -

              OK, we have a problem. By adding these extra features/dependencies, the resulting update site (trunk aggregate) can't be built because:

              [INFO] [Software being installed: org.jboss.tools.site.aggregate raw:0.0.1.'SNAPSHOT'/format(n[.n=0;[.n=0;[-S]]]):0.0.1-SNAPSHOT, 
              Only one of the following can be installed at once: [org.jboss.tools.common.validation 3.3.0.v20110915-1555-H434-M4, org.jboss.tools.common.validation 3.3.0.v20110915-2138-H435-M4, org.jboss.tools.common.validation 3.3.0.v20110829-0518-H428-M3, org.jboss.tools.common.validation 3.3.0.v20110914-2136-H433-M4, org.jboss.tools.common.validation 3.3.0.v20110915-2155-H436-M4], 
              Only one of the following can be installed at once: [org.jboss.tools.jst.jsp 3.3.0.v20110915-2213-H498-M4, org.jboss.tools.jst.jsp 3.3.0.v20110915-0440-H494-M4, org.jboss.tools.jst.jsp 3.3.0.v20110915-1645-H496-M4, org.jboss.tools.jst.jsp 3.3.0.v20110830-0158-H488-M3, org.jboss.tools.jst.jsp 3.3.0.v20110915-1954-H497-M4, org.jboss.tools.jst.jsp 3.3.0.v20110829-0543-H487-M3], 
              Cannot satisfy dependency: org.jboss.tools.common.feature.feature.group 3.3.0.v20110829-0518-H428-M3 depends on: org.jboss.tools.common.validation [3.3.0.v20110829-0518-H428-M3], 
              Cannot satisfy dependency: org.jboss.tools.common.feature.feature.group 3.3.0.v20110915-2138-H435-M4 depends on: org.jboss.tools.common.validation [3.3.0.v20110915-2138-H435-M4], 
              Cannot satisfy dependency: org.jboss.tools.common.feature.feature.group 3.3.0.v20110915-2155-H436-M4 depends on: org.jboss.tools.common.validation [3.3.0.v20110915-2155-H436-M4], 
              Cannot satisfy dependency: org.jboss.tools.jst.feature.feature.group 3.3.0.v20110830-0158-H488-M3 depends on: org.jboss.tools.jst.jsp [3.3.0.v20110830-0158-H488-M3], 
              Cannot satisfy dependency: org.jboss.tools.jst.feature.feature.group 3.3.0.v20110915-1954-H497-M4 depends on: org.jboss.tools.jst.jsp [3.3.0.v20110915-1954-H497-M4], 
              Cannot satisfy dependency: org.jboss.tools.jst.feature.feature.group 3.3.0.v20110915-2213-H498-M4 depends on: org.jboss.tools.jst.jsp [3.3.0.v20110915-2213-H498-M4], 
              Cannot satisfy dependency: org.jboss.tools.richfaces.feature.feature.group 3.3.0.v20110830-0201-H414-M3 depends on: org.jboss.tools.jst.jsp [3.3.0.v20110829-0543-H487-M3], 
              Cannot satisfy dependency: org.jboss.tools.richfaces.feature.feature.group 3.3.0.v20110915-1354-H420-M4 depends on: org.jboss.tools.jst.jsp [3.3.0.v20110915-0440-H494-M4], 
              Cannot satisfy dependency: org.jboss.tools.richfaces.feature.feature.group 3.3.0.v20110915-1947-H421-M4 depends on: org.jboss.tools.common.validation [3.3.0.v20110915-1555-H434-M4], 
              Cannot satisfy dependency: org.jboss.tools.site.aggregate raw:0.0.1.'SNAPSHOT'/format(n[.n=0;[.n=0;[-S]]]):0.0.1-SNAPSHOT depends on: org.jboss.tools.common.feature.feature.group 0.0.0, 
              Cannot satisfy dependency: org.jboss.tools.site.aggregate raw:0.0.1.'SNAPSHOT'/format(n[.n=0;[.n=0;[-S]]]):0.0.1-SNAPSHOT depends on: org.jboss.tools.jst.feature.feature.group 0.0.0, 
              Cannot satisfy dependency: org.jboss.tools.site.aggregate raw:0.0.1.'SNAPSHOT'/format(n[.n=0;[.n=0;[-S]]]):0.0.1-SNAPSHOT depends on: org.jboss.tools.richfaces.feature.feature.group 0.0.0]

              So, I need to ensure we have only singular deps on org.jboss.tools.jst.jsp and org.jboss.tools.common.validation. Seems like we have too many features which include these 2 plugins:

              org.jboss.tools.common.feature
              		 
              org.jboss.tools.jst.feature
              		 
              org.jboss.tools.richfaces.feature

              Show
              nickboldt Nick Boldt added a comment - OK, we have a problem. By adding these extra features/dependencies, the resulting update site (trunk aggregate) can't be built because: [INFO] [Software being installed: org.jboss.tools.site.aggregate raw:0.0.1.'SNAPSHOT'/format(n[.n=0;[.n=0;[-S]]]):0.0.1-SNAPSHOT, Only one of the following can be installed at once: [org.jboss.tools.common.validation 3.3.0.v20110915-1555-H434-M4, org.jboss.tools.common.validation 3.3.0.v20110915-2138-H435-M4, org.jboss.tools.common.validation 3.3.0.v20110829-0518-H428-M3, org.jboss.tools.common.validation 3.3.0.v20110914-2136-H433-M4, org.jboss.tools.common.validation 3.3.0.v20110915-2155-H436-M4], Only one of the following can be installed at once: [org.jboss.tools.jst.jsp 3.3.0.v20110915-2213-H498-M4, org.jboss.tools.jst.jsp 3.3.0.v20110915-0440-H494-M4, org.jboss.tools.jst.jsp 3.3.0.v20110915-1645-H496-M4, org.jboss.tools.jst.jsp 3.3.0.v20110830-0158-H488-M3, org.jboss.tools.jst.jsp 3.3.0.v20110915-1954-H497-M4, org.jboss.tools.jst.jsp 3.3.0.v20110829-0543-H487-M3], Cannot satisfy dependency: org.jboss.tools.common.feature.feature.group 3.3.0.v20110829-0518-H428-M3 depends on: org.jboss.tools.common.validation [3.3.0.v20110829-0518-H428-M3], Cannot satisfy dependency: org.jboss.tools.common.feature.feature.group 3.3.0.v20110915-2138-H435-M4 depends on: org.jboss.tools.common.validation [3.3.0.v20110915-2138-H435-M4], Cannot satisfy dependency: org.jboss.tools.common.feature.feature.group 3.3.0.v20110915-2155-H436-M4 depends on: org.jboss.tools.common.validation [3.3.0.v20110915-2155-H436-M4], Cannot satisfy dependency: org.jboss.tools.jst.feature.feature.group 3.3.0.v20110830-0158-H488-M3 depends on: org.jboss.tools.jst.jsp [3.3.0.v20110830-0158-H488-M3], Cannot satisfy dependency: org.jboss.tools.jst.feature.feature.group 3.3.0.v20110915-1954-H497-M4 depends on: org.jboss.tools.jst.jsp [3.3.0.v20110915-1954-H497-M4], Cannot satisfy dependency: org.jboss.tools.jst.feature.feature.group 3.3.0.v20110915-2213-H498-M4 depends on: org.jboss.tools.jst.jsp [3.3.0.v20110915-2213-H498-M4], Cannot satisfy dependency: org.jboss.tools.richfaces.feature.feature.group 3.3.0.v20110830-0201-H414-M3 depends on: org.jboss.tools.jst.jsp [3.3.0.v20110829-0543-H487-M3], Cannot satisfy dependency: org.jboss.tools.richfaces.feature.feature.group 3.3.0.v20110915-1354-H420-M4 depends on: org.jboss.tools.jst.jsp [3.3.0.v20110915-0440-H494-M4], Cannot satisfy dependency: org.jboss.tools.richfaces.feature.feature.group 3.3.0.v20110915-1947-H421-M4 depends on: org.jboss.tools.common.validation [3.3.0.v20110915-1555-H434-M4], Cannot satisfy dependency: org.jboss.tools.site.aggregate raw:0.0.1.'SNAPSHOT'/format(n[.n=0;[.n=0;[-S]]]):0.0.1-SNAPSHOT depends on: org.jboss.tools.common.feature.feature.group 0.0.0, Cannot satisfy dependency: org.jboss.tools.site.aggregate raw:0.0.1.'SNAPSHOT'/format(n[.n=0;[.n=0;[-S]]]):0.0.1-SNAPSHOT depends on: org.jboss.tools.jst.feature.feature.group 0.0.0, Cannot satisfy dependency: org.jboss.tools.site.aggregate raw:0.0.1.'SNAPSHOT'/format(n[.n=0;[.n=0;[-S]]]):0.0.1-SNAPSHOT depends on: org.jboss.tools.richfaces.feature.feature.group 0.0.0] So, I need to ensure we have only singular deps on org.jboss.tools.jst.jsp and org.jboss.tools.common.validation. Seems like we have too many features which include these 2 plugins: org.jboss.tools.common.feature org.jboss.tools.jst.feature org.jboss.tools.richfaces.feature
              Hide
              Permalink
              nickboldt Nick Boldt added a comment -

              richfaces.feature now includes nothing but upstream features...

              	<includes id="org.jboss.tools.common.feature" version="3.3.0" match="greaterOrEqual" />
              		 
              	<includes id="org.jboss.tools.common.core.feature" version="3.3.0" match="greaterOrEqual" />
              		 
              	<includes id="org.jboss.tools.common.text.ext.feature" version="3.3.0" match="greaterOrEqual" />
              		 
              	<includes id="org.jboss.tools.common.ui.feature" version="3.3.0" match="greaterOrEqual" />
              		 
              	<includes id="org.jboss.tools.common.verification.feature" version="3.3.0" match="greaterOrEqual" />
              		 
              	<includes id="org.jboss.tools.jsf.feature" version="3.3.0" match="greaterOrEqual" />
              		 
              	<includes id="org.jboss.tools.jst.feature" version="3.3.0" match="greaterOrEqual" />
              		 
              	<includes id="org.jboss.tools.vpe.feature" version="3.3.0" match="greaterOrEqual" />

              ... and requires the xulrunner.initializer plugin (also from upstream).

              Hopefully that removes the duplication and allows the agg site to build; this makes the RichFaces feature simply a wrapper for other features. A feature of convenience, as it were.

              http://hudson.qa.jboss.com/hudson/view/DevStudio/view/DevStudio_Trunk/job/jbosstools-3.3_trunk.aggregate/ (#3711 or later)
              http://hudson.qa.jboss.com/hudson/job/devstudio-5.0_trunk.updatesite/ (#1493 or later)
              http://hudson.qa.jboss.com/hudson/job/devstudio-5.0_trunk.product/ (#781 or later)

              Show
              nickboldt Nick Boldt added a comment - richfaces.feature now includes nothing but upstream features... <includes id="org.jboss.tools.common.feature" version="3.3.0" match="greaterOrEqual" /> <includes id="org.jboss.tools.common.core.feature" version="3.3.0" match="greaterOrEqual" /> <includes id="org.jboss.tools.common.text.ext.feature" version="3.3.0" match="greaterOrEqual" /> <includes id="org.jboss.tools.common.ui.feature" version="3.3.0" match="greaterOrEqual" /> <includes id="org.jboss.tools.common.verification.feature" version="3.3.0" match="greaterOrEqual" /> <includes id="org.jboss.tools.jsf.feature" version="3.3.0" match="greaterOrEqual" /> <includes id="org.jboss.tools.jst.feature" version="3.3.0" match="greaterOrEqual" /> <includes id="org.jboss.tools.vpe.feature" version="3.3.0" match="greaterOrEqual" /> ... and requires the xulrunner.initializer plugin (also from upstream). Hopefully that removes the duplication and allows the agg site to build; this makes the RichFaces feature simply a wrapper for other features. A feature of convenience, as it were. http://hudson.qa.jboss.com/hudson/view/DevStudio/view/DevStudio_Trunk/job/jbosstools-3.3_trunk.aggregate/ (#3711 or later) http://hudson.qa.jboss.com/hudson/job/devstudio-5.0_trunk.updatesite/ (#1493 or later) http://hudson.qa.jboss.com/hudson/job/devstudio-5.0_trunk.product/ (#781 or later)
              Hide
              Permalink
              nickboldt Nick Boldt added a comment -

              Updated JBDS 5.0.0.M3 from 09/09 to M4 from 09/17 using http://www.qa.jboss.com/binaries/RHDS/builds/staging/devstudio-5.0_trunk.product/updates/nightly/trunk/ successfully. New features not previously installed were added.

              Show
              nickboldt Nick Boldt added a comment - Updated JBDS 5.0.0.M3 from 09/09 to M4 from 09/17 using http://www.qa.jboss.com/binaries/RHDS/builds/staging/devstudio-5.0_trunk.product/updates/nightly/trunk/ successfully. New features not previously installed were added.
              Hide
              Permalink
              irooskov Isaac Rooskov added a comment -

              This issue has been found to not be required for inclusion in the release notes of JBDS 5 as it only relates to the community verison, JBT 3.3.0.

              Show
              irooskov Isaac Rooskov added a comment - This issue has been found to not be required for inclusion in the release notes of JBDS 5 as it only relates to the community verison, JBT 3.3.0.
              Hide
              Permalink
              vpakan Vlado Pakan added a comment -

              Verified with JBT 3.3.0.v20120403-0225-H4468-Beta3.

              Show
              vpakan Vlado Pakan added a comment - Verified with JBT 3.3.0.v20120403-0225-H4468-Beta3.

                People

                • Assignee:
                  nickboldt Nick Boldt
                  Reporter:
                  akazakov Alexey Kazakov
                  Writer:
                  Isaac Rooskov
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development