Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-9323

Possibility to contribute on vpe toolbar in eclipse

    Details

      Description

      VPE icons have some logic behind them(disabled when visual part not visible). We need possibility to contribute on this toolbar. For now this is inpossible. Because refresh icon function has hardcoded commands'id. Better to refresh all commands on some org.jboss.tools.vpe.category. That allows contribute to vpe-toolbar.

        Gliffy Diagrams

        1. JBIDE-9323.diff
          4 kB
          Maxim Areshkau
        2. JBIDE-9323-new.patch
          4 kB
          Maxim Areshkau
        3. JBIDE-9323-new-2.patch
          12 kB
          Maxim Areshkau
        4. JBIDE-9323-new-2.patch
          12 kB
          Maxim Areshkau
        5. JBIDE-9323-new-2.patch
          12 kB
          Maxim Areshkau

          Activity

          Hide
          mareshkau Maxim Areshkau added a comment -

          New version of patch with comments, old code has been removed.

          Show
          mareshkau Maxim Areshkau added a comment - New version of patch with comments, old code has been removed.
          Hide
          yradtsevich Yahor Radtsevich added a comment -

          Resolved

          I have applied a little bit changed patch to trunk.

          Maxim, next time please also try to build and run VPE tests before sending patch, since it was caused a compile error in there.

          Show
          yradtsevich Yahor Radtsevich added a comment - Resolved I have applied a little bit changed patch to trunk. Maxim, next time please also try to build and run VPE tests before sending patch, since it was caused a compile error in there.
          Hide
          vpakan Vlado Pakan added a comment -

          Maxim please could you verify and close this Jira or provide steps how to verify it?

          Show
          vpakan Vlado Pakan added a comment - Maxim please could you verify and close this Jira or provide steps how to verify it?
          Hide
          vpakan Vlado Pakan added a comment -

          Read my previous comment.

          Show
          vpakan Vlado Pakan added a comment - Read my previous comment.
          Hide
          mareshkau Maxim Areshkau added a comment -

          Maxim please could you verify and close this Jira or provide steps how to verify it?

          So I have verified and closed the issue as you wrote in 1-st part of your comment. It hard to verify with java coding.

          Show
          mareshkau Maxim Areshkau added a comment - Maxim please could you verify and close this Jira or provide steps how to verify it? So I have verified and closed the issue as you wrote in 1-st part of your comment. It hard to verify with java coding.

            People

            • Assignee:
              yradtsevich Yahor Radtsevich
              Reporter:
              mareshkau Maxim Areshkau
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development