Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-9243

local servers are not trying to start because it already looks like they are started

    Details

    • Steps to Reproduce:
      Hide

      1) start an as7 server
      2) start a 2nd as7 server (that would listen on the same port)

      Result:
      The adapter of the 2nd server erroneously states "Started" but actually no server was started
      Symptom is that you have no log output of that 2nd server.

      Show
      1) start an as7 server 2) start a 2nd as7 server (that would listen on the same port) Result: The adapter of the 2nd server erroneously states "Started" but actually no server was started Symptom is that you have no log output of that 2nd server.
    • Release Notes Docs Status:
      Not Required

      Description

      originally:

      "After I updated to latest M2 build I no longer get console output nor launches - I for sure got that earlier today so something changed.

      Without console output and way of debugging you are rather lost so this is definitely considered a blocker."

      After some investigation what actually happend was that I had something running on port 8080 already and then the server didn't even try and start anything and just worked like it was already running...

      That's different what it used to be that the server would actually start and then most likely start with address already in use; it looked bad but at least the user could see what is going on.

      The current behavior is worse since the user think he is already running..but turns out he is not.

      But it is cool the poller now is asked if it is already started and we should use that information to show a dialog to the user asking him something like:

      "A server already seem to be responding via <some text for the poller to describe what it detected>. Do you wish to continue starting the server, connect to existing server or cancel ?"

      Then clicking continue will actually do the start, cancel will stop the attempt to start and the server adapter should not be connected and finally connecting to existing server should temporarily for the time of this specific launch switch to "do not start/stop server" mode.

      Then the user would be in control and know what is going on!

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            rob.stryker Rob Stryker added a comment -

            I am not hopeful for this to make 3.3.0 at all, but, for now I am targeting to RC1 just in case. THe launching code is currently being unified by Andre and so adding something such as this is not feasible until his unification is complete.

            Show
            rob.stryker Rob Stryker added a comment - I am not hopeful for this to make 3.3.0 at all, but, for now I am targeting to RC1 just in case. THe launching code is currently being unified by Andre and so adding something such as this is not feasible until his unification is complete.
            Hide
            rob.stryker Rob Stryker added a comment -

            Screenshot of implementation

            Show
            rob.stryker Rob Stryker added a comment - Screenshot of implementation
            Hide
            rob.stryker Rob Stryker added a comment -

            Implemented as in the screenshot attached =] Text can be changed if it's deemed that it's necessary.

            Show
            rob.stryker Rob Stryker added a comment - Implemented as in the screenshot attached =] Text can be changed if it's deemed that it's necessary.
            Hide
            maxandersen Max Rydahl Andersen added a comment -

            reopening since this does not seem to work.

            Creates one AS 7 server, start it, verify that it runs.
            Copy AS 7 server adapter, start it, expect warning dialog comes up.

            For me both servers start - without warning

            Show
            maxandersen Max Rydahl Andersen added a comment - reopening since this does not seem to work. Creates one AS 7 server, start it, verify that it runs. Copy AS 7 server adapter, start it, expect warning dialog comes up. For me both servers start - without warning
            Hide
            rob.stryker Rob Stryker added a comment -

            I am not able to replicate this. Just tried, and the 2nd attempt to start a 7.0 brings up the dialog. Whether I start the first one from cmd line or from within eclipse, the second attempt always brings up the dialog for me.

            Are you still able to replicate this?

            Show
            rob.stryker Rob Stryker added a comment - I am not able to replicate this. Just tried, and the 2nd attempt to start a 7.0 brings up the dialog. Whether I start the first one from cmd line or from within eclipse, the second attempt always brings up the dialog for me. Are you still able to replicate this?
            Hide
            maxandersen Max Rydahl Andersen added a comment -

            using latest nightly build : 2.3.0.v20110722-1357-H562-M3

            I still see this.

            Show
            maxandersen Max Rydahl Andersen added a comment - using latest nightly build : 2.3.0.v20110722-1357-H562-M3 I still see this.
            Hide
            rob.stryker Rob Stryker added a comment -

            Assigning to you to really double check.

            Maybe we should have QE give it a try, too?

            Show
            rob.stryker Rob Stryker added a comment - Assigning to you to really double check. Maybe we should have QE give it a try, too?
            Hide
            maxandersen Max Rydahl Andersen added a comment -

            Jiri - can you or someone from you team take a look ?

            Show
            maxandersen Max Rydahl Andersen added a comment - Jiri - can you or someone from you team take a look ?
            Hide
            maxandersen Max Rydahl Andersen added a comment -

            here is one of my failed attempts
            http://screencast.com/t/veVkwUzN3Dh

            Show
            maxandersen Max Rydahl Andersen added a comment - here is one of my failed attempts http://screencast.com/t/veVkwUzN3Dh
            Hide
            mmalina Martin Malina added a comment -

            I just tried Max' scenario and it worked as suggested by Rob - a dialog appeared offering two options.
            See here: http://screencast.com/t/y9jMxfVQ

            Show
            mmalina Martin Malina added a comment - I just tried Max' scenario and it worked as suggested by Rob - a dialog appeared offering two options. See here: http://screencast.com/t/y9jMxfVQ
            Hide
            mmalina Martin Malina added a comment -

            I used a slightly newer build than Max:

            jbosstools-3.3_trunk.aggregate-Update-2011-08-17_04-18-17-H3519.zip

            JBossAS Tools
            Version: 2.3.0.v20110816-2052-H641-M3

            You may try that, Max, or else I don't know

            Show
            mmalina Martin Malina added a comment - I used a slightly newer build than Max: jbosstools-3.3_trunk.aggregate-Update-2011-08-17_04-18-17-H3519.zip JBossAS Tools Version: 2.3.0.v20110816-2052-H641-M3 You may try that, Max, or else I don't know
            Hide
            ldimaggio Len DiMaggio added a comment -

            I was unable to recreate the error with this build:
            Version: 2.3.0.v20110817-1456-H644-M3

            When I try to start the 2nd server, I see the dialog that is included in this JIRA as a screen shot.

            Max?

            Show
            ldimaggio Len DiMaggio added a comment - I was unable to recreate the error with this build: Version: 2.3.0.v20110817-1456-H644-M3 When I try to start the 2nd server, I see the dialog that is included in this JIRA as a screen shot. Max?
            Hide
            mmalina Martin Malina added a comment -

            I just updated my JBT to the latest nightly and have this version of JBossAS Tools:
            Version: 2.3.0.v20110829-0855-H677-M3

            Now I'm getting Max's failure again - when I start the second server, it doesn't ask for anything and fails on "ports used".

            Show
            mmalina Martin Malina added a comment - I just updated my JBT to the latest nightly and have this version of JBossAS Tools: Version: 2.3.0.v20110829-0855-H677-M3 Now I'm getting Max's failure again - when I start the second server, it doesn't ask for anything and fails on "ports used".
            Hide
            mmalina Martin Malina added a comment -

            I will try again on Wed with the M3 build.

            Show
            mmalina Martin Malina added a comment - I will try again on Wed with the M3 build.
            Hide
            maxandersen Max Rydahl Andersen added a comment -

            Moving past M3 - martin, got any update?

            Show
            maxandersen Max Rydahl Andersen added a comment - Moving past M3 - martin, got any update?
            Hide
            mmalina Martin Malina added a comment -

            I just checked this on a fresh install of build #24 - M3 candidate. And it works fine. I will ask somebody else to double check.

            Show
            mmalina Martin Malina added a comment - I just checked this on a fresh install of build #24 - M3 candidate. And it works fine. I will ask somebody else to double check.
            Hide
            lzoubek Libor Zoubek added a comment - - edited

            I can confirm sam behaviour as martin. However, I've tried starting 2nd server while the 1st one is in 'Starting' state (you have to be really quick, AS7 startup is very fast). I got both servers started from the tooling point of view, log contained 2nd server startup with errors. I was not able to stop 2nd server - it still says 'Stopping' until big timeout is reached (5mins or so). I know this is an edge or maybe nonsense case, but 'stopping' issue should get fixed.

            Show
            lzoubek Libor Zoubek added a comment - - edited I can confirm sam behaviour as martin. However, I've tried starting 2nd server while the 1st one is in 'Starting' state (you have to be really quick, AS7 startup is very fast). I got both servers started from the tooling point of view, log contained 2nd server startup with errors. I was not able to stop 2nd server - it still says 'Stopping' until big timeout is reached (5mins or so). I know this is an edge or maybe nonsense case, but 'stopping' issue should get fixed.
            Hide
            mmalina Martin Malina added a comment -

            Assigning back to Rob for him to comment.

            Show
            mmalina Martin Malina added a comment - Assigning back to Rob for him to comment.
            Hide
            rob.stryker Rob Stryker added a comment -

            I'm marking this as complete. I recognize Libor's edge case, however, a failproof way to stop the second server is to check the "Console" view and terminate the process.

            I really think that's about all we can do here.

            Show
            rob.stryker Rob Stryker added a comment - I'm marking this as complete. I recognize Libor's edge case, however, a failproof way to stop the second server is to check the "Console" view and terminate the process. I really think that's about all we can do here.
            Hide
            rob.stryker Rob Stryker added a comment -

            I've made some small change for m4. Case is as follows:
            1) Start as7 server
            2) wait until as7 is up. Then start 2nd as7 server
            3) use dialog to mark "do not launch; just set to started".
            4) wait for as7 server2 up, then stop as7 server 2
            5) stuck in stopping mode

            I made a change to the process terminated poller. It was stuck here because the process terminated poller does nothing and assumes that a process terminating will change the server state. The server doesn't change it because it is not set to always not launch, just set to do that THIS time, and did not remember that the most recent start did not launch a new process. So now process terminated poller will at least check if the server has a process and if it is terminated.

            This does not affect Libor's fast-startup usecase, which still fails, however the 'terminate process' button still fixes that. As of now that's the only answer I have to Libor's use case.

            The usecase I just mentioned is fixed for m4, Libor's use case is not addressed, but the original issue here has been fixed for m3.

            Show
            rob.stryker Rob Stryker added a comment - I've made some small change for m4. Case is as follows: 1) Start as7 server 2) wait until as7 is up. Then start 2nd as7 server 3) use dialog to mark "do not launch; just set to started". 4) wait for as7 server2 up, then stop as7 server 2 5) stuck in stopping mode I made a change to the process terminated poller. It was stuck here because the process terminated poller does nothing and assumes that a process terminating will change the server state. The server doesn't change it because it is not set to always not launch, just set to do that THIS time, and did not remember that the most recent start did not launch a new process. So now process terminated poller will at least check if the server has a process and if it is terminated. This does not affect Libor's fast-startup usecase, which still fails, however the 'terminate process' button still fixes that. As of now that's the only answer I have to Libor's use case. The usecase I just mentioned is fixed for m4, Libor's use case is not addressed, but the original issue here has been fixed for m3.
            Hide
            ldimaggio Len DiMaggio added a comment -

            I am unable to recreate the original issue, or the latest use case that Rob listed with the M3a build:

            jbosstools-3.3_stable_branch.aggregate-Update-2011-09-07_05-39-13-H18.zip

            Rob - are you saying that the 'stuck in stopping mode' issue SHOULD be seen in M3a?

            Show
            ldimaggio Len DiMaggio added a comment - I am unable to recreate the original issue, or the latest use case that Rob listed with the M3a build: jbosstools-3.3_stable_branch.aggregate-Update-2011-09-07_05-39-13-H18.zip Rob - are you saying that the 'stuck in stopping mode' issue SHOULD be seen in M3a?
            Hide
            ldimaggio Len DiMaggio added a comment -

            Verified fixed in: jbosstools-3.3_stable_branch.aggregate-Update-2011-09-07_05-39-13-H18.zip

            A new JIRA will be opened for the related edge case.

            Show
            ldimaggio Len DiMaggio added a comment - Verified fixed in: jbosstools-3.3_stable_branch.aggregate-Update-2011-09-07_05-39-13-H18.zip A new JIRA will be opened for the related edge case.
            Hide
            irooskov Isaac Rooskov added a comment -

            reopening to set release note information

            Show
            irooskov Isaac Rooskov added a comment - reopening to set release note information
            Hide
            irooskov Isaac Rooskov added a comment -

            This issue was never seen by a customer so it does not require a release note.

            Show
            irooskov Isaac Rooskov added a comment - This issue was never seen by a customer so it does not require a release note.
            Hide
            rob.stryker Rob Stryker added a comment -

            As per isaac, does not require a release note

            Show
            rob.stryker Rob Stryker added a comment - As per isaac, does not require a release note
            Hide
            mmalina Martin Malina added a comment -

            Closing again.

            Show
            mmalina Martin Malina added a comment - Closing again.

              People

              • Assignee:
                rob.stryker Rob Stryker
                Reporter:
                maxandersen Max Rydahl Andersen
                Writer:
                Isaac Rooskov
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development