Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-9100

Improve sepration of concerns when creating .dodeploy markers in JBoss7ServerBehavior and JBoss7JSTPublisher

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Minor Minor
    • 3.3.0.M2
    • 3.3.0.M1
    • server
    • None

      When deploying to AS7 there are 2 components involved:

      • JBoss7JSTPublisher: adds markers that shall be created to the JBoss7ServerBehavior (see #markDeployed)
      • JBoss7ServerBehavior: creates the .dodeploy markers (see #publishFinish)

      IMHO what is not ideal here is that the list of markers that shall be created is passed around in form of an object (the publisher adds a list as a java.lang.Object and the server behavior then gets the java.lang.Object and then cast it to a List.
      If you would want to change the form that shall hold the marker you'd have to figure out and change both components. Both components have to know about the form, which is not ideal in terms of separation of concerns.

            rob.stryker Rob Stryker (Inactive)
            adietish@redhat.com André Dietisheim
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: