Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-8972

"Copy dependencies into project" on any Classpath container

    Details

    • Release Notes Docs Status:
      Not Required

      Gliffy Diagrams

        Activity

        Hide
        maxandersen Max Rydahl Andersen added a comment -

        I thnk this was meant for Fred?

        Show
        maxandersen Max Rydahl Andersen added a comment - I thnk this was meant for Fred?
        Hide
        fbricon Fred Bricon added a comment -

        In my understanding, we need to add a context menu when a classpath menu is selected,
        Open a dialog menu, display all the jars from that classpath in a checkbox viewer for user selection (all of them being selected by default)
        There must be a input text where a user can select the destination.
        On ok :

        • copy dependencies.
        • add the copied dependencies to the project classpath

        And then what should we do about the classpath container, keep it? I believe we can't just remove it (the maven one would be reinstalled automatically later)

        Anything I miss?

        Show
        fbricon Fred Bricon added a comment - In my understanding, we need to add a context menu when a classpath menu is selected, Open a dialog menu, display all the jars from that classpath in a checkbox viewer for user selection (all of them being selected by default) There must be a input text where a user can select the destination. On ok : copy dependencies. add the copied dependencies to the project classpath And then what should we do about the classpath container, keep it? I believe we can't just remove it (the maven one would be reinstalled automatically later) Anything I miss?
        Hide
        maxandersen Max Rydahl Andersen added a comment -

        The container should be removed since otherwise there would be duplicates.

        btw. on copy/add keeping the sequence of jars within the container and in context of the other dependencies will be important to avoid suprised shadowing effects.

        Show
        maxandersen Max Rydahl Andersen added a comment - The container should be removed since otherwise there would be duplicates. btw. on copy/add keeping the sequence of jars within the container and in context of the other dependencies will be important to avoid suprised shadowing effects.
        Hide
        fbricon Fred Bricon added a comment -

        What should happen when the user selects the EAR or Webapp libraries?
        It doesn't make sense for an EJB project to dump all jars found in EARContent/lib (or elsewhere) to ejbproject/lib.
        And for (non-maven) web projects the webapp library already points to contains jars in WEB-INF/lib

        Show
        fbricon Fred Bricon added a comment - What should happen when the user selects the EAR or Webapp libraries? It doesn't make sense for an EJB project to dump all jars found in EARContent/lib (or elsewhere) to ejbproject/lib. And for (non-maven) web projects the webapp library already points to contains jars in WEB-INF/lib
        Hide
        maxandersen Max Rydahl Andersen added a comment -

        if the jars are already inside the project I guess they should just get added as normal jars ?

        Show
        maxandersen Max Rydahl Andersen added a comment - if the jars are already inside the project I guess they should just get added as normal jars ?
        Hide
        fbricon Fred Bricon added a comment -

        added initial commit.

        missing so far :

        • add a browse button to select destination directory
        • several sanity checks
        • maybe decorate cells in error
        • run sanity check while typing
        • ...

        I'm not really satisfied with the 2 columns so far. I tried to display the complete path of the source column but it was too ugly.
        If anyone has great ideas for the UI, let me know.

        Show
        fbricon Fred Bricon added a comment - added initial commit. missing so far : add a browse button to select destination directory several sanity checks maybe decorate cells in error run sanity check while typing ... I'm not really satisfied with the 2 columns so far. I tried to display the complete path of the source column but it was too ugly. If anyone has great ideas for the UI, let me know.
        Hide
        fbricon Fred Bricon added a comment -

        Complete source path displayed if a user clicks on the source column.

        Show
        fbricon Fred Bricon added a comment - Complete source path displayed if a user clicks on the source column.
        Hide
        maxandersen Max Rydahl Andersen added a comment -

        If just need to show full path it could be in tooltip.

        if need to copy the path, provide more details etc. you could have "Details" panel below showing details about the selected line.

        Show
        maxandersen Max Rydahl Andersen added a comment - If just need to show full path it could be in tooltip. if need to copy the path, provide more details etc. you could have "Details" panel below showing details about the selected line.
        Hide
        fbricon Fred Bricon added a comment -

        Marking as resolved for M4 as the feature is complete. cosmetic fixes such as tooltips, detail panel can be added in Beta

        Show
        fbricon Fred Bricon added a comment - Marking as resolved for M4 as the feature is complete. cosmetic fixes such as tooltips, detail panel can be added in Beta
        Hide
        rawagner Rastislav Wagner added a comment -

        verified.

        Show
        rawagner Rastislav Wagner added a comment - verified.
        Hide
        irooskov Isaac Rooskov added a comment -

        Reopening to write release note text

        Show
        irooskov Isaac Rooskov added a comment - Reopening to write release note text
        Hide
        irooskov Isaac Rooskov added a comment -

        Since Maven has not been a component of JBDS before, this feature does not need to be noted.

        Show
        irooskov Isaac Rooskov added a comment - Since Maven has not been a component of JBDS before, this feature does not need to be noted.
        Hide
        irooskov Isaac Rooskov added a comment -

        Re-closing now release note status has been set

        Show
        irooskov Isaac Rooskov added a comment - Re-closing now release note status has been set

          People

          • Assignee:
            fbricon Fred Bricon
            Reporter:
            maxandersen Max Rydahl Andersen
            Writer:
            Isaac Rooskov
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development