Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-8801

Seam Facet Install Delegate should not copy resources and libraries from Seam Runtime in case of installing it to an existing project.

        Details

        • Type: Bug
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: 3.3.0.M1
        • Fix Version/s: 3.3.0.M2
        • Component/s: seam2
        • Labels:
          None

          Gliffy Diagrams

          1. Text File
            JBIDE-8801_new.patch
            22 kB
            Daniel Azarov
          2. Text File
            JBIDE-8801.patch
            29 kB
            Daniel Azarov

            Issue Links

            relates to

            Feature Request - A new feature of the product, which has yet to be developed. JBIDE-2927 There should be an option to/not to copy the libraries when user create New Seam Project.

            • Major - A request that should be considered seriously but is not a show stopper.
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              akazakov Alexey Kazakov added a comment -

              It means that the delegate should not copy resources in case of installing it to an existing project. But if Seam Facet Install Delegate was invoked by New Project wizard then it should copy all required resources as before.

              Show
              akazakov Alexey Kazakov added a comment - It means that the delegate should not copy resources in case of installing it to an existing project. But if Seam Facet Install Delegate was invoked by New Project wizard then it should copy all required resources as before.
              Hide
              Permalink
              dazarov Daniel Azarov added a comment -

              Max, I've done this issue. Can I commit it?

              Show
              dazarov Daniel Azarov added a comment - Max, I've done this issue. Can I commit it?
              Hide
              Permalink
              maxandersen Max Rydahl Andersen added a comment -

              looking at patch.

              Shouldn't:
              if(!isNewProjectWizard())
              + model.setBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING, false);

              just be replaced with:
              model.setBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING, !isNewProjectWizard());

              ?

              Shouldn't all instances of model.getBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING) be refactored into
              a method call aka shouldCopySeamRuntimeLibraries() or similar ?

              isNewProjectWizard does not seem to consider the case where the facet delegate is run from the dynamic web project? Should it ? or is that considered a case where it shouldn't copy libraries too ?

              Show
              maxandersen Max Rydahl Andersen added a comment - looking at patch. Shouldn't: if(!isNewProjectWizard()) + model.setBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING, false); just be replaced with: model.setBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING, !isNewProjectWizard()); ? Shouldn't all instances of model.getBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING) be refactored into a method call aka shouldCopySeamRuntimeLibraries() or similar ? isNewProjectWizard does not seem to consider the case where the facet delegate is run from the dynamic web project? Should it ? or is that considered a case where it shouldn't copy libraries too ?
              Hide
              Permalink
              maxandersen Max Rydahl Andersen added a comment -

              back to you.

              Show
              maxandersen Max Rydahl Andersen added a comment - back to you.
              Hide
              Permalink
              dazarov Daniel Azarov added a comment - - edited

              >Shouldn't:
              >if(!isNewProjectWizard())
              >+ model.setBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING, false);

              >just be replaced with:
              >model.setBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING, !isNewProjectWizard());

              >?

              >Shouldn't all instances of model.getBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING) be refactored into
              >a method call aka shouldCopySeamRuntimeLibraries() or similar ?

              agree

              >isNewProjectWizard does not seem to consider the case where the facet delegate is run from the dynamic web project? Should it ? or is that considered a case where it
              >shouldn't copy libraries too ?

              if we have "true" as default value of SEAM_RUNTIME_LIBRARIES_COPYING property and set it to "false" only in case of adding Seam Facet to existing project.
              it should work

              Show
              dazarov Daniel Azarov added a comment - - edited >Shouldn't: >if(!isNewProjectWizard()) >+ model.setBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING, false); >just be replaced with: >model.setBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING, !isNewProjectWizard()); >? >Shouldn't all instances of model.getBooleanProperty(ISeamFacetDataModelProperties.SEAM_RUNTIME_LIBRARIES_COPYING) be refactored into >a method call aka shouldCopySeamRuntimeLibraries() or similar ? agree >isNewProjectWizard does not seem to consider the case where the facet delegate is run from the dynamic web project? Should it ? or is that considered a case where it >shouldn't copy libraries too ? if we have "true" as default value of SEAM_RUNTIME_LIBRARIES_COPYING property and set it to "false" only in case of adding Seam Facet to existing project. it should work
              Hide
              Permalink
              snjeza Snjezana Peco added a comment -

              The New Seam Web EAR project wizard doesn't work. ejb/ear/test projects aren't created. That is why Maven tests fail.
              The default value for SEAM_RUNTIME_LIBRARIES_COPYING isn't defined correctly.

              Show
              snjeza Snjezana Peco added a comment - The New Seam Web EAR project wizard doesn't work. ejb/ear/test projects aren't created. That is why Maven tests fail. The default value for SEAM_RUNTIME_LIBRARIES_COPYING isn't defined correctly.
              Hide
              Permalink
              maxandersen Max Rydahl Andersen added a comment -

              reopening based on snejzanas comments

              Show
              maxandersen Max Rydahl Andersen added a comment - reopening based on snejzanas comments
              Hide
              Permalink
              dazarov Daniel Azarov added a comment -

              It was my fault.
              Thank you, Snjezana
              I verified this issue - now all works fine

              Show
              dazarov Daniel Azarov added a comment - It was my fault. Thank you, Snjezana I verified this issue - now all works fine
              Hide
              Permalink
              vpakan Vlado Pakan added a comment -

              Verified on jbdevstudio-product-linux-gtk-5.0.0.v201106241117R-H14-M2.

              Show
              vpakan Vlado Pakan added a comment - Verified on jbdevstudio-product-linux-gtk-5.0.0.v201106241117R-H14-M2.

                People

                • Assignee:
                  dazarov Daniel Azarov
                  Reporter:
                  dazarov Daniel Azarov
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development