Details
-
Type:
Feature Request
-
Status: Resolved (View Workflow)
-
Priority:
Major
-
Resolution: Rejected
-
Affects Version/s: 3.2.0.Final
-
Fix Version/s: 3.2.2.Final
-
Component/s: upstream
-
Labels:None
-
Release Notes Text:To get JBoss AS adapters, install the "JBossAS Tools" feature from http://download.jboss.org/jbosstools/updates/stable/helios/
Description
It seems what happens is you must make use of the org.eclipse.wst.server.discovery plugin. This plugin has a file (discovery.xml) which has "sites", and those sites (such as http://public.dhe.ibm.com/software/websphere/wasce/updates/) seem to be an eclipse update site.
The entry point for this wizard is in the New Runtime wizard. At the top is a hyperlink that reads "Download other adapters" (or something similar). It then queries these sites, and allows you to select one of those available.
It seems the objects are then downloaded as IInstallableUnit's, which is in the org.eclipse.equinox.p2.metadata package.
I kinda lose track of it here, but, I suspect that after this it is downloaded as an actual eclipse bundle and added into the eclipse installation. But I guess I could trace through further
Changes to our site would require adding the category and adding it to certain features in our site.xml.
Gliffy Diagrams
-
Hide
- discoverPlugin.zip
- 108 kB
- Rob Stryker
-
- org.eclipse.wst.server.discovery/.classpath 0.4 kB
- org.eclipse.wst.server.discovery/.cvsignore 0.1 kB
- org.eclipse.wst.server.discovery/.options 0.1 kB
- org.eclipse.wst.server.discovery/.project 0.8 kB
- org.eclipse.wst.server.discovery/.../org.eclipse.jdt.core.prefs 0.3 kB
- org.eclipse.wst.server.discovery/.../org.eclipse.jdt.ui.prefs 0.2 kB
- org.eclipse.wst.server.discovery/.../MANIFEST.MF 1 kB
- org.eclipse.wst.server.discovery/.../bundle.properties 0.6 kB
- org.eclipse.wst.server.discovery/about.html 1 kB
- org.eclipse.wst.server.discovery/.../Discovery.class 0.9 kB
- org.eclipse.wst.server.discovery/.../ExtensionWizard$1.class 0.9 kB
- org.eclipse.wst.server.discovery/.../ExtensionWizard$2.class 2 kB
- org.eclipse.wst.server.discovery/.../ExtensionWizard$3.class 1 kB
- org.eclipse.wst.server.discovery/.../ExtensionWizard.class 5 kB
- org.eclipse.wst.server.discovery/.../Activator.class 1.0 kB
- org.eclipse.wst.server.discovery/.../ExtensionInstallableUnitQuery.class 1 kB
- org.eclipse.wst.server.discovery/.../ExtensionUtility$1.class 3 kB
- org.eclipse.wst.server.discovery/.../ExtensionUtility$ExtensionListener.class 0.4 kB
- org.eclipse.wst.server.discovery/.../ExtensionUtility.class 12 kB
- org.eclipse.wst.server.discovery/.../IMemento.class 0.8 kB
- org.eclipse.wst.server.discovery/.../ImageResource.class 4 kB
- org.eclipse.wst.server.discovery/.../Messages.class 0.8 kB
- org.eclipse.wst.server.discovery/.../Messages.properties 1 kB
- org.eclipse.wst.server.discovery/.../PatternInstallableUnitQuery.class 1 kB
- org.eclipse.wst.server.discovery/.../ProgressUtil.class 1 kB
- org.eclipse.wst.server.discovery/.../Trace.class 3 kB
- org.eclipse.wst.server.discovery/.../XMLMemento.class 9 kB
- org.eclipse.wst.server.discovery/.../Extension.class 6 kB
- org.eclipse.wst.server.discovery/.../ExtensionUpdateSite.class 6 kB
- org.eclipse.wst.server.discovery/.../BaseLabelProvider$1.class 1 kB
-
- JBIDE-8460.jpg
- 117 kB
Issue Links
- cloned to
-
JBIDE-9851
Get JBossTools added to wtp 3.3's list of server adapters :: Indigo
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
OK, so I need to add something like this:
<site>
<category-def
name="org.eclipse.wst.server.core.serverAdapter"
label="JOnAS Server Adapters"/>
<feature
url="features/org.myadapter.feature_1.0.0.jar"
id="org.myadapter.feature" version="1.0.0">
<category name="org.eclipse.wst.server.core.serverAdapter"/>
</feature>
into http://download.jboss.org/jbosstools/updates/JBossTools-3.2.0.GA/site.xml
Please tell me:
1. what label to use (it will appear in the list of categories when installing JBT) and,
2. which feature(s) are to be updated w/ this new category.
Also, does this have to be done for JBoss Dev Studio update site too? Or is this just for JBoss Tools?
Nag. Did you want this for 3.2.1 and 3.3.0? or just 3.3.0?
just 3.3.0... pointless unless our url is added upstream. Which I still haven't done because we never got an update site done. Um... Basically we give THEM an update site and they use it. So it's an update site url that is included in eclipse, NOT one our users will go to.
I need to know what URL will be available and then force wtp to squeeze it in. I guess we can try to make the update site work after that... but I really need to force them to do it.
Features will be all of the astools features and JMX and Archvies I guess
Assuming we can change the URL annually, then:
http://download.jboss.org/jbosstools/updates/webtools/helios/ (for WTP 3.2.5)
http://download.jboss.org/jbosstools/updates/webtools/indigo/ (for WTP 3.3)
If we can't, or our stuff will be compatible between releases, then the simpler variant would work too:
2 months later. Is this done?
On 08/02/2011 04:52 AM, Rob Stryker wrote:
> There's nothing there. I realize it's my fault. I never got back to you.
> So I'll ask... what do I need to ensure this is done? The Indigo was
> released and it does reference this URL, so that's good. The next step
> is to actually put something there ![]()
>
> Do we want to put our milestone builds there? Or should we just wait for
> 3.3 to be released before putting something there? Any thoughts? What's
> easiest on your end?
I can make this build as part of every nightly, and we can choose to update it with every milestone (as we do for http://download.jboss.org/jbosstools/updates/development/indigo/)
> What needs to be in it? Well, god... probably all of JMX, all of
> Archives, and all of AS.
Please give me a detailed list of features (and/or plugins) you want exposed on that update site. Is it all of these?
org.jboss.tools.jmx.feature
|
org.jboss.ide.eclipse.archives.feature
|
org.jboss.ide.eclipse.as.archives.integration.feature
|
org.jboss.ide.eclipse.as.serverAdapter.wtp.feature
|
org.jboss.ide.eclipse.as.feature
|
org.jboss.ide.eclipse.as.server.rse.integration.feature
|
org.jboss.ide.eclipse.as.jmx.integration.feature
|
Thanks Nick!
I think that's the full list, but I'll need to see an example from M2 or a nightly before I can verify for sure. Let's give it a go! =]
Two things I've noticed:
a) that list of features is nearly identical to the list in the AS component's update site [1] (give or take the tests feature).
b) this was hella easy to put together. Can now build offline using this pom.xml and `mvn install` [2].
[1] http://download.jboss.org/jbosstools/builds/staging/jbosstools-3.3_trunk.component--as/all/repo/features/
[2] http://svn.jboss.org/repos/jbosstools/trunk/build/aggregate/webtools-site/pom.xml
Coming up up next, a hudson job and publishing to the correct target folder manually for milestones.
What version of the servers are we pushing and into what stream of Eclipse ? 3.3.M's into Indigo ?
Anyway of testing this before it goes live ?
Version to push would be the features in here: http://download.jboss.org/jbosstools/builds/staging/jbosstools-3.3_trunk.component--as/all/repo/features/ – therefore we could push 3.3M2 NOW and update to 3.3M3 when that drops.
Cannot test the functionality in WTP w/o actually putting content into the site. "Live testing", as it were.
Assigning to Rawbdor to review.
https://hudson.qa.jboss.com/hudson/job/jbosstools-3.3_trunk.webtools.aggregate/37/ is blue.
Results: http://download.jboss.org/jbosstools/updates/nightly/webtools/trunk/ (ignore the fact that it says "SOA Tooling" – that'll be fixed w/ build #38)
Should the site include the new egit integration feature?
Once you're happy w/ the content, assign back to me and I can:
a) spawn a dupe build for the M3 branch
b) publish results like I do w/ our stable milestones & releases.
I tested it for trunk and it seemed to work. I got an error that it couldn't find the RSE drop.
I have not received URLs or build id's to test for 3.2.x maintenance, which is currently a priority.
I do not think we should add in any egit stuff at this time for trunk.
Don't forget to re-assign to me to test after the stuff is published to the proper URLs:
http://download.jboss.org/jbosstools/updates/webtools/helios/ (for WTP 3.2.5)
http://download.jboss.org/jbosstools/updates/webtools/indigo/ (for WTP 3.3)
1. re: helios, this jira was assigned for 3.3, not 3.2 + 3.3; I'll fix that and spawn a new job,etc. for the maintenance branch too.
2. re: "couldn't find the RSE drop" – what does that mean and how does that mesh with "seemed to work?" Is it a blocker/problem?
3. Will omit JBT egit 0.0.1 stuff for now.
Fix target milestones
Now have three jobs:
https://hudson.qa.jboss.com/hudson/job/jbosstools-3.2_stable_branch.webtools.aggregate/ (helios)
https://hudson.qa.jboss.com/hudson/job/jbosstools-3.3_stable_branch.webtools.aggregate/ (indigo, m3)
https://hudson.qa.jboss.com/hudson/job/jbosstools-3.3_trunk.webtools.aggregate/ (indigo, m4)
Now have three sites:
http://download.jboss.org/jbosstools/updates/nightly/webtools/3.2_stable_branch/ (helios)
http://download.jboss.org/jbosstools/updates/nightly/webtools/3.3.indigo/ (indigo, m3)
http://download.jboss.org/jbosstools/updates/nightly/webtools/trunk/ (indigo, m4)
Please review. If satisfied I'll push the bits into the folders under here to replace the empty placeholders:
Bumping to .Final since Rob didn't have time to review this for M1.
This does not seem to work. Compare the categories in these two update sites:
Ours: http://download.jboss.org/jbosstools/updates/nightly/webtools/3.3.indigo/site.xml
Someone Elses: http://download.oracle.com/otn_software/oepe/indigo/wtp/site.xml
Note that in ours, it says: category name="JBoss Tools - Web Tools Nightly Build Update Site"
Yet in the others it says: category name="org.eclipse.wst.server.core.serverAdapter"
The category in the site.xml is completely wrong. I tested it but since none of the jars in our update site had hte proper category flag, none were recognized.
ok, renamed the categories in all three site.xml files (2 branches + trunk).
Respinning:
https://hudson.qa.jboss.com/hudson/job/jbosstools-3.2_stable_branch.webtools.aggregate/ (helios)
https://hudson.qa.jboss.com/hudson/job/jbosstools-3.3_stable_branch.webtools.aggregate/ (indigo, m3)
https://hudson.qa.jboss.com/hudson/job/jbosstools-3.3_trunk.webtools.aggregate/ (indigo, m4)
Results when above respins are done:
http://download.jboss.org/jbosstools/updates/nightly/webtools/3.2_stable_branch/ (helios) - should be build # H16
http://download.jboss.org/jbosstools/updates/nightly/webtools/3.3.indigo/ (indigo, m3) - should be # H12
http://download.jboss.org/jbosstools/updates/nightly/webtools/trunk/ (indigo, m4) - should be # H39
Did you want label="JBoss Application Server Adapters", as per your Oracle example? Or something else?
Bounce back to Rob for review when respins are done (also, question about label in site).
1) Unzip the attached zip file into some temporary location. It is the eclipse wtp plugin in charge of discovery. Note that the plugin is EPL, and also that the file "serverAdapterSites.xml" has been trimmed by me to only include our suggested site.
2) Import this plugin project into a clean eclipse / wtp installation.
3) Run the runtime workbench
4) File -> New -> Server, then click "Download Additional Server Adapters"
5) Note that it comes up with a list of features to download.
The version before my vacation did not work at all. Zero elements showed up in the list. Now, it seems, many do. This will be confusing for a user. I believe that simply having the highest-wrapper feature (as.feature) with the category should be enough. The dependencies will be fetched properly.
I just tested it in the runtime workbench stuff, but it was impossible to get a proper installation after that. It looked like it fetched all the right stuff and none of the wrong stuff, but in the end, you can't install stuff through runtime workbench.
The only way to 100% properly test it is for me to make a fork of the discovery plugin for my test environment, or for you to push to the actual URLs that are in the wtp builds.
I've tried by exploding the discovery jar into a plugin folder, and then changing the site.xml, but that didn't work and only blew up my installation. I really don't know how else to test it other than you pushing to the live site
To be clear, I believe (but can't test) that having all features PRESENT in the site.xml, but having the category listed only in the top-most feature (as.feature) should fix it and then be suitable for a live location
Found a method to replicate at least a little cleaner:
1) Make a new clean installation
2) thunar eclipse/plugins/org.eclipse.wst.server.discovery_1.0.200.v20110518.jar
3) Open serverAdapterSites.xml in vim (from the thunar'd jar file)
4) Set the contents of the file to:
<extensions>
<site url="http://download.jboss.org/jbosstools/updates/nightly/webtools/trunk/"/>
</extensions>
5) Save the file (and rollover it into the zip)
There! You now have a testing environment! YAY! In good news, selecting JUST the as.feature seems to have worked great. I'm still not sure what will happen if you remove the 'category' tag from the non-relevant dependencies... if they still get brought in. Let's hope they do.
Just made a commit to fix the branding problem in some of the other features that is visible in the attachment
Rob, thanks for the steps to repro/test. Worked great (but I had to use BeyondCompare instead of thunar/vim, as thunar launched ark which wouldn't let me edit files in the jar on teh fly).
So, rebuilt the site locally, then hacked the jar to point it at file:///home/nboldt/tru/build/aggregate/webtools-site/target/site/ - got this:

After installation & restart:

So, that's fine for trunk.
However, for the 32x branch, as.feature doesn't include these two features, so I'm not sure I can simply remove them from the site and have them be found:

Testing...
By uncategorizing the two other features, I managed to clean up the install UI:

And it still installs fine:

So... all that's left is to respin these and push them to the production URLs.
Nick:
Judging from your comments, are you suggesting only trunk works and 3.2 is still broken? What are our options for the 3.2 branch?
Well, I've moved the bits to production (http://download.jboss.org/jbosstools/updates/webtools/helios/ and http://download.jboss.org/jbosstools/updates/webtools/indigo/) using the latest spins of 3.2.2.M2 and 3.3.0.M4, and for trunk (Eclipse Indigo SR1 JEE) you can now find the JBoss AS stuff when you search for other servers.
But for the 32x branch?
Houston, we have a problem... the problem is that the discovery plugin that ships w/ Helios SR2 doesn't point at our site. And the updated version in WTP 3.2.4 or .5? Nope, it's not there either.
<extensions>
|
<site url="http://download.eclipse.org/webtools/updates/"/>
|
<site url="http://www.apache.org/dist/geronimo/eclipse/updates/"/>
|
<site url="http://public.dhe.ibm.com/software/websphere/wasce/updates/"/>
|
<site url="http://www.pramati.com/downloads/eclipse/updates/"/>
|
<site url="http://master.dl.sourceforge.net/project/sapnweclipse/updates/"/>
|
<site url="http://www.webtide.com/eclipse"/>
|
<site url="http://jope.ow2.org/update/jope/"/>
|
<site url="http://download.oracle.com/otn_software/oepe/helios/wtp"/>
|
</extensions>
|
<extensions>
|
<site url="http://download.eclipse.org/webtools/updates/"/>
|
<site url="http://www.apache.org/dist/geronimo/eclipse/updates/"/>
|
<site url="http://public.dhe.ibm.com/software/websphere/wasce/updates/"/>
|
<site url="http://www.pramati.com/downloads/eclipse/updates/"/>
|
<site url="http://master.dl.sourceforge.net/project/sapnweclipse/updates/"/>
|
<site url="http://www.webtide.com/eclipse"/>
|
<site url="http://jope.ow2.org/update/jope/"/>
|
<site url="http://download.oracle.com/otn_software/oepe/helios/wtp"/>
|
<site url="http://download.eclipse.org/jetty/updates/jetty-wtp/"/>
|
<site url="http://www.caucho.com/eclipse/"/>
|
</extensions>
|
So, short of getting WTP to spin a 3.2.6 release (unlikely), I don't see any simple way for Helios SR2 JEE users to discover JBoss AS.
Workaround? Send them here to install the feature by hand: http://download.jboss.org/jbosstools/updates/webtools/helios/
Since the AS feature is also on http://download.jboss.org/jbosstools/updates/stable/helios/, I see no need to retain this extra site. We can just direct people to the existing site to install the adapter.
Screenshot:

3.2_stable_branch job has been renamed and marked deprecated. Content for 32x in download.jboss.org/tools/ has been purged. And I added this:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=282778 is an example of upstream