Details

    • Similar Issues:
      Show 10 results 
    1. mock_automatic_runtimedetection.bmml
      11 kB
      Max Rydahl Andersen
    2. o.j.t.runtime.patch
      63 kB
      Snjezana Peco
    3. o.j.t.runtime1.patch
      65 kB
      Snjezana Peco
    4. o.j.t.runtime2.patch
      67 kB
      Snjezana Peco
    1. EditRuntimeDialog1.png
      15 kB
    2. EditRuntimeDialog2.png
      27 kB
    3. JBTRuntimeDetectionPreferencePage.png
      36 kB
    4. JBTRuntimeDetectionPreferencePage1.png
      49 kB
    5. mock_automatic_runtimedetection.png
      224 kB
    6. SearchForRuntimes.png
      25 kB

      Issue Links

        Activity

        Hide
        Snjezana Peco
        added a comment -

        > 1) Avaliable is spelled wrong

        Will fix.

        > 2) Runtime detectors should not have "runtime" in their name

        Will fix.

        > 3) Shouldn't runtime detectors be ordered to know which comes first or is that implicit ?

        We could add the order element to the extension point that would determine the order in which runtime detectors will be displayed and executed. This hasn't been added because Seam, Drools, jBPM and AS can be executed/created in any order.

        > 4) Search is not enabled when not selecting an element - does it only search the selected directory ?

        Since your mockup is showing that Refresh and Search call the same dialog, I understood that both of them search the selected/edited directory.

        > 5) I miss a "Search" button that search all.

        Do we need to add a new or change the existing "Search" to search all directories?

        > 6) how would I search just one new directory for a one-off installation ?

        Sorry, don't understand this.

        > 7) I added a directory, switch to new workspace and a dialog say new runtimes had been detected and if I wanted to edit them.
        > I said yes - but nothing was shown besides the preference page. I was expecting to see the list of found runtimes on the first dialog and
        > be able to confirm if they should be installed or not.

        I didn't understand that from your mockup. Will implement.

        Show
        Snjezana Peco
        added a comment - > 1) Avaliable is spelled wrong Will fix. > 2) Runtime detectors should not have "runtime" in their name Will fix. > 3) Shouldn't runtime detectors be ordered to know which comes first or is that implicit ? We could add the order element to the extension point that would determine the order in which runtime detectors will be displayed and executed. This hasn't been added because Seam, Drools, jBPM and AS can be executed/created in any order. > 4) Search is not enabled when not selecting an element - does it only search the selected directory ? Since your mockup is showing that Refresh and Search call the same dialog, I understood that both of them search the selected/edited directory. > 5) I miss a "Search" button that search all. Do we need to add a new or change the existing "Search" to search all directories? > 6) how would I search just one new directory for a one-off installation ? Sorry, don't understand this. > 7) I added a directory, switch to new workspace and a dialog say new runtimes had been detected and if I wanted to edit them. > I said yes - but nothing was shown besides the preference page. I was expecting to see the list of found runtimes on the first dialog and > be able to confirm if they should be installed or not. I didn't understand that from your mockup. Will implement.
        Hide
        Snjezana Peco
        added a comment -

        I have created a new update site and attached a new source code.
        I hope I have added all the functionalities you required except #6 that I don't understand.

        Show
        Snjezana Peco
        added a comment - I have created a new update site and attached a new source code. I hope I have added all the functionalities you required except #6 that I don't understand.
        Hide
        Snjezana Peco
        added a comment -

        I think I have fixed the issues you described in our chat.
        I have created a new update site and attached a new source.
        I would have one suggestion: adding the Select all/Deselect All button to the Edit and Search Runtime Path dialog that would enable/disable all runtimes.

        Show
        Snjezana Peco
        added a comment - I think I have fixed the issues you described in our chat. I have created a new update site and attached a new source. I would have one suggestion: adding the Select all/Deselect All button to the Edit and Search Runtime Path dialog that would enable/disable all runtimes.
        Hide
        Max Rydahl Andersen
        added a comment -

        updated, here are what I see for now:

        1) When clicking Search: "Hide created runtimes" -> "Hide already created runtimes" and disable it by default so they dont show up. Note, in the case no new runtimes is found show the existing ones but greyed out.

        2) I can still uncheck runtimes that is already installed - what is that supposed to do ? Should just be a disabled checkbox.

        3) N Runtimes found, please move that up after the "Searching runtimes finished" so "Press Ok..."shows up first in the line.

        4) "Press OK to create the enabled ones" -> "Press Ok to create the runtimes with a checkmark"

        Show
        Max Rydahl Andersen
        added a comment - updated, here are what I see for now: 1) When clicking Search: "Hide created runtimes" -> "Hide already created runtimes" and disable it by default so they dont show up. Note, in the case no new runtimes is found show the existing ones but greyed out. 2) I can still uncheck runtimes that is already installed - what is that supposed to do ? Should just be a disabled checkbox. 3) N Runtimes found, please move that up after the "Searching runtimes finished" so "Press Ok..."shows up first in the line. 4) "Press OK to create the enabled ones" -> "Press Ok to create the runtimes with a checkmark"
        Hide
        Snjezana Peco
        added a comment -

        > 1) When clicking Search: "Hide created runtimes" -> "Hide already created runtimes" and disable it by default so they dont show up. Note, in the case no new runtimes is found show the existing ones but greyed out.

        Fixed.

        > 2) I can still uncheck runtimes that is already installed - what is that supposed to do ? Should just be a disabled checkbox.

        Created runtimes can be enabled/disabled when starting Eclipse in a new workspace.

        > 3) N Runtimes found, please move that up after the "Searching runtimes finished" so "Press Ok..."shows up first in the line.

        Fixed.

        > 4) "Press OK to create the enabled ones" -> "Press Ok to create the runtimes with a checkmark"

        Fixed.

        The changes have been committed to the trunk.

        Show
        Snjezana Peco
        added a comment - > 1) When clicking Search: "Hide created runtimes" -> "Hide already created runtimes" and disable it by default so they dont show up. Note, in the case no new runtimes is found show the existing ones but greyed out. Fixed. > 2) I can still uncheck runtimes that is already installed - what is that supposed to do ? Should just be a disabled checkbox. Created runtimes can be enabled/disabled when starting Eclipse in a new workspace. > 3) N Runtimes found, please move that up after the "Searching runtimes finished" so "Press Ok..."shows up first in the line. Fixed. > 4) "Press OK to create the enabled ones" -> "Press Ok to create the runtimes with a checkmark" Fixed. The changes have been committed to the trunk.

          People

          • Assignee:
            Snjezana Peco
            Reporter:
            Max Rydahl Andersen
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: