Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-6228

"JBoss Maven Seam Integration" modifies web.xml during project import

        Details

        • Type: Bug
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: 3.1.0.GA
        • Fix Version/s: 3.3.0.M3
        • Component/s: maven, upstream
        • Labels:
          None
        • Environment:
          Eclipse 3.5.2, m2eclipse 0.10.0, JBoss Tools 3.1.0, Java 1.6.0-20, Debian GNU/Linux 5.0

          Description

          Used software:

          Steps to reproduce:

          1. Import the seamIntegration project from http://anonsvn.jboss.org/repos/richfaces/tags/3.3.3.Final/samples/seamIntegration/:

          File
          -> New
          -> Other...
          -> Checkout Maven Projects from SCM
          -> Next
          -> SCM URL: svn, http://anonsvn.jboss.org/repos/richfaces/tags/3.3.3.Final/samples/seamIntegration/
          -> Finish

          2. Compare the imported web.xml with the original one: http://anonsvn.jboss.org/repos/richfaces/tags/3.3.3.Final/samples/seamIntegration/src/main/webapp/WEB-INF/web.xml.

          3. Problem: The file is completely rewritten. All comments are lost.

            Gliffy Diagrams

              Issue Links

              relates to

              Bug - A problem which impairs or prevents the functions of the product. JBIDE-9454 Adding the JSF Facet (< 2.0) completely overwrites the project web.xml with m2e-wtp 0.13.x

              • Major - A request that should be considered seriously but is not a show stopper.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                maxandersen Max Rydahl Andersen added a comment -

                Snjezana, who are doing this web.xml rewrite ? our plugins or m2eclipse wtp integration?

                Show
                maxandersen Max Rydahl Andersen added a comment - Snjezana, who are doing this web.xml rewrite ? our plugins or m2eclipse wtp integration?
                Hide
                Permalink
                clemens.fuchslocher Clemens Fuchslocher added a comment -

                The web.xml is only modified when "JBoss Maven Seam Integration" (1.0.0.v201003050540R-H56-GA) is installed.

                Show
                clemens.fuchslocher Clemens Fuchslocher added a comment - The web.xml is only modified when "JBoss Maven Seam Integration" (1.0.0.v201003050540R-H56-GA) is installed.
                Hide
                Permalink
                snjeza Snjezana Peco added a comment -

                The JBoss Maven Seam Configurator adds the Seam facet if there is a Seam library in the pom.xml.
                The Seam facet updates web.xml using the Webtools API (IModelProvider) that removes comments.
                We have to use the Webtools API because web.xml can be updated by some other facet (the JSF facet, for instance).
                This is a problem with the Webtools API. You can check it in the following way:

                • create a Dynamic Web Project
                • open web.xml and add a comment
                • create a servlet
                  web.xml will be updated, but the comment will be removed.
                  The problem also happens in Eclipse 3.6M7.
                Show
                snjeza Snjezana Peco added a comment - The JBoss Maven Seam Configurator adds the Seam facet if there is a Seam library in the pom.xml. The Seam facet updates web.xml using the Webtools API (IModelProvider) that removes comments. We have to use the Webtools API because web.xml can be updated by some other facet (the JSF facet, for instance). This is a problem with the Webtools API. You can check it in the following way: create a Dynamic Web Project open web.xml and add a comment create a servlet web.xml will be updated, but the comment will be removed. The problem also happens in Eclipse 3.6M7.
                Hide
                Permalink
                maxandersen Max Rydahl Andersen added a comment -

                off 3.1.1 since this is how WTP (unfortunately works).

                We should get this reported against WTP though. I wonder if this is happening for all JEE manipulations...

                Show
                maxandersen Max Rydahl Andersen added a comment - off 3.1.1 since this is how WTP (unfortunately works). We should get this reported against WTP though. I wonder if this is happening for all JEE manipulations...
                Hide
                Permalink
                snjeza Snjezana Peco added a comment -

                An upstream issue.

                Show
                snjeza Snjezana Peco added a comment - An upstream issue.
                Hide
                Permalink
                fbricon Fred Bricon added a comment -

                The issue is currently fixed with the change for JBIDE-9454 (disabled web.xml modification).

                The problem will probably manifest itself again when adding the faces servlet to web.xml is reenabled, and until the upstream issue is fixed.
                @Snjeza do you have a BZ number for this upstream issue?

                Show
                fbricon Fred Bricon added a comment - The issue is currently fixed with the change for JBIDE-9454 (disabled web.xml modification). The problem will probably manifest itself again when adding the faces servlet to web.xml is reenabled, and until the upstream issue is fixed. @Snjeza do you have a BZ number for this upstream issue?
                Hide
                Permalink
                rawagner Rastislav Wagner added a comment -

                verified in JBDS 5.0.0.v201109071858R-H28-M3

                Show
                rawagner Rastislav Wagner added a comment - verified in JBDS 5.0.0.v201109071858R-H28-M3

                  People

                  • Assignee:
                    fbricon Fred Bricon
                    Reporter:
                    clemens.fuchslocher Clemens Fuchslocher
                  • Votes:
                    1 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Development