Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-1636 Code Review
  3. JBIDE-3355

org.jboss.tools.common.text.ext.hyperlink.AbstractHyperlink review

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Obsolete
    • Icon: Major Major
    • None
    • 3.0.0.cr1
    • cleanup
    • None

      1. Consider using another approach instead of using snippet below in all methods:
      protected IFile getFile() {
      StructuredModelWrapper smw = new StructuredModelWrapper();
      try

      { smw.init(getDocument()); return smw.getFile(); }

      finally

      { smw.dispose(); }

      }
      2. Review static methods, as example - public static IFile getFile(IStructuredModel structuredModel) looks to compex

            nivologd@gmail.com Denis Golovin (Inactive)
            nivologd@gmail.com Denis Golovin (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: