-
Bug
-
Resolution: Done
-
Major
-
4.5.2.AM2
-
None
-
devex #142 December 2017
-
2
Once authentication (to access Fabric8 Analytics API) is fixed we can add this to JBoss Tools and devstudio. cc: gbatra
Assuming we also want to create a Central connector to advertise this optional feature.
In future we could also consider adding a Marketplace connector (separate from JBT/devstudio), if that's desired. cc: manderse@redhat.com adisakala_jira
Sources: https://github.com/fabric8-analytics/fabric8-analytics-devstudio-plugin
Affected:
- https://github.com/jbdevstudio/jbdevstudio-product (category.xml, feature.xml)
- https://github.com/jbosstools/jbosstools-build-sites (category.xml)
- https://github.com/jbosstools/jbosstools-discovery (plugin.xml x 2, plus new icon if applicable?)
- IE-screenshot.png
- 108 kB
- Screenshot (2).png
- 166 kB
- screenshot-1.png
- 223 kB
- screenshot-2.png
- 258 kB
- stack analysis.mp4
- 2.75 MB
- causes
-
JBDS-4591 Can't install com.redhat.fabric8analytics.lsp.eclipse from RH Central
-
- Closed
-
- links to
[JBIDE-24897] add fabric8 analytics feature to jbosstools and devstudio (optional feature, new Central connector)
QE appears satisfied, and at last count when Jeff tested the fabric8 analytics, it worked... so resolving.
nickboldt, yes, I just checked in a recent build of devstudio 11.3 AM2 and now the central connector says correctly Technology Preview, just like psrna requested.
Does that mean that this JIRA can be finally resolved?
I don't think we've ever defined our certification as "Technology Preview" in the past, but I can s/Supported/Technology Preview/g now if that's what we prefer. Could also use "Experimental" to be consistent with Arquilian and Angular.
cc: bodavis@redhat.com jmaury@redhat.com rhn-support-rick โ anyone have a strong preference for "Technology Preview" vs. "Experimental" ?
Cert. issue is resolved. please check now jmaury@redhat.com
jmaury@redhat.com currently working with SD team to have proper certificates for 3Scale Gateway servers... Will keep you posted ..
Thanks Jeff,
The issue is fixed, here is the screenshot for the same. I think we are good to go for the release.
FTR the errors on IE/Win10:
https://stackoverflow.com/questions/44244468/method-assign-not-supported-in-ie-what-to-do may help
If you install JBT [1] or devstudio [2] from the latest snapshot site, you can then see the F8A plugin available in Central after enabling Early Access:
[1] http://download.jboss.org/jbosstools/oxygen/snapshots/updates/discovery.earlyaccess/master/
[2] https://devstudio.redhat.com/11/snapshots/updates/discovery.earlyaccess/master/
Regarding the Windows issue, just want to emphasize that I had this issue a long time ago and I got answered the next version will fix this so relying on it to be fixed before the next code freeze need to be taken with caution
I'm ready to add F8A to Central. https://github.com/jbosstools/jbosstools-discovery/pull/375
But first we need to publish a milestone release to its own update site: http://download.jboss.org/jbosstools/oxygen/development/updates/fabric8analytics/
Let me know which build you'd like tagged as a milestone, from those here:
http://download.jboss.org/jbosstools/oxygen/snapshots/builds/jbosstools-fabric8analytics_master/
( Ref: https://github.com/openshiftio/openshift.io/issues/1971#issuecomment-362034690 )
I already answered some of the questions on mattermost but for the record:
Iis the inability to run this on Windows OOTB a blocker, or just a really big annoyance, given that the audience for JBT/devstudio is 80% Windows users?
Its basically a blocker but it has to be fixed on Fabric8 analytics website and we hope that it will be fixed by the time of Devstudio codefreeze
Did the PR / Jenkins/github integration get fixed?
yes
Should the itests be passing? https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstudio/view/jbosstools-central-projects/job/fabric8-analytics.itests/
The tests are behind the changes made to workflow. We will fix them by the end of the week. This is something that has to be improved in the future.
Unit tests are working fine.
Questions:
- Iis the inability to run this on Windows OOTB a blocker, or just a really big annoyance, given that the audience for JBT/devstudio is 80% Windows users?
- Did the PR / Jenkins/github integration get fixed?
- Should the itests be passing? https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstudio/view/jbosstools-central-projects/job/fabric8-analytics.itests/
nickboldt QE confirms that F8A plugin can be included in JBT 4.5.3.AM1 as Tech Preview.
There is an issue[1] with Fabric8 Analytics webpage not working in Internet Explorer and therefore it does not work in internal eclipse browser on Windows.
[1] https://github.com/fabric8-analytics/fabric8-analytics-devstudio-plugin/issues/164
maxandersen No sorry, jenkins.fabric8analytics+osiotest@redhat.com is account name, used email for this account is fabric8analytics.osiotest@yahoo.com , I will cc you in email conversation about this.
vprusa I do not see a user with such email - are you sure that is the correct email ?
Im still waiting for test account that could be used in jenkins job
email: jenkins.fabric8analytics+osiotest@redhat.com
Could that be escalated?
kbsingh-1 maxandersen alexeykazakov
Also i have to refactor itests for latest changes/fixes, i suppose minor changes.
Once QE confirms this works the way you all expect, we can proceed with adding this to Central.
https://github.com/openshiftio/openshift.io/issues/1971#issuecomment-359810425
jmaury@redhat.com nickboldt please get the latest plugin from http://download.jboss.org/jbosstools/oxygen/snapshots/builds/jbosstools-fabric8analytics_master/latest/all/repo/
Stack analysis is now working and been tested...
jmaury@redhat.com currently working with gbatra. Will confirm in the next few hours to pick up new version of plugin.
nickboldt two days back, the backend was down few mins. across openshift.io (nothing specific to Fabric8 Analytics) as no one could login for few mins. Here is the SEV-1 that was created, got resolved..
nickboldt I will be working with you guyz (get closer to DevStudio plugin) to get handle on current open items and gbatra has setup call next week to discuss this..
Decision by Srikrishna during RTD deck review: slip to Devstudio 11.3 (Heather train).
So, change fixversion to 4.5.3.AM1 and hopefully this will be ready (with enabled tests) by Feb 7 code freeze.
FWIW, if we don't get this completed before (or slightly after code freeze), the next window for GA delivery is in April 24, via the next train, in 12 weeks. But if you want to include it earlier as part of a JBoss Tools milestone release, those are released to the public every 3 weeks.
Calendar as always is here: http://bitly.com/rhdtrain
nickboldt c) is the worst option we should even not consider doing (maybe less work). I do not believe in miracles and we should avoid surprises. I would rather see proper planning and execution in the next release train. I think there is a lot of to be improved in the process.
"The hard part is that we cannot say if it works at least partially or not, because the backend is down. So we cannot confirm for sure."
Options:
a) the back end server returns miraculously before 8:30am EST on Thursday (time of the the 5x5 call), QE confirms it works, and I pull a Hail Mary and do all the work to add this into JBT/devstudio/central a day after code freeze. Staging build for QE review is a few hours late, but DOES include the fabric8 analytics. QE signoff planned for next Tuesday may be delayed to Wed, but we still have 2-3 days to complete the release after that.
b) the above stars (in option a) do not align, and fabric8 analytics feature is not included in JBT/devstudio/Central
c) even without confirming if it's broken or working, we include it today as a Tech Preview and cross fingers that when the back end comes back up, things DO work as intended. If not, well, it's a Tech Preview so it's allowed to set your computer on fire. It's not like we're releasing an Intel CPU <cough> Spectre </cough>.
I see quite a lot of commits in last 2 days and also quite a lot of new bugs with High priority reported today.
The hard part is that we cannot say if it works at least partially or not, because the backend is down. So we cannot confirm for sure.
There are some items that are open which certainly cannot be closed today. For eg. Replacing the endpoints with 3scale production endpoints, better handling of effective pom files and making LSP work when plugin is downloaded from updated site. spaparaj can add more here.
No the build was working on Windows but I never managed to get a stack report being displayed on Windows.
If we get confirmation that it does not work, then we should not include it.
However, in light of your earlier comments, psrna, if it does work, then it should be an optional installation in DevStudio (since it's in tech preview) and once it's GA, it should be in the default package.
The status as an optional install in JBT still stands - assuming it works.
I thought we had confirmation that it was working yesterday, is that not right?
Regarding the Jenkins job not running UI tests... not sure why.
I see a commit disabling unit tests. Plugin API has changed and the tests were not adjusted, but instead disabled to pass the build. This should not happen again.
I've had a recent chat with gbatra and there are several blocking issues to be fixed: e.g: (LSP not working: https://github.com/fabric8-analytics/fabric8-analytics-devstudio-plugin/issues/125, many URL's used are to be changed, etc.)
I want to point out, that bugs not fixed until Today probably won't get into Devstudio 11.2.GA, because devstudio code freeze is Today and we are building Tomorrow.
I'm concerned that this plugin does not meet Devstudio QE release criteria even to be release as a Tech Preview, because it just won't work properly.
bodavis@redhat.com can you please clarify how we proceed with this one? Thx.
bodavis@redhat.com, including it in Core feature basically implies default install (e.g. in devstudio) (nickboldt please correct me if I'm wrong). And as this is to be a Technology Preview I do assume this is not what we want. We historically never did default install for a tech preview feature. It should be an optional install in Central Early Access.
Or, just to through another option out -
Include it in JBT Core Tools and also build it into Devstudio, so it's just there.
I want to make sure that the JBT users can get it, while keeping it easy for Devstudio users.
Bob
IMO, it should be put into JBT "core tools".
It's fine as an "optional install".
Bob
First one is fixed in Geetika's PR 110. Second one is not a problem for a 0.0.1 versioned Tech Preview release.
Regarding the Jenkins job not running UI tests... not sure why. Perhaps psrna or exd-mmalina can suggest something to do to the job so it runs UI tests correctly? We've got xvnc loaded โ not sure what else is required. Do the UI tests use the correct UIThread/UIHarness settings [1] ?
[1] https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml#L302-L308
I've created two issues that could prevent us from including F8 plugin into JBT
https://github.com/fabric8-analytics/fabric8-analytics-devstudio-plugin/issues/118
https://github.com/fabric8-analytics/fabric8-analytics-devstudio-plugin/issues/117
The first one (service unavailable) kept me from testing the plugin properly, so there might be other issues.
I'd like to know Nick's opinion on the second one.
As for the Jenkins job, the UI tests are failing. They have been added only yesterday and have some problems running on Jenkins. I'd recommend to disable them for the moment. The JUnit tests seem to run fine.
jmaury@redhat.com The issue building on windows [1] will be solved later today. Geetika needs to rebase her PR [2] to the latest changes in master.
[1] https://github.com/fabric8-analytics/fabric8-analytics-devstudio-plugin/issues/98
[2] https://github.com/fabric8-analytics/fabric8-analytics-devstudio-plugin/pull/110
Also, I'm seeing itest failures in the latest builds [3]:
So... code freeze is tomorrow. Are we ready to include fabric8 analytics in JBT and devstudio? Do we want a new Central connector too?
Options for inclusion:
- in JBT as an optional install? (if so, which category?)
- in JBT as a default install? (if so, assume category = CoreTools, but maybe also MavenTools?)
- in devstudio as optional install? (if so, which category?)
- in devstudio as default install? (if so, assume category = CoreTools, but maybe also MavenTools? Will also add to the devstudio.rpm.feature so it's installed OOTB)
- in Central as a new connector? (if so, need metadata to describe the feature, and an icon file. See examples here: https://github.com/jbosstools/jbosstools-discovery/blob/master/devstudio/com.jboss.devstudio.central.discovery.earlyaccess/plugin.xml#L33 )
But I have the latest version installed so how come can this be better ?
jmaury@redhat.com, The URL's have been changed and it will be soon available, this should work fine then.
If you look at my stack analysis.mp4 test, this is still not working on Windows (our main target audience) and having a 2mn response time is for me a blocker. Also noticed that there are almost no unit or integration tests
Where can I download latest because I can't build it anymore on Windows and I remember I add some issues on Windows and want to double check ?
Does the service work though? I haven't seen a demo of the plugin working and accessing the service. If it works and someone with an OSIO login can use Eclipse to access Analytics, that would be valuable, but if it's not actually functional (or requires special access or lots of hoops to go through), I would say it's not required. gbatra - who did you confirm with on getting this added?
That's right nickboldt. I confirmed with my seniors, we want this in this release for sure.
Thanks
Spoke with gbatra yesterday and it sounds like the plan is to add this back in for the upcoming Jan release.
Will it still be Technology Preview?
jmaury@redhat.com bodavis@redhat.com can you confirm?
And now apparently this plugin is not ready for release so I'll pull it back out.
https://github.com/jbosstools/jbosstools-build-sites/commit/b4bbfc9dbb3881fd89af401adb9a49fe52ba95c7
https://github.com/jbdevstudio/jbdevstudio-product/commit/ca87ac033b2c588be60a84a0fe57c5ac46054424
https://github.com/jbosstools/jbosstools-discovery/commit/eed0ac10b1afae92b737d9c94f76650f49e341b4
Since this feature will be released as a Technology Preview, the feature.properties need to reflect that. PR to fix:
https://github.com/fabric8-analytics/fabric8-analytics-devstudio-plugin/pull/74
Installing Fabric8 Analytics should now work from the nightly Central site [1] (see instructions here [2])
[1] https://devstudio.redhat.com/11/snapshots/updates/discovery.earlyaccess/master/
[2] https://issues.jboss.org/browse/JBDS-4591?focusedCommentId=13480060&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13480060
... but we should include the source feature too before we can mark this resolved.
PR to add sources to fabric8 analytics site:
https://github.com/fabric8-analytics/fabric8-analytics-devstudio-plugin/pull/72
Add feature to JBT and devstudio update sites:
https://github.com/jbosstools/jbosstools-build-sites/pull/257
https://github.com/jbdevstudio/jbdevstudio-product/commit/1ed25cb3d53776fc0118adc5743a2ddc00046dae
PR: https://github.com/jbosstools/jbosstools-discovery/pull/371
Build:
need to verify that the EA properties are updated:
http://download.jboss.org/jbosstools/oxygen/snapshots/updates/discovery.earlyaccess/master/jbosstools-earlyaccess.properties
https://devstudio.redhat.com/11/snapshots/updates/discovery.earlyaccess/master/devstudio-earlyaccess.properties
As soon as someone contributes a PR for the update sites and discovery plugins, it can be added to Central's Early Access site.
Did we ever get a +1 from jmaury@redhat.com or bodavis@redhat.com to include it? I don't recall seeing that statement in MM, IRC, on a call, or via email, but might have missed it.
When it will be possible to add the plugin into Central (as Tech preview)?
Closing, verified some time ago, Fabirc8 Analytics plugin can be installed to devstudio using central with enabled Early Access and is in Technology Preview