Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-24184

Server adapter: DEV_MODE, DEBUG_MODE, DEBUG_PORT keys (and default values) are hard-coded, not read from docker image

    XMLWordPrintable

Details

    • devex #136 August 2017
    • 24

    Description

      to turn on/off debugging and dev_mode for an app, one needs to set env variables. The keys that are used to set the values are all defined in the docker image labels (inspectable by doing 

      docker inspect <docker-image-id>

      :

      • nodejs 
        "Labels": {
                ...
                "com.redhat.dev-mode": "DEV_MODE:false",
                "com.redhat.dev-mode.port": "DEBUG_PORT:5858",
                ...
      • eap 
        "Labels": {
                ...
               "com.redhat.dev-mode": "DEBUG:true",
                "com.redhat.dev-mode.port": "DEBUG_PORT:8787",
                ...

      Our code on the other hand is hard-coding these, not reading the keys from the docker image:

      public class OpenShiftDebugUtils {
   private static final String DEBUG_KEY = "DEBUG";
   private static final String DEBUG_PORT_KEY = "DEBUG_PORT";
   ...

      public class OpenShiftLaunchController extends AbstractSubsystemController
		implements ISubsystemController, ILaunchServerController {
    ...
    private static final String DEV_MODE = "DEV_MODE"; //$NON-NLS-1$
    ...

      Attachments

        Issue Links

          blocks

          Feature Request - Feature requests from customers and/or users JBIDE-24781 New Application Wizard: Propose to create OpenShift server adapters automatically

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Enhancement - An enhancement to or refactoring of existing functionality that is not configurable by an end user (typically a change made by an internal team that affects users) JBIDE-24787 Wildfly (and other) Server adapter(s): provide defaults in code if docker image has no metadata, nor user settings are provided

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Open
          incorporates

          Enhancement - An enhancement to or refactoring of existing functionality that is not configurable by an end user (typically a change made by an internal team that affects users) JBIDE-24024 Server adapter editor, wizard: better tell me what the settings are for

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed
          is related to

          Bug - A problem that impairs or prevents the functions of the product. JBIDE-24183 OpenShiftDebugUtilsTest: #testGetDebuggingContext is failing

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Bug - A problem that impairs or prevents the functions of the product. JBIDE-24560 Server adapter very slow to restart in debug

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Bug - A problem that impairs or prevents the functions of the product. JBIDE-24876 Server adapter: server adapter for nodejs initially fails, fails to find pods

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Bug - A problem that impairs or prevents the functions of the product. JBIDE-24981 Server adapter: fails to start if app has no dc but only a rc

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Open

          Enhancement - An enhancement to or refactoring of existing functionality that is not configurable by an end user (typically a change made by an internal team that affects users) JBIDE-23900 Refactor OpenShift server adapter to isolate EAP/Wildfly and NodeJS specific stuff

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Enhancement - An enhancement to or refactoring of existing functionality that is not configurable by an end user (typically a change made by an internal team that affects users) JBIDE-24869 Server adapter: add tests for debugging, docker image metadata retrieval etc.

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed
          relates to

          Bug - A problem that impairs or prevents the functions of the product. ENTESB-8925 FIS images should support S2I source + oc rsync from the IDE deployment workflows

          • Critical - To be worked on immediately following BLOCKER issues.
          • Closed

          Bug - A problem that impairs or prevents the functions of the product. JBIDE-23961 Server adapter: "Start/Restart in Debug" is broken for Nodejs

          • Critical - To be worked on immediately following BLOCKER issues.
          • Closed

          Task - Represents a small unit of work that is not end-user facing. JBIDE-24185 Server adapter: approach to set nodejs/eap apps to debugging is inconsistent

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Open

          Activity

            People

              adietish@redhat.com André Dietisheim
              adietish@redhat.com André Dietisheim
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: