Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-22420

Application Wizard: Finish button is still enabled upon selection of a builder image if a template was selected before

XMLWordPrintable

    • devex #115 May 2016
    • 2
    • Hide
      1. ASSERT: have connection with a project in the openshift explorer
      2. EXEC: pick New > Application in the context menu of your project
      3. ASSERT: wizard page with templates and builder images shows up, "Finish" is disabled
      4. EXEC: select a builder image (entry with a box icon as opposed to a lightning)
      5. ASSERT: "Finish" stays disabled
      6. EXEC: select a template (entry with a lightning)
      7. ASSERT: "Finish" gets enabled
      8. EXEC: select a builder image

      Result:
      "Finish" is enabled even though it should be disabled.

      Show
      ASSERT: have connection with a project in the openshift explorer EXEC: pick New > Application in the context menu of your project ASSERT: wizard page with templates and builder images shows up, "Finish" is disabled EXEC: select a builder image (entry with a box icon as opposed to a lightning) ASSERT: "Finish" stays disabled EXEC: select a template (entry with a lightning) ASSERT: "Finish" gets enabled EXEC: select a builder image Result: "Finish" is enabled even though it should be disabled.

      If I select a template in New OpenShift Application wizard, the Finish button is enabled and it is possible to skip all wizard pages and have created an application. If I select a builder image in the wizard, Finish is disabled (although on the next wizard page it gets enabled even I do not set any other value manually). But having selecting a template at first in the wizard and then selecting a build image, Finish button is still enabled. Click on the button cause NPE with following stack trace:

      Unable to create resources to deploy image null


java.lang.IllegalArgumentException: newValue is null
	at org.jboss.dmr.ModelNode.set(ModelNode.java:499)
	at com.openshift.internal.restclient.model.Service.setSelector(Service.java:115)
	at org.jboss.tools.openshift.internal.ui.job.DeployImageJob.stubService(DeployImageJob.java:254)
	at org.jboss.tools.openshift.internal.ui.job.DeployImageJob.generateResources(DeployImageJob.java:150)
	at org.jboss.tools.openshift.internal.ui.job.DeployImageJob.doRun(DeployImageJob.java:99)
	at org.jboss.tools.openshift.internal.common.core.job.AbstractDelegatingMonitorJob.run(AbstractDelegatingMonitorJob.java:37)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

            scabanovich Viacheslav Kabanovich (Inactive)
            mlabuda_jira Marián Labuda (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: