Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-22159

Docker image is empty after selecting it from Image search wizard

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 4.4.0.Final
    • 4.3.1.CR1
    • openshift
    • None

      As discovered in https://github.com/jbosstools/jbosstools-openshift/pull/1106#issuecomment-208542930, provided you have a docker and an OpenShift connection:

      • In OpenShift Explorer, select the Deploy Image menu
      • select the docker connection
      • type a docker image name already pulled in the docker daemon
      • delete it and click the search... button
      • select the same docker image as previously typed
      • once the search wizard closes, the docker Image name field is still empty.

      See http://screencast.com/t/iTJX7SjB

      As per scabanovich:

      it is possible that validator does not let empty string to model, so model remains with valid previous value. Then, when you select that same value in the dialog, model is notified, but it already has that value and it does not notify ui because it did not change

      and his fix proposal:

      before calling setImageName(newValue) check if it has the same value, then call setImageName(""); and only after this check and adjustment call setImageName(newValue).

            scabanovich Viacheslav Kabanovich (Inactive)
            fbricon@redhat.com Fred Bricon
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: