Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-22156

NPE is thrown when no template parameter is selected and reset button is clicked

    Details

    • Steps to Reproduce:
      Hide

      ASSERT: Have an OpenShift 3 connection with a project.
      EXEC: Open New OpenShift Application wizard on the project and select a template.
      EXEC: Proceed to next wizard page by click on the Next button (if double click on template is used to proceed, it works fine, because a template parameter is preselected by default and it is not possible to unselect an item and get NPE).
      ASSERT: No template parameter is selected in the table listing template parameters.
      EXEC: Click Reset button.

      RESULT: NPE is thrown.
      EXPECTED RESULT: Nothing happens.

      Show
      ASSERT: Have an OpenShift 3 connection with a project. EXEC: Open New OpenShift Application wizard on the project and select a template. EXEC: Proceed to next wizard page by click on the Next button (if double click on template is used to proceed, it works fine, because a template parameter is preselected by default and it is not possible to unselect an item and get NPE). ASSERT: No template parameter is selected in the table listing template parameters. EXEC: Click Reset button. RESULT: NPE is thrown. EXPECTED RESULT: Nothing happens.

      Description

      When a Reset button, to reset a template parameter, on second New OpenShift Application wizard page is clicked and there is no selection, following error pops up in error log

      Unhandled event loop exception
      
      java.lang.NullPointerException
      	at org.jboss.tools.openshift.internal.ui.wizard.newapp.NewApplicationWizardModel.resetParameter(NewApplicationWizardModel.java:287)
      	at org.jboss.tools.openshift.internal.ui.wizard.newapp.TemplateParametersPage$7.widgetSelected(TemplateParametersPage.java:383)
      	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
      	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
      	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4481)
      	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1329)
      	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3819)
      	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3430)
      	at org.eclipse.jface.window.Window.runEventLoop(Window.java:827)
      	at org.eclipse.jface.window.Window.open(Window.java:803)
      	at org.jboss.tools.common.ui.WizardUtils.openWizardDialog(WizardUtils.java:287)
      	at org.jboss.tools.common.ui.WizardUtils.openWizardDialog(WizardUtils.java:270)
      	at org.jboss.tools.openshift.internal.ui.handler.NewApplicationHandler.execute(NewApplicationHandler.java:34)
      	at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:295)
      	at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
      	at sun.reflect.GeneratedMethodAccessor81.invoke(Unknown Source)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:498)
      	at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56)
      	at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:252)
      	at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:234)
      	at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
      	at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:152)
      	at org.eclipse.core.commands.Command.executeWithChecks(Command.java:493)
      	at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:486)
      	at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:210)
      	at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.executeItem(HandledContributionItem.java:799)
      	at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.handleWidgetSelection(HandledContributionItem.java:675)
      	at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.access$7(HandledContributionItem.java:659)
      	at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem$4.handleEvent(HandledContributionItem.java:592)
      	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
      	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4481)
      	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1329)
      	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3819)
      	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3430)
      	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1127)
      	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
      	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1018)
      	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:156)
      	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:694)
      	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
      	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:606)
      	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
      	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:139)
      	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
      	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
      	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
      	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
      	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:498)
      	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:669)
      	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:608)
      	at org.eclipse.equinox.launcher.Main.run(Main.java:1515)
      	at org.eclipse.equinox.launcher.Main.main(Main.java:1488)
      

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  fbricon Fred Bricon
                  Reporter:
                  mlabuda Marián Labuda
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: