Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-16021

Revisit whether file transfer requests can trust rse's isConnected

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Obsolete
    • Icon: Major Major
    • 4.2.0.Beta2
    • 4.2.0.Alpha1
    • server, upstream
    • None

      With the large speed increases in jbt's RSE integration, the new bottleneck is during the beginning of the publish event.

      A block of code currently exists as follows:

      		boolean isConnected = fileSubSystem != null && fileSubSystem.isConnected();
      		String connectionName = RSEUtils.getRSEConnectionName(behaviour.getServer());
      		if( isConnected ) {
      			// The RSE tools might be mistaken here. The user may in fact have lost internet connectivity
      			NamedRunnableWithProgress run = new NamedRunnableWithProgress("Accessing Remote System Root") {
      				public Object run(IProgressMonitor monitor) throws CoreException,
      						SystemMessageException, RuntimeException {
      					getFileService().getRoots(monitor);
      					return Status.OK_STATUS;
      				}
      			};
      			IProgressMonitor childMonitor = AbstractServerToolsPublisher.getSubMon(monitor, 100);
      			Exception e = RSERemotePublishHandler.wrapRemoteCallStatusTimeLimit(run, "null", "null", null, 15000, childMonitor);
      

      It would seem strange for the rse's isConnected() method to be incorrect. Investigate whether it is still possible it is incorrect, and file an appropriate upstream bug, or, if no bug, simply remove the lines and improve speed.

            rob.stryker Rob Stryker (Inactive)
            rob.stryker Rob Stryker (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: