Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-15332

stop linking skipRequirements and tests.skip to download of requirements

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Obsolete
    • Minor
    • 4.5.0.AM2
    • 4.2.0.Beta1
    • build

    Description

      I stumbled on nivologd@gmail.com's patch for livreload at https://github.com/jbosstools/jbosstools-livereload/pull/54/files

      This is not the first time i've seen skip having to be enabled for plain normal mvn dependencies.

      skipRequirements are supposed to only cover big downloads (like EAP, jboss etc.) - things done via non-maven download mechanism.

      Why is this applied to mvn dependency downloads ?

      The culprit for needing this line is at:
      https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml#L397

      and a bugzilla (not jira?!) is referenced as the reason for this back in 2012: https://github.com/jbosstools/jbosstools-build/commit/2e18baaf88e0cd73b3b99885658e00789e8fd198

      I understand why the explicit google download plugin (why is there two versions used btw?) but why is skipTests controlling normal mvn dependency download ? Which requirements are using this for download ?

      Attachments

        Issue Links

          is caused by

          Enhancement - An enhancement to or refactoring of existing functionality that is not configurable by an end user (typically a change made by an internal team that affects users) JBIDE-11714 Replace requirements folder & requirements bootstrap job by "self-hosted" content in pom.xml ?

          • Minor - To be worked after urgent, high, and medium priorities are resolved. This term is chosen when the severity of the issue is low, or the complexity or effort to correct it may be higher, relatively speaking. For low priority issues, known workarounds exist or are not needed due to the trivial effort needed to address the issue.
          • Closed
          relates to

          Bug - A problem that impairs or prevents the functions of the product. JBIDE-21232 parent pom should never allow skipTests to prevent download of required libraries

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Task - Represents a small unit of work that is not end-user facing. JBIDE-15397 Ignore 3rd party jar files in wildfly8 management plugin downloaded by maven-dependency-plugin

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Activity

            People

              nickboldt Nick Boldt
              manderse@redhat.com Max Andersen
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: