Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-14920

CordovaSim: need to replace global BsPopup variable with more elegant emulatorBridge.window() structure

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Done
    • Icon: Major Major
    • 4.1.0.CR1
    • None
    • browsersim
    • None

      While making PR for Ripple team (https://issues.apache.org/jira/browse/RIPPLE-26), a really elegant way of accessing child window/frame was found.
      Now we use global variable 'bsPopup' for accesing BrowserSim, which is not really neat solution:

      • Implementation is tightly coupled with BrowserSim;
      • Problems with merging original ripple source code;
      • Have no possibility of patch sending to the ripple team;

      There is a need in replacement all global bsPopup usage to:

        var emulatorBridge = ripple('emulatorBridge');
         .
         .
         .
         emulatorBridge.window();
      

            ibuziuk@redhat.com Ilya Buziuk
            ibuziuk@redhat.com Ilya Buziuk
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: