Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-14919

drop PreferencePage and use PreferenceUtil to show SSH preferences

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Done
    • Icon: Minor Minor
    • 4.1.0.CR1
    • 4.1.0.Beta2
    • openshift
    • None

      in the Git clonging settings page of the OpenShift wizard, we offer a link to the SSH preferences. Clicking this link allows one to get to the SSH preferences and add some private key. When showing the preferences dialog we use legacy code:

      GitCloningSettingsWizardPage#onSshPrefs
      SshPrivateKeysPreferences.openPreferencesPage(getShell());
      
      SshPrivateKeysPreferences#openPreferencesPage
      public static void openPreferencesPage(Shell shell) {
      	PreferenceDialog dialog = PreferencesUtil.createPreferenceDialogOn(
      			shell, SSH_PREFERENCE_PAGE_ID, null, null);
      	dialog.open();
      }
      

      This way of showing the Eclipse preferences is outdated, one should do

      final PreferenceDialog dialog = PreferencesUtil.createPreferenceDialogOn(
      	jreButton.getShell(),
      	JREsPreferencePage.ID, 
      	new String[] {}, 
      	null);
      

            fbricon@redhat.com Fred Bricon
            adietish@redhat.com André Dietisheim
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: