Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-13200

As-You-Type Validation should not create any markers on resources

    XMLWordPrintable

Description

    As You Type Validator Manager should not create any resource markers.

    At the moment, it invokes KBValidator.validateBuildOrder, which creates a resource marker regardless of how it's called. This is correct for Build-Validation, but make a problem to As You Type validation if it's invoked right after a CDI Nature (for example) is just added to a project:

    !ENTRY org.jboss.tools.cdi.core 4 0 2012-11-26 21:42:08.837
    !MESSAGE The resource tree is locked for modifications.
    !STACK 1
    org.eclipse.core.internal.resources.ResourceException: The resource tree is locked for modifications.
    	at org.eclipse.core.internal.resources.WorkManager.checkIn(WorkManager.java:116)
    	at org.eclipse.core.internal.resources.Workspace.prepareOperation(Workspace.java:2282)
    	at org.eclipse.core.internal.resources.Resource.createMarker(Resource.java:733)
    	at org.jboss.tools.jst.web.kb.internal.validation.KBValidator.validateBuilderOrder(KBValidator.java:100)
    	at org.jboss.tools.cdi.internal.core.validation.CDIELValidationDelegate.validateBuilderOrder(CDIELValidationDelegate.java:53)
    	at org.jboss.tools.cdi.internal.core.validation.CDIELValidationDelegate.shouldValidate(CDIELValidationDelegate.java:44)
    	at org.jboss.tools.jst.web.kb.internal.validation.ELValidator.shouldValidate(ELValidator.java:637)
    	at org.jboss.tools.common.validation.ValidationContext.shouldValidate(ValidationContext.java:137)
    	at org.jboss.tools.common.validation.EditorValidationContext.shouldValidate(EditorValidationContext.java:50)
    	at org.jboss.tools.common.validation.ValidationContext.init(ValidationContext.java:126)
    	at org.jboss.tools.common.validation.ValidationContext.<init>(ValidationContext.java:43)
    	at org.jboss.tools.common.validation.EditorValidationContext.<init>(EditorValidationContext.java:30)
    	at org.jboss.tools.common.validation.AsYouTypeValidatorManager.init(AsYouTypeValidatorManager.java:151)
    	at org.jboss.tools.common.validation.AsYouTypeValidatorManager.validateJavaElement(AsYouTypeValidatorManager.java:213)
    	at org.jboss.tools.common.validation.AsYouTypeValidatorManager.validateJavaElement(AsYouTypeValidatorManager.java:209)
    	at org.jboss.tools.common.validation.java.JavaDirtyRegionProcessor.projectCapabilitiesChanged(JavaDirtyRegionProcessor.java:670)
    	at org.jboss.tools.common.validation.java.ProjectCapabilitiesService.resourceChanged(ProjectCapabilitiesService.java:300)
    	at org.eclipse.core.internal.events.NotificationManager$1.run(NotificationManager.java:291)
    	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
    	at org.eclipse.core.internal.events.NotificationManager.notify(NotificationManager.java:285)
    	at org.eclipse.core.internal.events.NotificationManager.broadcastChanges(NotificationManager.java:149)
    	at org.eclipse.core.internal.resources.Workspace.broadcastPostChange(Workspace.java:395)
    	at org.eclipse.core.internal.resources.Workspace.endOperation(Workspace.java:1530)
    	at org.eclipse.core.internal.resources.Project.setDescription(Project.java:1366)
    	at org.eclipse.core.internal.resources.Project.setDescription(Project.java:1378)
    	at org.jboss.tools.common.EclipseUtil.addNatureToProject(EclipseUtil.java:106)
    	at org.jboss.tools.jst.web.WebModelPlugin.addNatureToProjectWithValidationSupport(WebModelPlugin.java:127)
    	at org.jboss.tools.cdi.core.CDIUtil.enableCDI(CDIUtil.java:98)
    	at org.jboss.tools.cdi.ui.preferences.CDISettingsPreferencePage.addCDISupport(CDISettingsPreferencePage.java:147)
    	at org.jboss.tools.cdi.ui.preferences.CDISettingsPreferencePage.performOk(CDISettingsPreferencePage.java:135)
    	at org.eclipse.jface.preference.PreferenceDialog$13.run(PreferenceDialog.java:965)
    	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
    	at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:49)
    	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:175)
    	at org.eclipse.jface.preference.PreferenceDialog.okPressed(PreferenceDialog.java:945)
    	at org.eclipse.ui.internal.dialogs.FilteredPreferenceDialog.okPressed(FilteredPreferenceDialog.java:448)
    	at org.eclipse.jface.preference.PreferenceDialog.buttonPressed(PreferenceDialog.java:233)
    	at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:624)
    	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
    	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
    	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1276)
    	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3554)
    	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3179)
    	at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
    	at org.eclipse.jface.window.Window.open(Window.java:801)
    	at org.jboss.tools.cdi.ui.preferences.AddCDISupportAction.run(AddCDISupportAction.java:44)
    	at org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:251)
    	at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
    	at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
    	at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
    	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
    	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1276)
    	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3554)
    	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3179)
    	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1029)
    	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
    	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:923)
    	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:86)
    	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:588)
    	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
    	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:543)
    	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
    	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
    	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
    	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
    	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
    	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:353)
    	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:180)
    	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    	at java.lang.reflect.Method.invoke(Method.java:616)
    	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:629)
    	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:584)
    	at org.eclipse.equinox.launcher.Main.run(Main.java:1438)
    	at org.eclipse.equinox.launcher.Main.main(Main.java:1414)
    !SUBENTRY 1 org.eclipse.core.resources 4 380 2012-11-26 21:42:08.838
    !MESSAGE The resource tree is locked for modifications.
    

    Attachments

      Issue Links

        Activity

          People

            xcoulon@redhat.com Xavier Coulon
            vrubezhny Victor Rubezhny (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: