Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-11696

portforward: start/stop errors instantly so no error handling possible and if one port fails all other fails too

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 3.3.0.Beta3
    • None
    • openshift
    • None

      workaround patch for client:

      diff --git a/src/main/java/com/openshift/internal/client/ApplicationResource.java b/src/main/java/com/openshift/internal/client/ApplicationResource.java
      index 60b4bfe..aaebd09 100755
      --- a/src/main/java/com/openshift/internal/client/ApplicationResource.java
      +++ b/src/main/java/com/openshift/internal/client/ApplicationResource.java
      @@ -616,14 +616,24 @@ public class ApplicationResource extends AbstractOpenShiftResource implements IA
       			throw new OpenShiftSSHOperationException("SSH session for application \"{0}\" is closed or null. Cannot start port forwarding", this.getName());
       		}
       		for (IApplicationPortForwarding port : ports) {
      -			port.start(session);
      +			try {
      +				port.start(session);
      +			} catch(OpenShiftSSHOperationException oss) {
      +				// ignore for now
      +				// should store this error on the forward to let user know why it could not start/stop
      +			}
       		}
       		return ports;
       	}
       
       	public List<IApplicationPortForwarding> stopPortForwarding() throws OpenShiftSSHOperationException {
       		for (IApplicationPortForwarding port : ports) {
      -			port.stop(session);
      +			try {
      +				port.stop(session);
      +			} catch(OpenShiftSSHOperationException oss) {
      +				// ignore for now
      +				// should store this error on the forward to let user know why it could not start/stop				
      +			}
       		}
       		// make sure port forwarding is stopped by closing session...
       		session.disconnect();
      
      

      patch in ui:

      Index: plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/core/portforward/ApplicationPortForwardingWizardPage.java
      ===================================================================
      --- plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/core/portforward/ApplicationPortForwardingWizardPage.java	(revision 40574)
      +++ plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/core/portforward/ApplicationPortForwardingWizardPage.java	(working copy)
      @@ -194,7 +194,7 @@
       								wizardModel.startPortForwarding();
       								refreshViewerInput();
       							} catch (Exception e) {
      -								Logger.error("Failed to start port-forwarding", e);
      +								return OpenShiftUIActivator.createErrorStatus("Failed to start port-forwarding.", e);
       							}
       							return Status.OK_STATUS;
       						}
      @@ -227,7 +227,7 @@
       								wizardModel.stopPortForwarding();
       								refreshViewerInput();
       							} catch (Exception e) {
      -								Logger.error("Failed to stop Port-forwarding", e);
      +								return OpenShiftUIActivator.createErrorStatus("Failed to stop port-forwarding.", e);
       							}
       							return Status.OK_STATUS;
       						}
      

            xcoulon@redhat.com Xavier Coulon
            manderse@redhat.com Max Andersen
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: