Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-10597

Change node name comparison to equalsIgnoreCase(..)

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Minor Minor
    • 3.3.0.Beta1
    • 3.3.0.M5
    • None
    • None

      Vlado Pakan wrote:
      I would like to make small change to http://svn.jboss.org/repos/jbosstools/trunk/vpe/plugins/org.jboss.tools.vpe/src/org/jboss/tools/vpe/editor/VpeVisualDomBuilder.java.
      I need to make this small change to doToggle(...) method:
      Current code:

      while (!selectedElem.getNodeName().equals(HTML.TAG_TABLE)) {
       selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
      }
      

      Proposed code:

      while (!selectedElem.getNodeName().equalsIgnoreCase(HTML.TAG_TABLE)) {
       selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
      }
      

      Problem is that method selectedElem.getNodeName() returns node name uppercase but HTML.TAG_TABLE is lowercase so method equals(HTML.TAG_TABLE) always returns false and my tests are failing.

        1. rich_stp.jsp
          0.5 kB
          Denis Maliarevich

            dmaliarevich_jira Denis Maliarevich (Inactive)
            dmaliarevich_jira Denis Maliarevich (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: