Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-10001

NPE when saying no to not publishing

        Details

        • Type: Bug
        • Status: Closed (View Workflow)
        • Priority: Critical
        • Resolution: Done
        • Affects Version/s: 3.3.0.M4
        • Fix Version/s: 3.3.0.M4
        • Component/s: server
        • Labels:
          None

          Description

          Said no to a publish and got NPE

          missing null check somewhere ?

            Gliffy Diagrams

              Issue Links

              cloned to

              Feature Request - A new feature of the product, which has yet to be developed. JBIDE-10003 CLONE - NPE when saying no to not publishing

              • Critical - An upcoming version that is affected by this issue cannot be released until it's addressed. A critical bug is one that crashes the application, causes loss of data or severe memory leak.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                maxandersen Max Rydahl Andersen added a comment -

                seem to be a very stupid and weirdly non-found arrary index bug.

                Patch is:

                Index: ExpressPublishMethod.java
                ===================================================================

                Show
                maxandersen Max Rydahl Andersen added a comment - seem to be a very stupid and weirdly non-found arrary index bug. Patch is: Index: ExpressPublishMethod.java ===================================================================
                Hide
                Permalink
                maxandersen Max Rydahl Andersen added a comment -

                Index: ExpressPublishMethod.java
                ===================================================================
                — ExpressPublishMethod.java (revision 35895)
                +++ ExpressPublishMethod.java (working copy)
                @@ -87,7 +87,7 @@
                int response = messageBox.open();
                if (response == SWT.YES)
                b[0] = true;

                • b[1] = false;
                  + b[0] = false;
                  }
                  });
                  return b[0];
                Show
                maxandersen Max Rydahl Andersen added a comment - Index: ExpressPublishMethod.java =================================================================== — ExpressPublishMethod.java (revision 35895) +++ ExpressPublishMethod.java (working copy) @@ -87,7 +87,7 @@ int response = messageBox.open(); if (response == SWT.YES) b [0] = true; b [1] = false; + b [0] = false; } }); return b [0] ;
                Hide
                Permalink
                maxandersen Max Rydahl Andersen added a comment -

                fixed in branch M4, created JBIDE-10003 for trunk since I ran out of diskspace for checkout ;(

                Show
                maxandersen Max Rydahl Andersen added a comment - fixed in branch M4, created JBIDE-10003 for trunk since I ran out of diskspace for checkout ;(
                Hide
                Permalink
                rob.stryker Rob Stryker added a comment -

                By fixing the NPE, you inadvertantly added a publishing error. Had a proper patch been attached, I might have noticed this as soon as you linked me to the issue, but it was a bit hard to understand pasted into the comment.

                Previously, the b[1] assignment caused an NPE, which left the return value as true. In the current code, the b[0] = true is followed directly by a b[0] = false, so the return for this method is always false.

                Show
                rob.stryker Rob Stryker added a comment - By fixing the NPE, you inadvertantly added a publishing error. Had a proper patch been attached, I might have noticed this as soon as you linked me to the issue, but it was a bit hard to understand pasted into the comment. Previously, the b [1] assignment caused an NPE, which left the return value as true. In the current code, the b [0] = true is followed directly by a b [0] = false, so the return for this method is always false.
                Hide
                Permalink
                rob.stryker Rob Stryker added a comment -

                fixed it

                Show
                rob.stryker Rob Stryker added a comment - fixed it
                Hide
                Permalink
                psrna Pavol Srna added a comment -

                Verified on jbosstools-3.3_stable_branch.aggregate-Update-2011-10-27_16-13-53-H37.

                Show
                psrna Pavol Srna added a comment - Verified on jbosstools-3.3_stable_branch.aggregate-Update-2011-10-27_16-13-53-H37.

                  People

                  • Assignee:
                    maxandersen Max Rydahl Andersen
                    Reporter:
                    maxandersen Max Rydahl Andersen
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Development