Loading...

Details

Type: Bug
Resolution: Done
Priority: Major
Fix Version/s: 1.0.2.Final
Affects Version/s: 1.0.1.CR2
Component/s: jberet-core
Labels:
None

Steps to Reproduce:

Hide

Sorry, I don't have any sample projects to reproduce yet. because it's multi-thread issue so hard to create.

Show
Sorry, I don't have any sample projects to reproduce yet. because it's multi-thread issue so hard to create.
Forum Reference:
https://community.jboss.org/message/866768#866768

Description

I guess that current implementations of JobExecution and same kind of classes are seems partly not thread-safe. they have ArrayList fields to hold instances and sometimes it bring ConcurrentModificationException unexpectedly.

For instance, I guess it occurs when JobExecutionImpl#addStepExecution() invoked during serialization of JobExecution. this might be a problem when we use JobOperator through remote EJB invocation.

I guess the below might be a solution:

1. Mark these fields as transient
2. Create immutable instance before return
3. Change ArrayList to CopyOnWriteArrayList

Personally, I made a facade class of JobOperator and return a defensive copy of JobInstance, JobExecution etc to the caller.

Original thread: https://community.jboss.org/thread/239533

Exception:

2014-04-04 22:02:34,130 WARN  [org.jberet] (batch-batch - 15) JBERET000001: Failed to run batchlet org.jberet.job.model.RefArtifact@69b35c3f: java.lang.RuntimeException: JBAS014154: Failed to marshal EJB parameters  
        at org.jboss.as.ejb3.remote.LocalEjbReceiver.clone(LocalEjbReceiver.java:291) [wildfly-ejb3-8.0.0.Final.jar:8.0.0.Final]  
        at org.jboss.as.ejb3.remote.LocalEjbReceiver.clone(LocalEjbReceiver.java:280) [wildfly-ejb3-8.0.0.Final.jar:8.0.0.Final]  
        at org.jboss.as.ejb3.remote.LocalEjbReceiver.processInvocation(LocalEjbReceiver.java:252) [wildfly-ejb3-8.0.0.Final.jar:8.0.0.Final]  
        at org.jboss.ejb.client.EJBClientInvocationContext.sendRequest(EJBClientInvocationContext.java:181) [jboss-ejb-client-2.0.0.Final.jar:2.0.0.Final]  
        at org.jboss.ejb.client.EJBObjectInterceptor.handleInvocation(EJBObjectInterceptor.java:58) [jboss-ejb-client-2.0.0.Final.jar:2.0.0.Final]  
        at org.jboss.ejb.client.EJBClientInvocationContext.sendRequest(EJBClientInvocationContext.java:183) [jboss-ejb-client-2.0.0.Final.jar:2.0.0.Final]  
        at org.jboss.ejb.client.EJBHomeInterceptor.handleInvocation(EJBHomeInterceptor.java:83) [jboss-ejb-client-2.0.0.Final.jar:2.0.0.Final]  
        at org.jboss.ejb.client.EJBClientInvocationContext.sendRequest(EJBClientInvocationContext.java:183) [jboss-ejb-client-2.0.0.Final.jar:2.0.0.Final]  
        at org.jboss.ejb.client.TransactionInterceptor.handleInvocation(TransactionInterceptor.java:42) [jboss-ejb-client-2.0.0.Final.jar:2.0.0.Final]  
        at org.jboss.ejb.client.EJBClientInvocationContext.sendRequest(EJBClientInvocationContext.java:183) [jboss-ejb-client-2.0.0.Final.jar:2.0.0.Final]  
        at org.jboss.ejb.client.ReceiverInterceptor.handleInvocation(ReceiverInterceptor.java:125) [jboss-ejb-client-2.0.0.Final.jar:2.0.0.Final]  
        at org.jboss.ejb.client.EJBClientInvocationContext.sendRequest(EJBClientInvocationContext.java:183) [jboss-ejb-client-2.0.0.Final.jar:2.0.0.Final]  
        at org.jboss.ejb.client.EJBInvocationHandler.sendRequestWithPossibleRetries(EJBInvocationHandler.java:253) [jboss-ejb-client-2.0.0.Final.jar:2.0.0.Final]  
        at org.jboss.ejb.client.EJBInvocationHandler.doInvoke(EJBInvocationHandler.java:198) [jboss-ejb-client-2.0.0.Final.jar:2.0.0.Final]  
        at org.jboss.ejb.client.EJBInvocationHandler.doInvoke(EJBInvocationHandler.java:181) [jboss-ejb-client-2.0.0.Final.jar:2.0.0.Final]  
        at org.jboss.ejb.client.EJBInvocationHandler.invoke(EJBInvocationHandler.java:144) [jboss-ejb-client-2.0.0.Final.jar:2.0.0.Final]  
        at com.sun.proxy.$Proxy87.getJobExecution(Unknown Source)  
        at org.nailedtothex.stock.common.util.JobUtil.waitForFinish(JobUtil.java:21) [stock-common-1.0-SNAPSHOT.jar:]  
        at org.nailedtothex.stock.batch.common.batchlet.JobLaunchBatchlet.waitForFinish(JobLaunchBatchlet.java:87) [stock-batch-1.0-SNAPSHOT.jar:]  
        at org.nailedtothex.stock.batch.common.batchlet.JobLaunchBatchlet.process(JobLaunchBatchlet.java:60) [stock-batch-1.0-SNAPSHOT.jar:]  
        at org.jberet.runtime.runner.BatchletRunner.run(BatchletRunner.java:61) [jberet-core-1.0.1.CR2-SNAPSHOT.jar:1.0.1.CR2-SNAPSHOT]  
        at org.jberet.runtime.runner.StepExecutionRunner.runBatchletOrChunk(StepExecutionRunner.java:207) [jberet-core-1.0.1.CR2-SNAPSHOT.jar:1.0.1.CR2-SNAPSHOT]  
        at org.jberet.runtime.runner.StepExecutionRunner.run(StepExecutionRunner.java:131) [jberet-core-1.0.1.CR2-SNAPSHOT.jar:1.0.1.CR2-SNAPSHOT]  
        at org.jberet.runtime.runner.CompositeExecutionRunner.runStep(CompositeExecutionRunner.java:162) [jberet-core-1.0.1.CR2-SNAPSHOT.jar:1.0.1.CR2-SNAPSHOT]  
        at org.jberet.runtime.runner.CompositeExecutionRunner.runFromHeadOrRestartPoint(CompositeExecutionRunner.java:88) [jberet-core-1.0.1.CR2-SNAPSHOT.jar:1.0.1.CR2-SNAPSHOT]  
        at org.jberet.runtime.runner.JobExecutionRunner.run(JobExecutionRunner.java:58) [jberet-core-1.0.1.CR2-SNAPSHOT.jar:1.0.1.CR2-SNAPSHOT]  
        at org.wildfly.jberet.services.BatchEnvironmentService$WildFlyBatchEnvironment$1.run(BatchEnvironmentService.java:149) [wildfly-jberet-8.0.0.Final.jar:8.0.0.Final]  
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) [rt.jar:1.7.0_51]  
        at java.util.concurrent.FutureTask.run(FutureTask.java:262) [rt.jar:1.7.0_51]  
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) [rt.jar:1.7.0_51]  
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) [rt.jar:1.7.0_51]  
        at java.lang.Thread.run(Thread.java:744) [rt.jar:1.7.0_51]  
        at org.jboss.threads.JBossThread.run(JBossThread.java:122)  
Caused by: java.util.ConcurrentModificationException  
        at java.util.ArrayList.writeObject(ArrayList.java:746) [rt.jar:1.7.0_51]  
        at sun.reflect.GeneratedMethodAccessor29.invoke(Unknown Source) [:1.7.0_51]  
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [rt.jar:1.7.0_51]  
        at java.lang.reflect.Method.invoke(Method.java:606) [rt.jar:1.7.0_51]  
        at org.jboss.marshalling.reflect.SerializableClass.callWriteObject(SerializableClass.java:275)  
        at org.jboss.marshalling.cloner.SerializingCloner.initSerializableClone(SerializingCloner.java:294)  
        at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:249)  
        at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:129)  
        at org.jboss.marshalling.cloner.SerializingCloner.cloneFields(SerializingCloner.java:345)  
        at org.jboss.marshalling.cloner.SerializingCloner.initSerializableClone(SerializingCloner.java:305)  
        at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:249)  
        at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:129)  
        at org.jboss.as.ejb3.remote.LocalEjbReceiver.clone(LocalEjbReceiver.java:289) [wildfly-ejb3-8.0.0.Final.jar:8.0.0.Final]  
        ... 32 more

ConcurrentModificationException at JobOperator#getJobExecution()

Details

Description

Attachments

Activity

People

Dates