Uploaded image for project: 'JBoss Enterprise Portal Platform'
  1. JBoss Enterprise Portal Platform
  2. JBEPP-1195

Log level improvement in FallbackIdentityStoreRepository class (PicketLink IDM)

    Details

    • Type: Enhancement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Migrated to another ITS
    • Affects Version/s: 5.1.0.GA
    • Fix Version/s: 5.2.1.GA
    • Component/s: None
    • Labels:
      None
    • Release Notes Docs Status:
      Not Yet Documented
    • NEEDINFO:
      Nobody

      Description

      org.picketlink.idm.impl.repository.FallbackIdentityStoreRepository doesn't throw an ERROR exception when a ldap connection has timed out.

      To see that exception user needs to enable the INFO logging to "org.picketlink" category, then it prints the failed connection attempt successfully.

      2011-09-19 11:54:44,315 INFO [org.picketlink.idm.impl.repository.FallbackIdentityStoreRepository] (main) Failed to create IdentityObject:
      org.picketlink.idm.common.exception.IdentityException: Could not obtain LDAP connection:

      Caused by: javax.naming.CommunicationException: [host]:[port] [Root exception is java.net.SocketTimeoutException: connect timed out]

      This enhancement is to change the log level of from INFO to ERROR and to improve the log messages in

      ./picketlink-idm/picketlink-idm-core/src/main/java/org/picketlink/idm/impl/repository/FallbackIdentityStoreRepository.java

      Instead of using INFO it would be easier to see the issue with an ERROR log level.

      Here is an example of log to be improved/changed to ERROR:

      try

      { [source] }

      catch (IdentityException e)
      {
      if (log.isLoggable(Level.INFO))

      { log.log(Level.INFO, "Failed to create IdentityObject: ", e); }

      }

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                mposolda Marek Posolda
                Reporter:
                bmachado Bruno Machado
              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: