Uploaded image for project: 'JBoss Enterprise Application Platform'
  1. JBoss Enterprise Application Platform
  2. JBEAP-17601

[GSS](7.2.z) UNDERTOW-1595 - NullPointerException can happen on a range request for a static content

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Major
    • 7.2.6.CR1, 7.2.6.GA
    • 7.2.3.GA
    • Undertow
    • None
    • +
    • Hide

      1. Create enough size of static content which is larger than the buffer size (16 KiB = 16384 Bytes by default)

      base64 /dev/urandom | head -c 1024000 > $JBOSS_HOME/welcome-content/test.txt

      2. Start JBoss EAP with the following byteman rule which just sleep before writing a response.
      This rule can make a client easy to similate an abrupt connection close.

      RULE sleep_at_AsyncSenderImpl_send
CLASS io.undertow.io.AsyncSenderImpl
METHOD send
AT ENTRY
IF TRUE
DO
    # traceStack("------- io.undertow.io.AsyncSenderImpl#send() -------\n");
    traceln("------- sleeping... -------");
    delay(10000L);
    traceln("------- sleep done! -------");
ENDRULE

      3. Execute the following curl command to send a range request, then stop with "Ctrl-C" while the server sleep by the byteman rule 

      curl -v -r 0-16384 http://localhost:8080/test.txt

      Then, you will see NullPointerException in the server.log at the end of request processing.

      Note:

      • The range size should be larger than the buffer size (16 KiB = 16384 Bytes by default).
      • As IOException need to happen during sending the last part of the range response, the range size should be between "0-16384" ~ "0-32767" to reproduce the issue by stopping the curl command during the 1st sleep.
      Show
      1. Create enough size of static content which is larger than the buffer size (16 KiB = 16384 Bytes by default) base64 /dev/urandom | head -c 1024000 > $JBOSS_HOME/welcome-content/test.txt 2. Start JBoss EAP with the following byteman rule which just sleep before writing a response. This rule can make a client easy to similate an abrupt connection close. RULE sleep_at_AsyncSenderImpl_send CLASS io.undertow.io.AsyncSenderImpl METHOD send AT ENTRY IF TRUE DO # traceStack( "------- io.undertow.io.AsyncSenderImpl#send() -------\n" ); traceln( "------- sleeping... -------" ); delay(10000L); traceln( "------- sleep done! -------" ); ENDRULE 3. Execute the following curl command to send a range request, then stop with "Ctrl-C" while the server sleep by the byteman rule curl -v -r 0-16384 http: //localhost:8080/test.txt Then, you will see NullPointerException in the server.log at the end of request processing. Note: The range size should be larger than the buffer size (16 KiB = 16384 Bytes by default). As IOException need to happen during sending the last part of the range response, the range size should be between "0-16384" ~ "0-32767" to reproduce the issue by stopping the curl command during the 1st sleep.

    Description

      NullPointerException can happen on the range request for a static content. This happens if the following conditions are met:

      • A size of Range request is larger than the buffer size (16 KiB = 16384 Bytes by default)
      • IOException (DEBUG level logging on io.undertow.request.io) occurs during sending the last part of the range response
        (for example, a client browser close the connection or a front-end proxy closed the connection due to timeout)
      ERROR [io.undertow.request] (default task-1) UT005071: Undertow request failed HttpServerExchange{ GET /test.txt}: java.lang.NullPointerException
	at io.undertow.server.handlers.resource.PathResource$1ServerTask.run(PathResource.java:156)
	at io.undertow.server.handlers.resource.PathResource$1ServerTask.onComplete(PathResource.java:200)
	at io.undertow.io.AsyncSenderImpl.invokeOnComplete(AsyncSenderImpl.java:413)
	at io.undertow.io.AsyncSenderImpl.send(AsyncSenderImpl.java:173)
	at io.undertow.server.handlers.resource.PathResource$1ServerTask.run(PathResource.java:187)
	at io.undertow.server.handlers.resource.PathResource.serveImpl(PathResource.java:256)
	at io.undertow.server.handlers.resource.PathResource.serveRange(PathResource.java:118)
	at io.undertow.server.handlers.resource.ResourceHandler$1.handleRequest(ResourceHandler.java:335)
	at io.undertow.server.Connectors.executeRootHandler(Connectors.java:376)
	at io.undertow.server.HttpServerExchange$1.run(HttpServerExchange.java:830)
	at org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
	at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1985)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1487)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1349)
	at java.lang.Thread.run(Thread.java:748)

      It seems this NPE is harmless because the connection is already closed and no bad side effects happen to the response anymore. However, of course, it's better to avoid NPE.

      Attachments

        Issue Links

          clones

          Bug - A problem that impairs or prevents the functions of the product. JBEAP-17859 [GSS](7.3.z) UNDERTOW-1595 - NullPointerException can happen on a range request for a static content

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Verified
          is incorporated by

          Component Upgrade - A task tracking an update to a bundled component or revision of component upstream of the project. JBEAP-17773 [GSS](7.2.z) Upgrade Undertow from 2.0.26.SP3-redhat-00001 to 2.0.28.SP1

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed
          links to

          Web Link KCS#4500131

          Activity

            People

              spyrkob Bartosz Spyrko-Smietanko
              rhn-support-mmiura Masafumi Miura
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: