CMP performs unnecessary check for PK existance in ejbCreate

SourceForge Submitter: sreich .
Just wanted to make sure this doesn't fall through the cracks.

From: Dain Sundstrom <dain@daingroup.com>
Subject: Re: Re[2]: [jboss-cvs] jboss/src/main/org/jboss/ejb/plugins/
cmp/jdbc JDBCInsertRelationsCommand.java
Date: Tuesday, April 1, 2003 11:57:29 AM US/Pacific
To: Stefan Reich <sreich@apple.com>
Cc: Jeremy Boynes <jeremy@boynes.com>, Alexey Loubyansky
<alex@jboss.org>

On Tuesday, April 1, 2003, at 01:52 PM, Stefan Reich wrote:

Should I file an enhancement request for it? It would be nice to have it
in 3.2, I personally don't think features like this should go into the 3.0
branch at this point.

Cheers,
Stefan
On Friday, Mar 28, 2003, at 13:41 US/Pacific, Alexey Loubyansky
wrote:

BTW, just today I had a complain from our customer about this check.
It occured it required about 100ms and was the longest operation that
made performance significantly worse.

So, I would agree to make it optional. What about to do it in 3.0
branch?

alex

Friday, March 28, 2003, 10:41:26 PM, Dain Sundstrom wrote:

DS> Stefan,

DS> We have has the create check issue for a long time. I actually
thought
DS> we were required to throw the DuplicateKeyException, but now
that I
DS> look at the spec it says it is completely optional. I guess we can
DS> 'legally' completely remove the check. Does any one have an
objection
DS> to completely removing the check (alternative we could make it
DS> optional).

DS> -dain

DS> On Friday, March 28, 2003, at 01:22 PM, Stefan Reich wrote:

Hi Dain,

[...]
Another thing I noticed is that there is no way to turn off the check
for existence in JDBCCreateEntity, which I believe is unnecessary:
every ejbCreate has to pay the additional roundtrip to the database
just to avoid getting an SQLException.