DataSource metadata is incomplete/wrong

SourceForge Submitter: ejort .
The DataSource metadata processing is incomplete/wrong.

1) The MBean does not belong in the JBoss JDBC resource
adapter.

This should neither depend on JMX or CMP.

I already have TODOs to remove the current dependencies
that have crept in so this RAR can be used outside of
the jboss server.

Besides, it is possible for db vendors to provide their
own resource adapters (cf Firebird) and this service
should still work.

If it belongs anywhere in the connector module (which I
don't think it does) it should be in a top level directory.

The created service is logically associated with the
connection factory deployment rather than the resource
adapter deployment anyway.

2) The metadata/typemapping is not documented in
jboss-ds-1_5.dtd

Additionally, the whole point of this file is to have a
flat namespace, why the metadata/typemapping?
There are plans to replace this config with a
programmatic javabean
style deployment.
I'm not sure how you fix this now it has been released
in 4.0.0

When I agreed to this, I said I didn't mind the -ds.xml
deployer creating the MBean, it is the obvious place to
put this configuration. But I said the implementation
should be elsewhere, i.e. in the server module (because
it uses the CMP metadata) or whatever jdbc abstraction
project is created in the future.

The service is used by the consumer of the DataSource
not the DataSource or the connection factory deployment.