Uploaded image for project: 'Infinispan'
  1. Infinispan
  2. ISPN-7863

Ickle lexer wrongly discards letter v as whitespace ruining parsing of identifiers containing v

    XMLWordPrintable

Details

    Description

      Links to: https://issues.jboss.org/browse/ISPN-7861

      When quering ISPN server over hotrod and trying to access field which begins with "v" character that field access is lost but together with "group by" operator.

      Example of entity using proto/annotations:

      @ProtoDoc("@Indexed")
public class Offering implements Serializable {

	private String name;
	private Integer relationSetId;
	private Integer variant;
	
	@ProtoDoc("@Field(store = Store.YES, analyze = Analyze.YES)")
    @ProtoField(number = 5, required = true)
    public String getName() {
        return name;
    }

    public void setName(String name) {
        this.name = name;
    }
		
	@ProtoField(number = 44)
    public Integer getRelationSetId() {
        return relationSetId;
    }

    public void setRelationSetId(Integer relationSetId) {
        this.relationSetId = relationSetId;
    }
	
	@ProtoDoc("@Field(store = Store.YES, analyze = Analyze.NO)")
    @ProtoField(number = 50)
    public Integer getVariant() {
        return variant;
    }

    public void setVariant(Integer variant) {
        this.variant = variant;
    }
	
}

      Then executing query like this:

      select min(_gen0.name),min(_gen0.variant) FROM Offering _gen0  WHERE _gen0.variant = 44 GROUP BY _gen0.relationSetId

      Produces server side error which mentions "ariant" - v - is lost. Paste is below.

      NOT using group by is causing that query to run well.
      ALSO Changing variable name from variant to "bariant" helps.
      LOOKS like there is some code which restricts the name or parses wrongly.

      Affects not only simple type fields but also List<Variant> variants - "v" is lost.

      log

      14:02:50,951 DEBUG [org.infinispan.query.dsl.embedded.impl.QueryEngine] (HotRod-ServerHandler-6-16) Building query 'select min(_gen0.name),min(_gen0.variant) FROM Offering _gen0 WHERE _gen0.variant = 44 GROUP BY _gen0.relationSetId' with parameters null
      14:02:50,953 DEBUG [org.infinispan.server.hotrod.HotRodExceptionHandler] (HotRod-ServerWorker-4-1) Exception caught: org.infinispan.objectfilter.ParsingException: ISPN028501: The type Offering has no property named 'ariant'.
      at org.infinispan.objectfilter.impl.syntax.parser.QueryResolverDelegateImpl.normalizeProperty(QueryResolverDelegateImpl.java:191)
      at org.infinispan.objectfilter.impl.syntax.parser.QueryResolverDelegateImpl.normalizeUnqualifiedPropertyReference(QueryResolverDelegateImpl.java:84)
      at org.infinispan.objectfilter.impl.ql.parse.QueryResolver.unqualifiedPropertyReference(QueryResolver.java:7651)
      at org.infinispan.objectfilter.impl.ql.parse.QueryResolver.propertyReferencePath(QueryResolver.java:7548)
      at org.infinispan.objectfilter.impl.ql.parse.QueryResolver.propertyReferenceExpression(QueryResolver.java:5689)
      at org.infinispan.objectfilter.impl.ql.parse.QueryResolver.valueExpressionPrimary(QueryResolver.java:5495)
      at org.infinispan.objectfilter.impl.ql.parse.QueryResolver.valueExpression(QueryResolver.java:5271)
      at org.infinispan.objectfilter.impl.ql.parse.QueryResolver.rowValueConstructor(QueryResolver.java:4490)
      at org.infinispan.objectfilter.impl.ql.parse.QueryResolver.predicate(QueryResolver.java:3326)
      at org.infinispan.objectfilter.impl.ql.parse.QueryResolver.searchCondition(QueryResolver.java:2979)
      at org.infinispan.objectfilter.impl.ql.parse.QueryResolver.whereClause(QueryResolver.java:655)
      at org.infinispan.objectfilter.impl.ql.parse.QueryResolver.querySpec(QueryResolver.java:510)
      at org.infinispan.objectfilter.impl.ql.parse.QueryResolver.queryStatement(QueryResolver.java:379)
      at org.infinispan.objectfilter.impl.ql.parse.QueryResolver.queryStatementSet(QueryResolver.java:292)
      at org.infinispan.objectfilter.impl.ql.parse.QueryResolver.statement(QueryResolver.java:220)
      at org.infinispan.objectfilter.impl.ql.QueryParser.resolve(QueryParser.java:81)
      at org.infinispan.objectfilter.impl.ql.QueryParser.parseQuery(QueryParser.java:69)
      at org.infinispan.objectfilter.impl.syntax.parser.IckleParser.parse(IckleParser.java:19)
      at org.infinispan.query.dsl.embedded.impl.QueryEngine.lambda$parse$1(QueryEngine.java:663)
      at org.infinispan.query.dsl.embedded.impl.QueryCache.lambda$get$0(QueryCache.java:79)
      at org.infinispan.cache.impl.TypeConverterDelegatingAdvancedCache.lambda$convertFunction$1(TypeConverterDelegatingAdvancedCache.java:101)
      at java.util.concurrent.ConcurrentMap.computeIfAbsent(ConcurrentMap.java:324)
      at org.infinispan.cache.impl.AbstractDelegatingCache.computeIfAbsent(AbstractDelegatingCache.java:343)
      at org.infinispan.cache.impl.TypeConverterDelegatingAdvancedCache.computeIfAbsent(TypeConverterDelegatingAdvancedCache.java:161)
      at org.infinispan.query.dsl.embedded.impl.QueryCache.get(QueryCache.java:79)
      at org.infinispan.query.dsl.embedded.impl.QueryEngine.parse(QueryEngine.java:663)
      at org.infinispan.query.dsl.embedded.impl.QueryEngine.buildQueryWithAggregations(QueryEngine.java:299)
      at org.infinispan.query.dsl.embedded.impl.QueryEngine.buildQuery(QueryEngine.java:139)
      at org.infinispan.query.dsl.embedded.impl.DelegatingQuery.createQuery(DelegatingQuery.java:91)
      at org.infinispan.query.dsl.embedded.impl.DelegatingQuery.list(DelegatingQuery.java:98)
      at org.infinispan.query.remote.impl.QueryFacadeImpl.makeResponse(QueryFacadeImpl.java:61)
      at org.infinispan.query.remote.impl.QueryFacadeImpl.query(QueryFacadeImpl.java:53)
      at org.infinispan.server.hotrod.HotRodServer.query(HotRodServer.java:116)
      at org.infinispan.server.hotrod.ContextHandler.realRead(ContextHandler.java:148)
      at org.infinispan.server.hotrod.ContextHandler.lambda$null$0(ContextHandler.java:59)
      at org.infinispan.security.Security.doAs(Security.java:143)
      at org.infinispan.server.hotrod.ContextHandler.lambda$channelRead0$1(ContextHandler.java:58)
      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
      at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
      at java.lang.Thread.run(Thread.java:748)

      Attachments

        Issue Links

          causes

          Bug - A problem that impairs or prevents the functions of the product. TEIID-5150 JDG source model with 'v' letter at beginning of a name doesn't work.

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Resolved
          is cloned by

          Bug - A problem that impairs or prevents the functions of the product. JBEAP-16209 (7.2.z) ISPN-7863 - Ickle lexer wrongly discards letter v as whitespace ruining parsing of identifiers containing v

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Verified
          is duplicated by

          Bug - A problem that impairs or prevents the functions of the product. JDG-1956 Ickle query ignores 'v' chars at start of property name

          • Critical - To be worked on immediately following BLOCKER issues.
          • Closed
          relates to

          Bug - A problem that impairs or prevents the functions of the product. ISPN-7861 ISPN028502: Unknown alias - when Group By with advanced where clause

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Activity

            People

              anistor Adrian Nistor (Inactive)
              gregory.orciuch Gregory Orciuch (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: