Uploaded image for project: 'Infinispan'
  1. Infinispan
  2. ISPN-7556

Decoder2x.readOptionalParams should not call markReaderIndex()

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 9.0.0.CR2
    • Fix Version/s: 9.0.0.CR3
    • Component/s: Server
    • Labels:
      None

      Description

      Decoder2x.readOptionalParams() calls buffer.markReaderIndex() after reading each parameter, but doesn't save the parameters anywhere. That means if the buffer doesn't contain all the parameters, the decode pass ends unsuccessfully, and the next decode pass doesn't see the parameters read by the previous pass.

      Higher-level methods like Decoder2x.readMaybeNamedFactory() also call readOptionalParams() without saving their own state first, meaning their state can be lost as well.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                dan.berindei Dan Berindei
                Reporter:
                dan.berindei Dan Berindei
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: