Uploaded image for project: 'Infinispan'
  1. Infinispan
  2. ISPN-6045

TransactionAwareKeyCloseableIterator.remove uses previousValue which is never set

    XMLWordPrintable

Details

    Description

      TransactionAwareKeyCloseableIterator.remove is implemented as

      cache.remove(previousValue);

      But looking at the previousValue it never gets set. This results then in 

      java.lang.NullPointerException: Null keys are not supported!
	at org.infinispan.cache.impl.CacheImpl.assertKeyNotNull(CacheImpl.java:224)
	at org.infinispan.cache.impl.CacheImpl.remove(CacheImpl.java:547)
	at org.infinispan.cache.impl.CacheImpl.remove(CacheImpl.java:543)
	at org.infinispan.interceptors.TxInterceptor$TransactionAwareKeyCloseableIterator.remove(TxInterceptor.java:568)

      I encountered this when trying to switch infinispan from 7.2 to 8.1 in conjunction with hibernate-infinispan 4.3 which does the following code to clear the cache:

      	public static void removeAll(AdvancedCache cache) {
		try {
			Iterator it = cache.keySet().iterator();
			while (it.hasNext()) {
				it.next(); // Necessary to get next element
				it.remove();
				}
		} catch (UnsupportedOperationException e) {
			// Fallback on using clear for older version
			cache.clear();
		}
	}

      from https://github.com/hibernate/hibernate-orm/blob/4.3/hibernate-infinispan/src/main/java/org/hibernate/cache/infinispan/util/Caches.java

      Attachments

        Issue Links

          is cloned by

          Bug - A problem that impairs or prevents the functions of the product. JBEAP-6987 (7.0.z) ISPN-6045 - TransactionAwareKeyCloseableIterator.remove uses previousValue which is never set

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Verified

          Bug - A problem that impairs or prevents the functions of the product. JDG-528 TransactionAwareKeyCloseableIterator.remove uses previousValue which is never set

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed
          is incorporated by

          Bug - A problem that impairs or prevents the functions of the product. JBEAP-6987 (7.0.z) ISPN-6045 - TransactionAwareKeyCloseableIterator.remove uses previousValue which is never set

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Verified

          Activity

            People

              wburns@redhat.com Will Burns
              tarioch Patrick Ruckstuhl (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: