Uploaded image for project: 'Infinispan'
  1. Infinispan
  2. ISPN-4144

Cleanly shutdown intermediate M/R cache

This issue belongs to an archived project. You can view it, but you can't modify it. Learn more

    • Icon: Enhancement Enhancement
    • Resolution: Obsolete
    • Icon: Major Major
    • None
    • None
    • Clustered Executor, Core
    • None

      For intermediate per task caches we simply remove that cache from cache manager. This operation is cluster wide but it still triggers rebalancing which in turn possibly creates logs that might raise false alarms for admins. Investigate if calling clear before removing cache from cache manager and/or disabling rebalancing for intermediate cache leads to a "cleaner" cache shutdown.

            [ISPN-4144] Cleanly shutdown intermediate M/R cache

            Will Burns added a comment -

            Map/Reduce has been removed

            Will Burns added a comment - Map/Reduce has been removed

            The PR got rejected by dberinde@redhat.com for not being complete and rightly so. I am still consulting with him regarding this rebalancing per cache switch.

            Vladimir Blagojevic (Inactive) added a comment - The PR got rejected by dberinde@redhat.com for not being complete and rightly so. I am still consulting with him regarding this rebalancing per cache switch.

            Alan Field added a comment -

            The PR for this JIRA removed the clear call: https://issues.jboss.org/browse/ISPN-3352

            Alan Field added a comment - The PR for this JIRA removed the clear call: https://issues.jboss.org/browse/ISPN-3352

            Alan, good find but we can not turn off rebalancing for all caches I really believe we should have this rebalancing switch exposed to our internal code. Seems completely hidden and tucked away. Maybe for a reason. Will ask on the dev list.

            Vladimir Blagojevic (Inactive) added a comment - Alan, good find but we can not turn off rebalancing for all caches I really believe we should have this rebalancing switch exposed to our internal code. Seems completely hidden and tucked away. Maybe for a reason. Will ask on the dev list.

            Alan Field added a comment -

            From looking at DefaultRebalancePolicy.setRebalancingEnabled, it looks like rebalance is enabled or disabled for all caches:

            https://github.com/infinispan/infinispan/blob/master/core/src/main/java/org/infinispan/topology/DefaultRebalancePolicy.java#L87

            Alan Field added a comment - From looking at DefaultRebalancePolicy.setRebalancingEnabled, it looks like rebalance is enabled or disabled for all caches: https://github.com/infinispan/infinispan/blob/master/core/src/main/java/org/infinispan/topology/DefaultRebalancePolicy.java#L87

            Ok, I was recommend on our IRC chat that clear() would do what I wanted. There is a way to disable rebalancing but that call is only available through JMX which is ok I guess but it is weird to call system internal function through JMX. dberinde@redhat.com how can we call LocalTopologyManagerImpl#setRebalancingEnabled as this method is not available through LocalTopologyManager interface or should we even do it to being with? What are you suggestions here?

            Vladimir Blagojevic (Inactive) added a comment - - edited Ok, I was recommend on our IRC chat that clear() would do what I wanted. There is a way to disable rebalancing but that call is only available through JMX which is ok I guess but it is weird to call system internal function through JMX. dberinde@redhat.com how can we call LocalTopologyManagerImpl#setRebalancingEnabled as this method is not available through LocalTopologyManager interface or should we even do it to being with? What are you suggestions here?

            1) I wouldn't call clear, this operation has to lock all entries and this would most certainly cause slow down
            2) Clear wouldn't get rid of the logs: if one node is not shut down yet and the others already are (and the rebalance is triggered), this node becomes owner of some new segments. Then it finds that there is no live owner of these segments and logs the warning. See, it's all about segment ownership, not entries.

            I am not sure whether the ability to disable rebalance is currently implemented cache-wise or globally - if the latter is the case, we should probably consider more fine-grained operation.

            Radim Vansa (Inactive) added a comment - 1) I wouldn't call clear, this operation has to lock all entries and this would most certainly cause slow down 2) Clear wouldn't get rid of the logs: if one node is not shut down yet and the others already are (and the rebalance is triggered), this node becomes owner of some new segments . Then it finds that there is no live owner of these segments and logs the warning. See, it's all about segment ownership, not entries. I am not sure whether the ability to disable rebalance is currently implemented cache-wise or globally - if the latter is the case, we should probably consider more fine-grained operation.

              dberinde@redhat.com Dan Berindei (Inactive)
              vblagoje Vladimir Blagojevic (Inactive)
              Archiver:
              rhn-support-adongare Amol Dongare

                Created:
                Updated:
                Resolved:
                Archived: