Uploaded image for project: 'Infinispan'
  1. Infinispan
  2. ISPN-1215

OverrideConfigurationVisitor implementation is incomplete

    XMLWordPrintable

Details

    • Workaround Exists
    • Hide

      Add this method to OverrideConfigurationVisitor

       
@Override
public void visitDataContainerType(DataContainerType config) {

    this.dataContainerType = config;
    this.dataContainerType.overriddenConfigurationElements.add("dataContainer");
}

      and define class member:

      private DataContainerType dataContainerType = null;

      This will make DataContainer config overriding possible but for all other configs you better check the code. It seems that it is broken.

      Show
      Add this method to OverrideConfigurationVisitor @Override public void visitDataContainerType(DataContainerType config) { this .dataContainerType = config; this .dataContainerType.overriddenConfigurationElements.add( "dataContainer" ); } and define class member: private DataContainerType dataContainerType = null ; This will make DataContainer config overriding possible but for all other configs you better check the code. It seems that it is broken.

    Description

      OK, I found this issue while working on integration of OffHeap data storage into ISPN 5.0. There is no way to override dataContainer settings in ISPN 5.0 CR6 as since OverrideConfigurationVisitor which extends AbstractConfigurationBeanVisitor does not implement

      public void visitDataContainerType(DataContainerType bean)

      method.

      I fixed the particular issue and fix is described here: http://community.jboss.org/thread/167641?start=15&tstart=0
      Btw, the whole OverrideConfigurationVisitor class looks like a template which is yet to be implemented.

      Attachments

        Activity

          People

            vblagoje Vladimir Blagojevic (Inactive)
            kodadma Vladimir Rodionov (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: