Uploaded image for project: 'Infinispan'
  1. Infinispan
  2. ISPN-1006

During Lifecycle method cacheStopped is missing some components from the registry

This issue belongs to an archived project. You can view it, but you can't modify it. Learn more

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Do
    • Icon: Major Major
    • None
    • None
    • None
    • None

      To reproduce: In Query module, class org.infinispan.query.impl.LifecycleManager
      If you move the method body from cacheStopping into cacheStopped you'll notice that org.infinispan.query.blackbox.SearchFactoryShutdownTest will fail, as shutdown won't happen as it can't find the needed components in the ComponentRegistry.

            [ISPN-1006] During Lifecycle method cacheStopped is missing some components from the registry

            Sanne Grinovero (Inactive) added a comment -

            From Manik's comments I get that components might be cleaned up, so this is not an issue in Infinispan. Query can be stopped in different ways.

            Sanne Grinovero (Inactive) added a comment - From Manik's comments I get that components might be cleaned up, so this is not an issue in Infinispan. Query can be stopped in different ways.

            Sanne Grinovero (Inactive) added a comment -

            From Manik's comments I get that components might be cleaned up, so this is not an issue in Infinispan. Query can be stopped in different ways.

            Sanne Grinovero (Inactive) added a comment - From Manik's comments I get that components might be cleaned up, so this is not an issue in Infinispan. Query can be stopped in different ways.

            Manik Surtani (Inactive) added a comment -

            @Sanne what do we need to do about this?

            Manik Surtani (Inactive) added a comment - @Sanne what do we need to do about this?

            Galder Zamarreño added a comment -

            Sanne/Manik, where are we with this?

            Galder Zamarreño added a comment - Sanne/Manik, where are we with this?

            Manik Surtani (Inactive) added a comment -

            Ah yes, we renamed NonVolatile - I forgot about that.

            A cache may restart. Depending on the scope of your component (NamedCache or Global) it may be attached to the cache or cache manager.

            Manik Surtani (Inactive) added a comment - Ah yes, we renamed NonVolatile - I forgot about that. A cache may restart. Depending on the scope of your component (NamedCache or Global) it may be attached to the cache or cache manager.

            Sanne Grinovero (Inactive) added a comment -

            Draft: https://github.com/Sanne/infinispan/tree/experimentFixingQueryLifecycle
            (not to merge!)

            Sanne Grinovero (Inactive) added a comment - Draft: https://github.com/Sanne/infinispan/tree/experimentFixingQueryLifecycle (not to merge!)

            Sanne Grinovero (Inactive) added a comment -

            Hi Manik. I couldn't find @NonVolatile anywhere, so I tried @SurvivesRestarts. The shutdown works fine in this case, but I'm not sure you mean I should use it. Is a cacheManager able to restart? in that case, I should restart the service as well. Why if ever should a cachemanager restart?

            Sanne Grinovero (Inactive) added a comment - Hi Manik. I couldn't find @NonVolatile anywhere, so I tried @SurvivesRestarts. The shutdown works fine in this case, but I'm not sure you mean I should use it. Is a cacheManager able to restart? in that case, I should restart the service as well. Why if ever should a cachemanager restart?

            Manik Surtani (Inactive) added a comment -

            This is probably because the component is volatile and is cleaned up (removed from the component registry) by the time cacheStopped() is called.

            Annotate your component with @NonVolatile to prevent this from happening, but this means your component doesn't need rebuilding/reinjecting if the cache were to restart.

            Manik Surtani (Inactive) added a comment - This is probably because the component is volatile and is cleaned up (removed from the component registry) by the time cacheStopped() is called. Annotate your component with @NonVolatile to prevent this from happening, but this means your component doesn't need rebuilding/reinjecting if the cache were to restart.

              sgrinove Sanne Grinovero (Inactive)
              sgrinove Sanne Grinovero (Inactive)
              Archiver:
              rhn-support-adongare Amol Dongare

                Created:
                Updated:
                Resolved:
                Archived: