Uploaded image for project: 'Immutant'
  1. Immutant
  2. IMMUTANT-259

improperly named test ns causes stack overflow

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Labels:
      None

      Description

      If a test file contains the same ns name as a file under src/, a stack overflow occurs, which didn't happen under 0.9.0. Discussed at: http://immutant.markmail.org/thread/3negfybve2ij73u3

      Sample app to recreate: https://github.com/r0man/immutant-stackoverflow

      It may be the case that we didn't include the test/ dir on the classpath in 0.9.0.

        Gliffy Diagrams

          Activity

          Hide
          jcrossley Jim Crossley added a comment -

          By default, because leiningen's :dev profile is active, test classes will be first in the classpath, so problems like this will manifest at deployment. Recent builds "ate" the stacktrace and hung the process, but that should be fixed now. For the included sample app (thanks!), the deploy fails with a very long stacktrace in the log/console.

          Deploying the app with a different profile will prevent the test classes from being prepended to the CP, e.g. lein with-profile prod immutant deploy

          Show
          jcrossley Jim Crossley added a comment - By default, because leiningen's :dev profile is active, test classes will be first in the classpath, so problems like this will manifest at deployment. Recent builds "ate" the stacktrace and hung the process, but that should be fixed now. For the included sample app (thanks!), the deploy fails with a very long stacktrace in the log/console. Deploying the app with a different profile will prevent the test classes from being prepended to the CP, e.g. lein with-profile prod immutant deploy

            People

            • Assignee:
              jcrossley Jim Crossley
              Reporter:
              tcrawley Toby Crawley
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development