Fix Hawkular-ui-services tests for alerts

gulp rest:alert fails with: ➜ hawkular-ui-services git:(master) gulp rest:alert [18:09:42] Requiring external module babel-core/register [18:09:46] Using gulpfile ~/projects/hawkular-ui-services/gulpfile.babel.js [18:09:46] Starting 'scripts'... [18:09:48] Finished 'scripts' after 1.54 s [18:09:48] Starting 'rest:alert'... [18:09:48] Starting Karma server... WARN `start` method is deprecated since 0.13. It will be removed in 0.14. Please use server = new Server(config, [done] ) server.start() instead. 03 02 2016 18:09:49.149:INFO [karma] : Karma v0.13.11 server started at http://localhost:9876/ 03 02 2016 18:09:49.157:INFO [launcher] : Starting browser PhantomJS 03 02 2016 18:09:49.954:INFO [PhantomJS 2.1.1 (Mac OS X 0.0.0)] : Connected on socket XjF-RiJVfU5bFx8SAAAA with id 71405470 DUMP: undefined PhantomJS 2.1.1 (Mac OS X 0.0.0) Provider: Hawkular Alerts live REST => Create a Garbage Collection Trigger should create a trigger correctly FAILED TypeError: undefined is not an object (evaluating 'created.length') in /Users/mtho11/projects/hawkular-ui-services/src/rest/hawkRest-alert-provider.spec.rest.js (line 151) /Users/mtho11/projects/hawkular-ui-services/src/rest/hawkRest-alert-provider.spec.rest.js:151:21 /Users/mtho11/projects/hawkular-ui-services/src/rest/hawkRest-alert-provider.spec.rest.js:141:20 handleCallback@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:14892:58 /Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:14720:30 processQueue@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:14745:30 /Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:14761:39 $eval@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:15989:28 $digest@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:15800:36 $apply@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:16097:31 done@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:10546:53 completeRequest@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:10744:15 requestError@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:10695:24 DUMP: 'ngResource error: {"data":null,"status":-1,"config":{"method":"POST","transformRequest": [null] ,"transformResponse": [null] ,"url":"http://localhost:8080/hawkular/alerts/triggers","data":{"id":"thevault~local-web-multiple-jvm-metrics-trigger","name":"Multiple JVM Metrics for thevault~Local","autoResolve":true,"autoResolveAlerts":true,"context": {"resourceType":"App Server","resourceName":"thevault~Local","category":"JVM"} ,"tags":{"test-trigger":"JVM"}},"params":{},"headers":{"Accept":"application/json, text/plain, / ","Authorization":"Basic amRvZTpwYXNzd29yZA==","Content-Type":"application/json;charset=utf-8"}},"statusText":""}' DUMP: 'ngResource error: "Error on Trigger save"' DUMP: 'ngResource error: "Error on Dampening save"' DUMP: undefined PhantomJS 2.1.1 (Mac OS X 0.0.0) Provider: Hawkular Alerts live REST => Create a JVM Trigger with multiple conditions should create a trigger correctly FAILED TypeError: undefined is not an object (evaluating 'created.length') in /Users/mtho11/projects/hawkular-ui-services/src/rest/hawkRest-alert-provider.spec.rest.js (line 349) /Users/mtho11/projects/hawkular-ui-services/src/rest/hawkRest-alert-provider.spec.rest.js:349:21 /Users/mtho11/projects/hawkular-ui-services/src/rest/hawkRest-alert-provider.spec.rest.js:339:17 handleCallback@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:14892:58 /Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:14720:30 processQueue@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:14745:30 /Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:14761:39 $eval@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:15989:28 $digest@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:15800:36 $apply@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:16097:31 done@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:10546:53 completeRequest@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:10744:15 requestError@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:10695:24 DUMP: 'ngResource error: {"data":null,"status":-1,"config":{"method":"PUT","transformRequest": [null] ,"transformResponse": [null] ,"url":"http://localhost:8080/hawkular/alerts/triggers/thevault~local-web-multiple-jvm-metrics-trigger/conditions/FIRING","data":[{"triggerId":"thevault~local-web-multiple-jvm-metrics-trigger","triggerMode":"FIRING","conditionSetSize":7,"conditionSetIndex":1,"type":"THRESHOLD","dataId":"thevault~local-jvm-garbage-collection-data-id","operator":"GT","threshold":1000,"context":{"description":"GC Duration","unit":"ms"}},{"triggerId":"thevault~local-web-multiple-jvm-metrics-trigger","triggerMode":"FIRING","conditionSetSize":7,"conditionSetIndex":2,"type":"RANGE","dataId":"thevault~local-jvm-heap-usage-data-id","operatorLow":"INCLUSIVE","operatorHigh":"INCLUSIVE","thresholdLow":100,"thresholdHigh":300,"inRange":true,"context":{"description":"Heap Usage","unit":"Mb"}},{"triggerId":"thevault~local-web-multiple-jvm-metrics-trigger","triggerMode":"FIRING","conditionSetSize":7,"conditionSetIndex":3,"type":"RANGE","dataId":"thevault~local-jvm-non-heap-usage-data-id","operatorLow":"INCLUSIVE","operatorHigh":"INCLUSIVE","thresholdLow":100,"thresholdHigh":200,"inRange":true,"context":{"description":"Non Heap Usage","unit":"Mb"}},{"triggerId":"thevault~local-web-multiple-jvm-metrics-trigger","triggerMode":"FIRING","conditionSetSize":7,"conditionSetIndex":4,"type":"AVAILABILITY","dataId":"thevault~local-test-availability-data-id","operator":"DOWN","context":{"description":"Availability"}},{"triggerId":"thevault~local-web-multiple-jvm-metrics-trigger","triggerMode":"FIRING","conditionSetSize":7,"conditionSetIndex":5,"type":"COMPARE","dataId":"thevault~local-test-compare-data-id","operator":"LTE","dataId2":"thevault~local-test-compare-data-id-2","data2Multiplier":0.5,"context":{"description":"Heap","description2":"Non Heap"}}, {"triggerId":"thevault~local-web-multiple-jvm-metrics-trigger","triggerMode":"FIRING","conditionSetSize":7,"conditionSetIndex":6,"type":"EXTERNAL","systemId":"TestSystemId","dataId":"thevault~local-test-external-data-id","expression":"TestExpression"} ,{"triggerId":"thevault~local-web-multiple-jvm-metrics-trigger","triggerMode":"FIRING","conditionSetSize":7,"conditionSetIndex":7,"type":"STRING","dataId":"thevault~local-test-string-data-id","operator":"STARTS_WITH","pattern":"www.","ignoreCase":false,"context":{"description":"URL"}}],"headers":{"Accept":"application/json, text/plain, / ","Authorization":"Basic amRvZTpwYXNzd29yZA==","Content-Type":"application/json;charset=utf-8"}},"statusText":""}' PhantomJS 2.1.1 (Mac OS X 0.0.0) Provider: Hawkular Alerts live REST => Modify an existing definition adding conditions should update conditions correctly FAILED TypeError: undefined is not an object (evaluating 'updatedConditions.length') in /Users/mtho11/projects/hawkular-ui-services/src/rest/hawkRest-alert-provider.spec.rest.js (line 485) /Users/mtho11/projects/hawkular-ui-services/src/rest/hawkRest-alert-provider.spec.rest.js:485:31 /Users/mtho11/projects/hawkular-ui-services/src/rest/hawkRest-alert-provider.spec.rest.js:477:15 handleCallback@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:14892:58 /Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:14720:30 processQueue@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:14745:30 /Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:14761:39 $eval@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:15989:28 $digest@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:15800:36 $apply@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:16097:31 done@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:10546:53 completeRequest@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:10744:15 requestError@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:10695:24 DUMP: 'ngResource error: {"data":null,"status":-1,"config":{"method":"GET","transformRequest": [null] ,"transformResponse": [null] ,"url":"http://localhost:8080/hawkular/alerts/triggers/thevault~local-web-multiple-jvm-metrics-trigger","headers":{"Accept":"application/json, text/plain, / ","Authorization":"Basic amRvZTpwYXNzd29yZA=="}},"statusText":""}' DUMP: 'ngResource error: "Error on Trigger query"' DUMP: 'ngResource error: "Error on Dampening query"' PhantomJS 2.1.1 (Mac OS X 0.0.0) Provider: Hawkular Alerts live REST => Retrieve an existing definition should retrieve full trigger correctly FAILED TypeError: undefined is not an object (evaluating 'resultTrigger ['trigger'] .id') in /Users/mtho11/projects/hawkular-ui-services/src/rest/hawkRest-alert-provider.spec.rest.js (line 541) /Users/mtho11/projects/hawkular-ui-services/src/rest/hawkRest-alert-provider.spec.rest.js:541:38 /Users/mtho11/projects/hawkular-ui-services/src/rest/hawkRest-alert-provider.spec.rest.js:534:13 handleCallback@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:14892:58 /Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:14720:30 processQueue@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:14745:30 /Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:14761:39 $eval@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:15989:28 $digest@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:15800:36 $apply@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:16097:31 done@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:10546:53 completeRequest@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:10744:15 requestError@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:10695:24 DUMP: 'ngResource error: {"data":null,"status":-1,"config":{"method":"GET","transformRequest": [null] ,"transformResponse": [null] ,"url":"http://localhost:8080/hawkular/alerts/triggers","params": {"triggerIds":"thevault~local-web-multiple-jvm-metrics-trigger"} ,"headers":{"Accept":"application/json, text/plain, / ","Authorization":"Basic amRvZTpwYXNzd29yZA=="}},"statusText":""}' DUMP: 'ngResource error: "Error on Triggers query 1"' DUMP: 'ngResource error: "Error on Triggers query 2"' PhantomJS 2.1.1 (Mac OS X 0.0.0) Provider: Hawkular Alerts live REST => Fetch existing definitions should retrieve full trigger correctly FAILED TypeError: undefined is not an object (evaluating 'resultTrigger ['trigger'] .id') in /Users/mtho11/projects/hawkular-ui-services/src/rest/hawkRest-alert-provider.spec.rest.js (line 607) /Users/mtho11/projects/hawkular-ui-services/src/rest/hawkRest-alert-provider.spec.rest.js:607:40 /Users/mtho11/projects/hawkular-ui-services/src/rest/hawkRest-alert-provider.spec.rest.js:600:15 handleCallback@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:14892:58 /Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:14722:30 processQueue@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:14745:30 /Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:14761:39 $eval@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:15989:28 $digest@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:15800:36 $apply@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:16097:31 done@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:10546:53 completeRequest@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:10744:15 requestError@/Users/mtho11/projects/hawkular-ui-services/lib/angular/angular.js:10695:24 DUMP: 'ngResource error: {"data":null,"status":-1,"config":{"method":"GET","transformRequest": [null] ,"transformResponse": [null] ,"url":"http://localhost:8080/hawkular/alerts/triggers/thevault~local-jvm-garbage-collection-trigger","headers":{"Accept":"application/json, text/plain, / ","Authorization":"Basic amRvZTpwYXNzd29yZA=="}},"statusText":""}' LOG: 'Pausing 5s for alert generation...' LOG: 'Continuing...' PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR ReferenceError: Can't find variable: errorfetch at /Users/mtho11/projects/hawkular-ui-services/src/rest/hawkRest-alert-provider.spec.rest.js:711 PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 6 of 16 (5 FAILED) ERROR (5.265 secs / 0.257 secs) { [Error: karma exited with code 1] plugin: 'gulp-karma', showStack: false, message: 'karma exited with code 1' } /Users/mtho11/projects/hawkular-ui-services/gulpfile.babel.js:137 throw err; ^ Error in plugin 'gulp-karma' karma exited with code 1 at done (/Users/mtho11/projects/hawkular-ui-services/node_modules/gulp-karma/index.js:56:30) at ChildProcess.<anonymous> (/Users/mtho11/projects/hawkular-ui-services/node_modules/gulp-karma/index.js:82:7) at ChildProcess.emit (events.js:110:17) at Process.ChildProcess._handle.onexit (child_process.js:1074:12)