Uploaded image for project: 'Forge'
  1. Forge
  2. FORGE-997

"beans new-bean" command should better validate user input of restricted Java keywords

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Out of Date
    • Affects Version/s: 1.3.2.Final
    • Fix Version/s: 3.x Future
    • Component/s: None
    • Labels:
      None
    • Environment:

      Eclipse Kepler + Jboss tools 4

    • Steps to Reproduce:
      Hide

      1. new-project --named Example --topLevelPackage net.example --type war;
      2. beans setup;
      3. beans new-bean --type net.example.import.Example --scoped REQUEST --overwrite

      throws
      java.lang.IllegalArgumentException
      **ERROR** Exception encountered: (type "set VERBOSE false" to disable stack traces)
      [ClubAdmin] Example.java $ at org.eclipse.jdt.core.dom.SimpleName.setIdentifier(SimpleName.java:194)
      at org.eclipse.jdt.core.dom.AST.newSimpleName(AST.java:2045)
      at org.eclipse.jdt.core.dom.AST.newName(AST.java:1795)
      at org.jboss.forge.parser.java.impl.AbstractJavaSource.setPackage(AbstractJavaSource.java:525)
      at org.jboss.forge.parser.java.impl.AbstractJavaSource.setPackage(AbstractJavaSource.java:52)
      at org.jboss.forge.spec.javaee.cdi.BeansPlugin.newBean(BeansPlugin.java:261)
      at sun.reflect.GeneratedMethodAccessor48.invoke(Unknown Source)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      at java.lang.reflect.Method.invoke(Method.java:601)
      at org.jboss.forge.shell.command.Execution.perform(Execution.java:160)
      at org.jboss.forge.shell.command.fshparser.FSHRuntime.run(FSHRuntime.java:109)
      at org.jboss.forge.shell.command.fshparser.FSHRuntime.run(FSHRuntime.java:47)
      at org.jboss.forge.shell.ShellImpl$ExecutorThread.run(ShellImpl.java:795)
      at org.jboss.forge.shell.ShellImpl.execute(ShellImpl.java:818)
      at org.jboss.forge.shell.ShellImpl.doShell(ShellImpl.java:608)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      at java.lang.reflect.Method.invoke(Method.java:601)
      at org.jboss.weld.bean.proxy.AbstractBeanInstance.invoke(AbstractBeanInstance.java:48)
      at org.jboss.weld.bean.proxy.ProxyMethodHandler.invoke(ProxyMethodHandler.java:125)
      at org.jboss.forge.shell.ShellImpl$Proxy$$$_WeldClientProxy.doShell(ShellImpl$Proxy$$$_WeldClientProxy.java)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      at java.lang.reflect.Method.invoke(Method.java:601)
      at org.jboss.weld.util.reflection.SecureReflections$13.work(SecureReflections.java:305)
      at org.jboss.weld.util.reflection.SecureReflectionAccess.run(SecureReflectionAccess.java:54)
      at org.jboss.weld.util.reflection.SecureReflectionAccess.runAsInvocation(SecureReflectionAccess.java:163)
      at org.jboss.weld.util.reflection.SecureReflections.invoke(SecureReflections.java:299)
      at org.jboss.weld.introspector.jlr.WeldMethodImpl.invokeOnInstance(WeldMethodImpl.java:188)
      at org.jboss.weld.introspector.ForwardingWeldMethod.invokeOnInstance(ForwardingWeldMethod.java:59)
      at org.jboss.weld.injection.MethodInjectionPoint.invokeOnInstanceWithSpecialValue(MethodInjectionPoint.java:198)
      at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:282)
      at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:265)
      at org.jboss.weld.event.ObserverMethodImpl.notify(ObserverMethodImpl.java:234)
      at org.jboss.weld.manager.BeanManagerImpl.notifyObservers(BeanManagerImpl.java:635)
      at org.jboss.weld.manager.BeanManagerImpl.fireEvent(BeanManagerImpl.java:622)
      at org.jboss.weld.manager.BeanManagerImpl.fireEvent(BeanManagerImpl.java:616)
      at org.jboss.forge.shell.Bootstrap$1.run(Bootstrap.java:186)
      at java.lang.Thread.run(Thread.java:722)

      Show
      1. new-project --named Example --topLevelPackage net.example --type war; 2. beans setup; 3. beans new-bean --type net.example.import.Example --scoped REQUEST --overwrite throws java.lang.IllegalArgumentException ** ERROR ** Exception encountered: (type "set VERBOSE false" to disable stack traces) [ClubAdmin] Example.java $ at org.eclipse.jdt.core.dom.SimpleName.setIdentifier(SimpleName.java:194) at org.eclipse.jdt.core.dom.AST.newSimpleName(AST.java:2045) at org.eclipse.jdt.core.dom.AST.newName(AST.java:1795) at org.jboss.forge.parser.java.impl.AbstractJavaSource.setPackage(AbstractJavaSource.java:525) at org.jboss.forge.parser.java.impl.AbstractJavaSource.setPackage(AbstractJavaSource.java:52) at org.jboss.forge.spec.javaee.cdi.BeansPlugin.newBean(BeansPlugin.java:261) at sun.reflect.GeneratedMethodAccessor48.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jboss.forge.shell.command.Execution.perform(Execution.java:160) at org.jboss.forge.shell.command.fshparser.FSHRuntime.run(FSHRuntime.java:109) at org.jboss.forge.shell.command.fshparser.FSHRuntime.run(FSHRuntime.java:47) at org.jboss.forge.shell.ShellImpl$ExecutorThread.run(ShellImpl.java:795) at org.jboss.forge.shell.ShellImpl.execute(ShellImpl.java:818) at org.jboss.forge.shell.ShellImpl.doShell(ShellImpl.java:608) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jboss.weld.bean.proxy.AbstractBeanInstance.invoke(AbstractBeanInstance.java:48) at org.jboss.weld.bean.proxy.ProxyMethodHandler.invoke(ProxyMethodHandler.java:125) at org.jboss.forge.shell.ShellImpl$Proxy$ $$_WeldClientProxy.doShell(ShellImpl$Proxy$ $$_WeldClientProxy.java) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jboss.weld.util.reflection.SecureReflections$13.work(SecureReflections.java:305) at org.jboss.weld.util.reflection.SecureReflectionAccess.run(SecureReflectionAccess.java:54) at org.jboss.weld.util.reflection.SecureReflectionAccess.runAsInvocation(SecureReflectionAccess.java:163) at org.jboss.weld.util.reflection.SecureReflections.invoke(SecureReflections.java:299) at org.jboss.weld.introspector.jlr.WeldMethodImpl.invokeOnInstance(WeldMethodImpl.java:188) at org.jboss.weld.introspector.ForwardingWeldMethod.invokeOnInstance(ForwardingWeldMethod.java:59) at org.jboss.weld.injection.MethodInjectionPoint.invokeOnInstanceWithSpecialValue(MethodInjectionPoint.java:198) at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:282) at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:265) at org.jboss.weld.event.ObserverMethodImpl.notify(ObserverMethodImpl.java:234) at org.jboss.weld.manager.BeanManagerImpl.notifyObservers(BeanManagerImpl.java:635) at org.jboss.weld.manager.BeanManagerImpl.fireEvent(BeanManagerImpl.java:622) at org.jboss.weld.manager.BeanManagerImpl.fireEvent(BeanManagerImpl.java:616) at org.jboss.forge.shell.Bootstrap$1.run(Bootstrap.java:186) at java.lang.Thread.run(Thread.java:722)

      Description

      forge command "beans new-bean --type abc.import.cde.ExampleJava" throws exception if type has 'import' in its path. Maybe other magic words as well?!

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                hrrbrt99 Hubert Schumacher
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: