Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 1.0.0.Beta2
-
Component/s: Java EE
-
Labels:None
-
Git Pull Request:
Description
With the following command the generated settings in persistence.xml are not correct. This might also be the case for other databases and settings, but I didn't test that yet.
persistence setup --provider HIBERNATE --container JBOSS_AS6 --database MYSQL_INNODB --jndiDataSource java:demo
|
It sets the datasource to: java:/DefaultDS (should be java:demo)
It sets the hibernate dialect to: org.hibernate.dialect.HSQLDialect (which should be MySQL5InnoDBDialect)
Gliffy Diagrams
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
upstream
Lincoln Baxter III
added a comment - upstream implementation was causing some other bugs, reopened
Lincoln Baxter III
added a comment - implementation was causing some other bugs, reopened Sorry about that. What bugs did you run into? I'll fix it than.
Paul Bakker
added a comment - Sorry about that. What bugs did you run into? I'll fix it than. No worries.
It would prompt because of settings conflict when first creating a persistence.xml file.
It revealed a bug in shrinkwrap descriptors in which the PersistenceDescriptor model would be null after parsing an empty persistence.xml (created when installing persistence facet before doing persistence setup)
Those things should probably be fixed, plus, I think the flow of this new stuff was a little bit weird and didn't have time to look at it yet. So keep your branch around for a little while and we'll get it there 
Other than that, I think this is definitely a good direction to take.
Lincoln Baxter III
added a comment - No worries.
It would prompt because of settings conflict when first creating a persistence.xml file.
It revealed a bug in shrinkwrap descriptors in which the PersistenceDescriptor model would be null after parsing an empty persistence.xml (created when installing persistence facet before doing persistence setup)
Those things should probably be fixed, plus, I think the flow of this new stuff was a little bit weird and didn't have time to look at it yet. So keep your branch around for a little while and we'll get it there
Other than that, I think this is definitely a good direction to take. Hey paul, did you want to revisit this? I'm not sure what still needs to be done.
Lincoln Baxter III
added a comment - Hey paul, did you want to revisit this? I'm not sure what still needs to be done. Yes I'll pick this up again. Any idea if the related shrinkwrap bug is solved already?
Paul Bakker
added a comment - Yes I'll pick this up again. Any idea if the related shrinkwrap bug is solved already? Done.
Lincoln Baxter III
added a comment - Done. 
This issue was partly because I didn't understand correctly what a container is for this plugin, and partly because Forge isn't completely clear about that either.
I fixed both