Uploaded image for project: 'Forge'
  1. Forge
  2. FORGE-227

Scaffold should support paging

    Details

    • Type: Feature Request
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 1.0.0.Alpha3
    • Fix Version/s: 1.0.0.Alpha4
    • Component/s: Plugin API
    • Labels:
      None

      Gliffy Diagrams

        Activity

        Hide
        lincolnthree Lincoln Baxter III added a comment -

        Hi. Thanks for working on this!

        Could you please send a pull request and link that URL? The link you have provided is just a link to your source tree.

        Thanks,
        Lincoln

        Show
        lincolnthree Lincoln Baxter III added a comment - Hi. Thanks for working on this! Could you please send a pull request and link that URL? The link you have provided is just a link to your source tree. Thanks, Lincoln
        Hide
        includeeasy Liu Jianhong added a comment -

        Maybe the following have one correct:

        https://github.com/includeeasy/
        https://github.com/includeeasy/core/tree/SEAMFORGE-162
        https://github.com/includeeasy/core/commit/fff4ed70469b542faa218df087f1cd5f7f8b56d3

        However, it seems not easy to see where change points on this commit,this is because my default encoding is GBK and I forget to update to UTF-8,if still have problem with compare ,then I recommit it

        Show
        includeeasy Liu Jianhong added a comment - Maybe the following have one correct: https://github.com/includeeasy/ https://github.com/includeeasy/core/tree/SEAMFORGE-162 https://github.com/includeeasy/core/commit/fff4ed70469b542faa218df087f1cd5f7f8b56d3 However, it seems not easy to see where change points on this commit,this is because my default encoding is GBK and I forget to update to UTF-8,if still have problem with compare ,then I recommit it
        Hide
        lincolnthree Lincoln Baxter III added a comment -

        To send a pull request, navigate to https://github.com/includeeasy/core/tree/SEAMFORGE-162 and click the "send pull request" button. Then fill out the subject and description and click send.

        The encoding may pose a problem. If possible, could you change this to UTF-8 and re-submit?

        Also, if you could make the following refactoring to the findRange() method:

        From:

        public <T> List<T> findRange(Class<T> type,int[] range) 

        To:

        public <T> List<T> findAll(Class<T> type,int firstResult, int maxResults)

        I think that API will be a little easier to understand, and a little less user-error prone.

        Thanks! This is good stuff.

        Show
        lincolnthree Lincoln Baxter III added a comment - To send a pull request, navigate to https://github.com/includeeasy/core/tree/SEAMFORGE-162 and click the "send pull request" button. Then fill out the subject and description and click send. The encoding may pose a problem. If possible, could you change this to UTF-8 and re-submit? Also, if you could make the following refactoring to the findRange() method: From: public <T> List<T> findRange(Class<T> type,int[] range) To: public <T> List<T> findAll(Class<T> type,int firstResult, int maxResults) I think that API will be a little easier to understand, and a little less user-error prone. Thanks! This is good stuff.
        Hide
        lincolnthree Lincoln Baxter III added a comment -

        Reviewing pull request.

        Show
        lincolnthree Lincoln Baxter III added a comment - Reviewing pull request.
        Hide
        lincolnthree Lincoln Baxter III added a comment -

        Done! Thanks for this enhancement!

        If you have not already, could you please sign this contributors agreement and make sure you have an account on jboss.org? That way I will be able to give you credit for completed issues.

        https://cla.jboss.org/

        Thanks,
        ~Lincoln

        Show
        lincolnthree Lincoln Baxter III added a comment - Done! Thanks for this enhancement! If you have not already, could you please sign this contributors agreement and make sure you have an account on jboss.org? That way I will be able to give you credit for completed issues. https://cla.jboss.org/ Thanks, ~Lincoln
        Hide
        includeeasy Liu Jianhong added a comment -

        Yes,I have and my username is "includeeasy" on https://cla.jboss.org/.

        Show
        includeeasy Liu Jianhong added a comment - Yes,I have and my username is "includeeasy" on https://cla.jboss.org/ .
        Hide
        lincolnthree Lincoln Baxter III added a comment -

        Ok. I'll try to find you again, thanks.

        Show
        lincolnthree Lincoln Baxter III added a comment - Ok. I'll try to find you again, thanks.
        Hide
        hantsy hantsy bai added a comment -

        I hope it support richfaces ExtendedDataModel(a customized DataModel support and related search criteria )...

        Show
        hantsy hantsy bai added a comment - I hope it support richfaces ExtendedDataModel(a customized DataModel support and related search criteria )...
        Hide
        lincolnthree Lincoln Baxter III added a comment -

        Hantsy, if you'd like to see this feature. Could you please file a new issue describing your needs? This issue has been closed for some time. Thanks. This sounds like something that would better belong in the RichFaces plugin:

        https://github.com/forge/plugin-richfaces

        Show
        lincolnthree Lincoln Baxter III added a comment - Hantsy, if you'd like to see this feature. Could you please file a new issue describing your needs? This issue has been closed for some time. Thanks. This sounds like something that would better belong in the RichFaces plugin: https://github.com/forge/plugin-richfaces
        Hide
        includeeasy Liu Jianhong added a comment -

        I have implemented this by add a field of "private T filter;",put filter parameter inside getItemsCount() and createPageDataModel().

        But there is problems whith isolate richfaces/icefaces/primefaces and integrate richfaces & matewidget.

        So now you can write an plugin that implement scafford api. but how can those plugins work together?

        Show
        includeeasy Liu Jianhong added a comment - I have implemented this by add a field of "private T filter;",put filter parameter inside getItemsCount() and createPageDataModel(). But there is problems whith isolate richfaces/icefaces/primefaces and integrate richfaces & matewidget. So now you can write an plugin that implement scafford api. but how can those plugins work together?
        Hide
        lincolnthree Lincoln Baxter III added a comment -

        Please try version 1.0.0.Beta1- The paging has changed in that version.

        Show
        lincolnthree Lincoln Baxter III added a comment - Please try version 1.0.0.Beta1- The paging has changed in that version.

          People

          • Assignee:
            lincolnthree Lincoln Baxter III
            Reporter:
            includeeasy Liu Jianhong
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 3 hours
              3h
              Remaining:
              Remaining Estimate - 3 hours
              3h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development