Uploaded image for project: 'Forge'
  1. Forge
  2. FORGE-2403

Bad artifact coordinates are not handled in addon-install

    Details

    • Steps to Reproduce:
      Hide

      1) Press Ctrl+4
      2) Select "Install an Addon"
      3) Add "org.myrest:myrest:,1.0.0-SNAPSHOT" in the command

      you should see the exception in the logs

      Show
      1) Press Ctrl+4 2) Select "Install an Addon" 3) Add "org.myrest:myrest:,1.0.0-SNAPSHOT" in the command you should see the exception in the logs

      Description

      The following exception is shown in the logs when an invalid coordinate is used in the addon-install command. This was captured in Eclipse, but it reproducible in the shell.

      java.lang.RuntimeException: Failed to look up versions for [org.myrest:myrest:1.0.0-SNAPSHOT]
      	at org.jboss.forge.furnace.manager.maven.addon.MavenAddonDependencyResolver.getVersions(MavenAddonDependencyResolver.java:279)
      	at org.jboss.forge.furnace.manager.maven.addon.MavenAddonDependencyResolver.resolveVersions(MavenAddonDependencyResolver.java:151)
      	at sun.reflect.GeneratedMethodAccessor182.invoke(Unknown Source)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:483)
      	at org.jboss.forge.furnace.proxy.ClassLoaderInterceptor$1.call(ClassLoaderInterceptor.java:87)
      	at org.jboss.forge.furnace.util.ClassLoaders.executeIn(ClassLoaders.java:42)
      	at org.jboss.forge.furnace.proxy.ClassLoaderInterceptor.invoke(ClassLoaderInterceptor.java:103)
      	at org.jboss.forge.furnace.manager.maven.addon.MavenAddonDependencyResolver_$$_javassist_f99af349-b96c-4386-9d23-3375d7954d63.resolveVersions(MavenAddonDependencyResolver_$$_javassist_f99af349-b96c-4386-9d23-3375d7954d63.java)
      	at org.jboss.forge.addon.manager.impl.ui.AddonInstallCommand.resolveCoordinate(AddonInstallCommand.java:148)
      	at org.jboss.forge.addon.manager.impl.ui.AddonInstallCommand.access$000(AddonInstallCommand.java:35)
      	at org.jboss.forge.addon.manager.impl.ui.AddonInstallCommand$2.validate(AddonInstallCommand.java:96)
      	at org.jboss.forge.addon.ui.impl.input.AbstractInputComponent.validate(AbstractInputComponent.java:222)
      	at sun.reflect.GeneratedMethodAccessor180.invoke(Unknown Source)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:483)
      	at org.jboss.forge.furnace.proxy.ClassLoaderInterceptor$1.call(ClassLoaderInterceptor.java:87)
      	at org.jboss.forge.furnace.util.ClassLoaders.executeIn(ClassLoaders.java:42)
      	at org.jboss.forge.furnace.proxy.ClassLoaderInterceptor.invoke(ClassLoaderInterceptor.java:103)
      	at org.jboss.forge.addon.facets.AbstractFaceted_$$_javassist_57ae4783-bb78-43f8-b132-168b83f0c74b.validate(AbstractFaceted_$$_javassist_57ae4783-bb78-43f8-b132-168b83f0c74b.java)
      	at org.jboss.forge.addon.ui.impl.controller.SingleCommandControllerImpl.validate(SingleCommandControllerImpl.java:154)
      	at org.jboss.forge.addon.ui.impl.controller.SingleCommandControllerImpl.isValid(SingleCommandControllerImpl.java:167)
      	at org.jboss.forge.addon.ui.impl.controller.SingleCommandControllerImpl.canExecute(SingleCommandControllerImpl.java:104)
      	at sun.reflect.GeneratedMethodAccessor183.invoke(Unknown Source)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:483)
      	at org.jboss.forge.furnace.proxy.ClassLoaderAdapterCallback$2.call(ClassLoaderAdapterCallback.java:123)
      	at org.jboss.forge.furnace.util.ClassLoaders.executeIn(ClassLoaders.java:42)
      	at org.jboss.forge.furnace.proxy.ClassLoaderAdapterCallback.invoke(ClassLoaderAdapterCallback.java:96)
      	at org.jboss.forge.addon.ui.controller.CommandController_$$_javassist_e238c02b-284f-425d-bcda-1f3d3241d440.canExecute(CommandController_$$_javassist_e238c02b-284f-425d-bcda-1f3d3241d440.java)
      	at org.jboss.tools.forge.ui.internal.ext.wizards.ForgeWizard.canFinish(ForgeWizard.java:80)
      	at org.eclipse.jface.wizard.WizardDialog.updateButtons(WizardDialog.java:1377)
      	at org.eclipse.jface.wizard.WizardPage.setPageComplete(WizardPage.java:311)
      	at org.jboss.tools.forge.ui.internal.ext.wizards.ForgeWizardPage.handleEvent(ForgeWizardPage.java:158)
      	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
      	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4454)
      	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1388)
      	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3799)
      	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3409)
      	at org.eclipse.jface.window.Window.runEventLoop(Window.java:832)
      	at org.eclipse.jface.window.Window.open(Window.java:808)
      	at org.jboss.tools.forge.ui.internal.ext.dialog.WizardDialogHelper.openWizard(WizardDialogHelper.java:210)
      	at org.jboss.tools.forge.ui.internal.ext.dialog.WizardDialogHelper.openWizard(WizardDialogHelper.java:102)
      	at org.jboss.tools.forge.ui.internal.ext.dialog.UICommandListDialog$1$1.handleElementSelected(UICommandListDialog.java:233)
      	at org.jboss.tools.forge.ui.internal.ext.quickaccess.QuickAccessContents.handleSelection(QuickAccessContents.java:322)
      	at org.jboss.tools.forge.ui.internal.ext.quickaccess.QuickAccessContents.access$0(QuickAccessContents.java:312)
      	at org.jboss.tools.forge.ui.internal.ext.quickaccess.QuickAccessContents$6.mouseUp(QuickAccessContents.java:461)
      	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:220)
      	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
      	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4454)
      	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1388)
      	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3799)
      	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3409)
      	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1151)
      	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
      	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1032)
      	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:148)
      	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:636)
      	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
      	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:579)
      	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
      	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:135)
      	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
      	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
      	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
      	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
      	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:483)
      	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:648)
      	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:603)
      	at org.eclipse.equinox.launcher.Main.run(Main.java:1465)
      	at org.eclipse.equinox.launcher.Main.main(Main.java:1438)
      Caused by: java.lang.IllegalArgumentException: Bad artifact coordinates org.myrest:myrest:1.0.0-SNAPSHOT:jar:forge-addon:[,), expected format is <groupId>:<artifactId>[:<extension>[:<classifier>]]:<version>
      	at org.eclipse.aether.artifact.DefaultArtifact.<init>(DefaultArtifact.java:68)
      	at org.eclipse.aether.artifact.DefaultArtifact.<init>(DefaultArtifact.java:51)
      	at org.jboss.forge.furnace.manager.maven.addon.MavenAddonDependencyResolver.getVersions(MavenAddonDependencyResolver.java:272)
      	... 74 more
      

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                gastaldi George Gastaldi
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: