Uploaded image for project: 'Forge'
  1. Forge
  2. FORGE-1991

When using the forge console the first error causes it to lock and not allow further typing

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • 3.x Future
    • 2.7.2.Final
    • UI - Eclipse
    • None
    • Hide

      project-new --named someName --topLevelPackage somepackage

      jpa-new-entity --name someName
      jpa-new-field --name --type java.land.Double.double

      You should get an error and it should lock

      Show
      project-new --named someName --topLevelPackage somepackage jpa-new-entity --name someName jpa-new-field --name --type java.land.Double.double You should get an error and it should lock

      I was using the Forge Console to create a project. I was able to create the project.

      I was then able to create a jpa-new-entity

      Then I created a field with jpa-new-field --named myField --type java.lang.Double.double

      And that worked.

      I then tried creating another field; but had a misspelling with jpa-new-field --named myField2 --type java.land.Double.double misspelling lang

      This returned an error and the console locked up and I had to restart the console. This failed and I had to restart eclipse.

            [FORGE-1991] When using the forge console the first error causes it to lock and not allow further typing

            Vineet Reynolds (Inactive) added a comment - - edited

            So, the shell is locked up until the script execution times out, because the current implementation of RunCommand does not detect any failure/result on the first error. It continues to loop expecting the command execution to return a result. Although it has the ScriptCommandListener attached to the shell, this listener is not triggered, since the execution control has not returned to the controller (SingleCommandController) yet.

            In an other thread, the error message is written out to the shell (via CommandAdapter). No message is sent to the other thread indicating failure in validation during command execution.

            Vineet Reynolds (Inactive) added a comment - - edited So, the shell is locked up until the script execution times out, because the current implementation of RunCommand does not detect any failure/result on the first error. It continues to loop expecting the command execution to return a result. Although it has the ScriptCommandListener attached to the shell, this listener is not triggered, since the execution control has not returned to the controller ( SingleCommandController ) yet. In an other thread, the error message is written out to the shell (via CommandAdapter ). No message is sent to the other thread indicating failure in validation during command execution.

            Vineet Reynolds (Inactive) added a comment -

            I cannot reproduce the issue (on both Fedora 20 and Windows 7) with the described use case.

            However, the problem does exist when I run a script. The first error during script execution causes the Forge console in Eclipse to lock up.

            Vineet Reynolds (Inactive) added a comment - I cannot reproduce the issue (on both Fedora 20 and Windows 7) with the described use case. However, the problem does exist when I run a script. The first error during script execution causes the Forge console in Eclipse to lock up.

              vineet.reynolds_jira Vineet Reynolds (Inactive)
              rhn-gps-rgreatho Robb Greathouse (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated: