Uploaded image for project: 'Forge'
  1. Forge
  2. FORGE-1698

MavenJavaCompilerFacet should use user properties instead of declaring the compiler plugin

    Details

      Description

      The current org.jboss.forge.addon.maven.projects.facets.MavenJavaCompilerFacet declares a compiler plugin with the parameters:

            <plugin>
              <artifactId>maven-compiler-plugin</artifactId>
              <version>3.1</version>
              <configuration>
                <source>1.7</source>
                <target>1.7</target>
                <encoding>UTF-8</encoding>
              </configuration>
            </plugin>
      

      As per http://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html, this could be changed to:

      <properties>
          <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
          <maven.compiler.source>1.7</maven.compiler.source>
          <maven.compiler.target>1.7</maven.compiler.target>
      </properties>
      

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                gastaldi George Gastaldi
                Reporter:
                gastaldi George Gastaldi
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: