Uploaded image for project: 'Forge'
  1. Forge
  2. FORGE-1340

MavenContainer should return exceptions stored in the Aether result objects

    Details

      Description

      The exceptions available in the Aether result classes should be returned when the Aether API is used.

      The best solution is to create a Result object .

      This includes MavenAddonDependencyResolver in furnace-manager and the maven addon.

      <gastaldi> we should break the API
      <gastaldi> but I am unsure if those exceptions shouldn't be just logged or thrown up the stack
      <vineetreynolds> gastaldi, Hmm I think they need to stored
      <gastaldi> because they shouldn't impact in the usage I guess
      <vineetreynolds> Not logged or thrown
      <gastaldi> you mean like the Result objects in Aether?
      <vineetreynolds> The choice on whether and when to throw should be decided by some other class
      <vineetreynolds> gastaldi, Yes
      <vineetreynolds> I dont think we should use the Result object in Aether directly though
      <gastaldi> of course not
      <gastaldi> but we should have our own Result object perhaps
      <vineetreynolds> Better to create our own abstraction otherwise every change in Aether would affect us
      <vineetreynolds> Yes
      <gastaldi> this is going to be nasty
      <gastaldi> but doable

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                gastaldi George Gastaldi
                Reporter:
                gastaldi George Gastaldi
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: