Uploaded image for project: 'Embedded Jopr'
  1. Embedded Jopr
  2. EMBJOPR-299

rhq-parent 3.0.0 breaks EmbJopr build: Maven's "generate-build-number-properties" execution

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 1.3.2
    • Fix Version/s: 1.4.0
    • Component/s: None
    • Labels:
      None

      Description

      This

      <plugin>
      <groupId>org.codehaus.mojo</groupId>
      <artifactId>exec-maven-plugin</artifactId>
      <executions>
      <execution>
      <id>generate-build-number-properties</id>
      <phase>generate-resources</phase>
      <goals>
      <goal>exec</goal>
      </goals>
      <configuration>
      <executable>git</executable>
      <arguments>
      <argument>log</argument>
      <argument>--pretty=format:buildNumber = %h</argument>
      <argument>-n1</argument>
      </arguments>
      <outputFile>$

      {project.build.directory}

      /build-number.properties</outputFile>
      </configuration>
      </execution>
      </executions>
      </plugin>

      breaks EmbJopr build:

      [INFO] [exec:exec

      {execution: generate-build-number-properties}

      ]
      [INFO] ------------------------------------------------------------------------
      [ERROR] BUILD ERROR
      [INFO] ------------------------------------------------------------------------
      [INFO] Result of /bin/sh c cd /mnt/hudson_workspace/workspace/EmbJopr-noajax/embjopr && git log '-pretty=format:buildNumber = %h' -n1 execution is: '128'.
      [INFO] ------------------------------------------------------------------------

      I need it to be moved to some profile or anything I can disable conditionally.

        Gliffy Diagrams

          Activity

          Hide
          ozizka Ondrej Zizka added a comment -

          There is a profile which affected this in the past. Could it be solved this way with git, too?

          <profile>
          <id>build-number-generation</id>
          <activation>
          <file>
          <exists>.svn</exists>
          </file>
          </activation>

          Show
          ozizka Ondrej Zizka added a comment - There is a profile which affected this in the past. Could it be solved this way with git, too? <profile> <id>build-number-generation</id> <activation> <file> <exists>.svn</exists> </file> </activation>
          Hide
          ozizka Ondrej Zizka added a comment -

          Attached patch: My suggestion to fix this.

          Show
          ozizka Ondrej Zizka added a comment - Attached patch: My suggestion to fix this.
          Hide
          ips Ian Springer added a comment -

          I fixed this in EmbJopr trunk w/ a hack of overriding the problematic executions from the rhq-parent pom with no-op executions. However, Ondrej, I like your suggestion and will try to update the rhq-parent pom in the next couple days.

          Show
          ips Ian Springer added a comment - I fixed this in EmbJopr trunk w/ a hack of overriding the problematic executions from the rhq-parent pom with no-op executions. However, Ondrej, I like your suggestion and will try to update the rhq-parent pom in the next couple days.
          Hide
          ips Ian Springer added a comment -

          This is fixed via the previously mentioned workaround. I've created https://bugzilla.redhat.com/show_bug.cgi?id=613767 to track the suggested improvement to the rhq root pom.

          Show
          ips Ian Springer added a comment - This is fixed via the previously mentioned workaround. I've created https://bugzilla.redhat.com/show_bug.cgi?id=613767 to track the suggested improvement to the rhq root pom.

            People

            • Assignee:
              ips Ian Springer
              Reporter:
              ozizka Ondrej Zizka
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development