Uploaded image for project: 'Drools'
  1. Drools
  2. DROOLS-3985

[DMN Editor] No Build Error about missing inputs for imported node

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Major
    • None
    • 7.22.0.Final
    • DMN Editor

    Description

      This Iss was spotted during review of PR for DROOLS-3829 and DROOLS-3934.

      If user deploy a model with imported node, and this node miss inputs, no build error appears. However there is error if user tries to execute such model, for example via rest.

      Steps To Reproduce

      1. Deploy the attached project to kie server
      2. Try to execute the model as:
        curl -u testadmin:'admin1234;' -H "accept: application/json" -H "content-type: application/json" -X POST "http://localhost:8080/kie-server/services/rest/server/containers/dmn.imports/dmn" -d "{ \"model-namespace\" : \"https://github.com/kiegroup/drools/kie-dmn/_547C193C-0B52-45F5-877E-F74A7DD29838\", \"model-name\" : \"routes\", \"decision-name\" : [\"Traffic.Traffic\" ], \"decision-id\" : [ ], \"dmn-context\" : {\"Cars Per Hour\" : 10}}"
        
      3. You will get reuslt:
        {
          "type" : "SUCCESS",
          "msg" : "OK from container 'dmn.imports'",
          "result" : {
            "dmn-evaluation-result" : {
              "messages" : [ {
                "dmn-message-severity" : "ERROR",
                "message" : "Required dependency 'Cars Per Hour' not found on node 'Traffic'",
                "message-type" : "REQ_NOT_FOUND",
                "source-id" : "_6BA74389-CBF7-4D6A-99B1-9F494DCC323A"
              } ],
              "model-namespace" : "https://github.com/kiegroup/drools/kie-dmn/_547C193C-0B52-45F5-877E-F74A7DD29838",
              "model-name" : "routes",
              "decision-name" : "Traffic.Traffic",
              "dmn-context" : {
                "Cars Per Hour" : 10,
                "Traffic" : { }
              },
              "decision-results" : {
                "https://github.com/kiegroup/drools/kie-dmn/_1876D3A2-0972-4AE8-AF59-A56AD8D4FF5F#_6BA74389-CBF7-4D6A-99B1-9F494DCC323A" : {
                  "messages" : [ {
                    "dmn-message-severity" : "ERROR",
                    "message" : "Required dependency 'Cars Per Hour' not found on node 'Traffic'",
                    "message-type" : "REQ_NOT_FOUND",
                    "source-id" : "_6BA74389-CBF7-4D6A-99B1-9F494DCC323A"
                  } ],
                  "decision-id" : "https://github.com/kiegroup/drools/kie-dmn/_1876D3A2-0972-4AE8-AF59-A56AD8D4FF5F#_6BA74389-CBF7-4D6A-99B1-9F494DCC323A",
                  "decision-name" : "Traffic.Traffic",
                  "result" : null,
                  "status" : "SKIPPED"
                }
              }
            }
          }
        }

      Actual result

      There is response error message about missing dependency but no build error message

      Expected result

      There is built error message

      Attachments

        Issue Links

          Activity

            People

              karreiro_ Guilherme Gomes (Inactive)
              rh-ee-jomarko Jozef Marko
              Jozef Marko Jozef Marko
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: